Authors CurseForge

I'd rather see ItemPrice support the same global as SellFish so ANY mod can use either one without all the special bullshit Garbage does right now. I'm gonna write up a spec on WoWWiki for this global, then we need to petition every sell value mod out there to take it up :)

http://www.wowwiki.com/API_GetSellValue

Start pressuring people to implement this!

Looks nice, tekkub. Why not add a section for addOns that would benefit from this change, e.g. GarbageFu? I love GarbageFu but find it frustrating that it often returns ?? on many TBC items.

Now that Bam has written support for http://www.wowwiki.com/API_GetSellValue into ItemPrice, what needs to be done to GarbageFu to get it to work? Or does it just work? (Can't test myself - I'm not on a WoW PC)

I'm sure Tekkub can add support just like he did for Sellfish today, or if not I can do it tonight when I get home.

Quote from starkebn »

Now that Bam has written support for http://www.wowwiki.com/API_GetSellValue into ItemPrice, what needs to be done to GarbageFu to get it to work? Or does it just work? (Can't test myself - I'm not on a WoW PC)

I tried to cobble something together but it didn't work, is there someone who knows what they're doing who could have a go at getting ItemPrice-1.0 into GarbageFu?

Just got this error while taking stuff from my mailbox (Postal):

[2007/05/23 17:06:21-114-x1]: FuBar_GarbageFu-2.0.29812\GarbageFu_Auction.lua:92: attempt to index field 'Util' (a nil value)

---

I'd like to switch to ItemPrice to use with GarbageFu, is anyone able to add support for it?

Quote from Grita »

I'd like to switch to ItemPrice to use with GarbageFu, is anyone able to add support for it?

I'm still hoping too. Sellfish is fine but it seems ItemPrice might have better compression and I can use WAU to keep it up to date.

Hi,

I added, with a really bad hack, ItemPrice-1.0 support into the GarbageFu_Vendor.lua.
As I know not very much about lua there is one dependency.
-> ItemPrice-1.0 AND IntemPriceTooltip have to be loaded and be resident in memory.

It works here now for about a week.

Would be nice if someone would replace this with a real Library-Dependency.

I noticed last night that my whites stopped appearing in my garbageFu tooltip. no auto sell/click to drop. they are still selected in the items to drop menu and the threshold is set to uncommon (thats the white one right? well the white one :P)

I update very frequently so I have the current version (or yesterdays) is this my fault(hehe) or a recent problem.

I wilol prob reinstall tonight, as well as check if my wife's is doing the same thing (oh yeah,she has it too hehe)

Here's my diff that adds the generic GetSellValue api. This works well with ItemPrice and does not need ItemPriceTooltip. It should also work with any other addon providing the GetSellValue function

Quote from fieroivan »

Here's my diff that adds the generic GetSellValue api. This works well with ItemPrice and does not need ItemPriceTooltip. It should also work with any other addon providing the GetSellValue function

Thank you, works as intended. Can someone put this on the server please. You could probably remove specific SellFish support once this is in, I think it utilises GetSellValue.

so i reenable cola lite and my whites come back and all my vendor prices are there. crazy ass thing, at least i got it working :P

Did the latest updates break GarbageFu_Vendor for anyone else?

I am getting nil errors from line 273,then 302 from the vendor.lua. Bugsack then shows Dewdrop Lib, so I am not sure if it is Dewdrop or Vendor.lua that is actually throwing the error.

I disabled every addon in my addon folder except Fubar and GarbageFU, and still it throws the error.
Man I hope someone can fix this, it takes 2 different addons to get the same functionality, and I am not real pleased with them.

Hi Jerry247,

Thanks for your diff.
Although I`m getting a error after applying your diff.

[2007/06/11 05:43:56-37-x1]: FuBar_GarbageFu-2.0.29812\GarbageFu_Vendor.lua:281: attempt to index field '?' (a nil value)
<in C code>: ?
AceEvent-2.0-38824 (Ace2):427: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:403>

I checked out the actual fubar_garbagefu via svn and applied the diff.

Regards,
Petros

Quote from fieroivan »

Here's my diff that adds the generic GetSellValue api. This works well with ItemPrice and does not need ItemPriceTooltip. It should also work with any other addon providing the GetSellValue function

This diff doesn't work. Applied properly, with both ItemPrice-1.0 & SellFish (& ItemSync & KC_Items & Ludwig (WoW 2.1) & FuBar_GarbageFu_Prices)) active. Error at logon (3 different logons tested):

"FuBar_GarbageFu-2.0.29812\\GarbageFu_Vendor.lua:282: attempt to index field '?' (a nil value)\n<in C code>: ?\nAceEvent-2.0-38824 (Ace2):427: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:403>"

And every single time you mouse over the GarbageFu "Vendor price addon order" entry in the option menu flyout, the menu doesn't open and the following error occurs:

"FuBar_GarbageFu-2.0.29812\\GarbageFu_Vendor.lua:311: attempt to index field '?' (a nil value)\nFuBar_GarbageFu-2.0.29812\\GarbageFu.lua:741: in function `OnMenuRequest'\nFuBarPlugin-2.0-34599:1104: in function <...\\FuBarPlugin-2.0\\FuBarPlugin-2.0\\FuBarPlugin-2.0.lua:1081>\nDewdrop-2.0-39294 (DewdropLib):1992: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:1941>\nDewdrop-2.0-39294 (DewdropLib):2871: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:2830>\nDewdrop-2.0-39294 (DewdropLib):548: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:532>"

On the other hand, the ItemPrice-1.0 & ItemPriceTooltip dependent hack in this different post works just fine with no errors. Well, it loads properly, still need to see if it actually retrieves values from ItemPrice properly ;).

Yes, adding a real (ItemPrice-1.0) library dependency instead of the way this hack works would be better. Would be good to have ItemPrice fully supported. Testing out SellFish with FuBar_Usage (CPU profiling active), it does not use much memory, like ItemPrice. But SellFish uses an incredible amount of CPU time. Nice work on the changes so far.

Quote from Zidomo »

Quote from fieroivan »

Here's my diff that adds the generic GetSellValue api. This works well with ItemPrice and does not need ItemPriceTooltip. It should also work with any other addon providing the GetSellValue function

This diff doesn't work. Applied properly, with both ItemPrice-1.0 & SellFish (& ItemSync & KC_Items & Ludwig (WoW 2.1) & FuBar_GarbageFu_Prices)) active. Error at logon (3 different logons tested):

"FuBar_GarbageFu-2.0.29812\\GarbageFu_Vendor.lua:282: attempt to index field '?' (a nil value)\n<in C code>: ?\nAceEvent-2.0-38824 (Ace2):427: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:403>"

And every single time you mouse over the GarbageFu "Vendor price addon order" entry in the option menu flyout, the menu doesn't open and the following error occurs:

"FuBar_GarbageFu-2.0.29812\\GarbageFu_Vendor.lua:311: attempt to index field '?' (a nil value)\nFuBar_GarbageFu-2.0.29812\\GarbageFu.lua:741: in function `OnMenuRequest'\nFuBarPlugin-2.0-34599:1104: in function <...\\FuBarPlugin-2.0\\FuBarPlugin-2.0\\FuBarPlugin-2.0.lua:1081>\nDewdrop-2.0-39294 (DewdropLib):1992: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:1941>\nDewdrop-2.0-39294 (DewdropLib):2871: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:2830>\nDewdrop-2.0-39294 (DewdropLib):548: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:532>"

On the other hand, the ItemPrice-1.0 & ItemPriceTooltip dependent hack in this different post works just fine with no errors. Well, it loads properly, still need to see if it actually retrieves values from ItemPrice properly ;).

Yes, adding a real (ItemPrice-1.0) library dependency instead of the way this hack works would be better. Would be good to have ItemPrice fully supported. Testing out SellFish with FuBar_Usage (CPU profiling active), it does not use much memory, like ItemPrice. But SellFish uses an incredible amount of CPU time. Nice work on the changes so far.

You may have some bad values in your garbagefu's savedvariable. I saw similar things happen during testing when an invalid price source was present in there. It should be in the main savedvariables folder if im remembering correctly, but it might be in the char specific one.

Quote from fieroivan »

You may have some bad values in your garbagefu's savedvariable. I saw similar things happen during testing when an invalid price source was present in there. It should be in the main savedvariables folder if im remembering correctly, but it might be in the char specific one.

Thanks for the hint. It did the job. Deleted the Fubar_GarbageFu.lua in my global SavedVariables-Directory. Now GetSellValue_API is used by GarbageFu.

Regards,
Petros

Quote from fieroivan »

Here's my diff that adds the generic GetSellValue api. This works well with ItemPrice and does not need ItemPriceTooltip. It should also work with any other addon providing the GetSellValue function

Will this be updated to the SVN? Please?