Authors CurseForge

Getting this when GarbageFu loads, only happens since i turned off PeriodicTable and PeriodicTable 2.

I dont use embedded libs just the Standalone ones, any chance of a fix


[2007/02/13 12:40:45-345-x1]: FuBar_GarbageFu\GarbageFu.lua:6: attempt to index global 'PeriodicTableEmbed' (a nil value)

---

Presumably the mod requires PT or PT2. Ask the author to update it to PT3, or turn one of the older ones back on.

same error here

[2007/02/14 11:48:49-267-x1]: FuBar_GarbageFu\GarbageFu.lua:6: attempt to index global 'PeriodicTableEmbed' (a nil value)

---

looks like the mods not been updated for a while

author has quit work on this addon according to a post he made on wowinterface.

I have actually come back, but I keep a lower profile.

There is a new version in svn that use PT3 now. It was using the original PT before.
But PT3 sure has made a mess of things.

Quote from wmrojer »

I have actually come back, but I keep a lower profile.

There is a new version in svn that use PT3 now. It was using the original PT before.
But PT3 sure has made a mess of things.

That's awesome news! Is there going to be compatibility with Kaelten's new (in progress) Ace2 KC Items? (I'd love to upgrade to it and haven't simply because I can't face life without GarbageFu.)

-Baraius

Quote from Baraius »

That's awesome news! Is there going to be compatibility with Kaelten's new (in progress) Ace2 KC Items? (I'd love to upgrade to it and haven't simply because I can't face life without GarbageFu.)

-Baraius

Sure.
Do you have a code snippet that will ask it for an items price Vendor and Auction?

Noticed on Sunday 3/4 after a WAU run that the GarbageFu provided trash can on the vendor window was in a different place. It was up higher than normal, about half on/half off the window vertically and more to the right than normal, covering about half of the "X" icon that closes the vendor window. Worked just fine, just a little high and to the right.

r29456 is what I'm running. I see in the change logs: "Fixed Sell All button location when Skinner is loaded." I run Skinner, but only for the top/bottom frames, no skinning of frames is turned on. IOW, the vendor frame is the default Blizzard one, not a skinned one.

Any ideas?

Quote from Samala »

Noticed on Sunday 3/4 after a WAU run that the GarbageFu provided trash can on the vendor window was in a different place. It was up higher than normal, about half on/half off the window vertically and more to the right than normal, covering about half of the "X" icon that closes the vendor window. Worked just fine, just a little high and to the right.

r29456 is what I'm running. I see in the change logs: "Fixed Sell All button location when Skinner is loaded." I run Skinner, but only for the top/bottom frames, no skinning of frames is turned on. IOW, the vendor frame is the default Blizzard one, not a skinned one.

Any ideas?

Change the following lines in GarbageFu_Sell.lua

		if Skinner and Skinner.applySkin then
			sellAllButton:SetPoint("TOPRIGHT", MerchantFrame, "TOPRIGHT", -44, -10)
		else		
			sellAllButton:SetPoint("TOPRIGHT", MerchantFrame, "TOPRIGHT", -44, -38)
		end

to

--		if Skinner and Skinner.applySkin then
--			sellAllButton:SetPoint("TOPRIGHT", MerchantFrame, "TOPRIGHT", -44, -10)
--		else		
			sellAllButton:SetPoint("TOPRIGHT", MerchantFrame, "TOPRIGHT", -44, -38)
--		end

Thanks!

I use Skinner only for my chat windows and the bottom panel of my interface. Nothing more. So every time I download the latest version of GarbageFu, I have to manually edit the GarbageFu_Sell.lua to position the trash icon as stated above.

Is it possible to have the GarbageFu logic check to see if I have the Merchant window skinned instead of just checking to see if I have Skinner loaded?

Thanks.

Is it possible to have the GarbageFu logic check to see if I have the Merchant window skinned instead of just checking to see if I have Skinner loaded?

I'll second that.

Quote from wmrojer »

Quote from Baraius »

That's awesome news! Is there going to be compatibility with Kaelten's new (in progress) Ace2 KC Items? (I'd love to upgrade to it and haven't simply because I can't face life without GarbageFu.)

-Baraius

Sure.
Do you have a code snippet that will ask it for an items price Vendor and Auction?

Here is a bit from Manufac:

	if KC_Items and not KC_Items.common then
		local buyout = select(10,AuctionSpy:GetItemInfo(UnitFactionGroup("player"), AuctionSpy:GetLongCode(link)))
		local sell, buy = SellValues:GetPrices(link)
		return sell, buy, buyout

I believe the first bit allows you to distinguish between KCI1 and KCI2 :-) The next line being Auction price and the next being Vendor price.

Is that what you need?

-Baraius

Now that ColaLight has been abandoned could you please add support for the prices from SellFish?

Quote from starkebn »

Now that ColaLight has been abandoned could you please add support for the prices from SellFish?

Pretty please?

This is what I put into GarbageFu_Vendor.lua in order to use SellFish.

Insert the function reference at the top of the file:

 GarbageFu.vars.vendoraddons = {
	["sellfish"] = {name="SellFish", func="GetSellFishVendorPrice", check="SellFishDB" },

Put a reference to SellFish so GarbageFu looks for it:

GarbageFu.vars.vendoraddonsorder = {
	"sellfish",

And then insert the following function anywhere from around line 83 onwards:

-- SellFish
function GarbageFu:GetSellFishVendorPrice(item)
	if SellFishDB then
		return SellFish:GetCost(item.id), "|cff0077ffVS|r"
	end
end

This was derived from part ignorance, part fiddling, but it works so far. Hopefully it doesn't break anything :)

Thanks for muddling it out Sprocketty - your code is working fine for me so far

I committed in that code, so the SVN version supports sellfish now.

Now its time for...ItemPrice-1.0 support. The single supported Ace2 addon of its type currently.

ItemPrice-1.0 is a sell-value library that works in conjunction with ItemPriceTooltip for user display of its data. Or it can be used by other addons.

Bam (the dev) has been updating the sell prices in it very frequently. Also has done great work on compression of the stored data to make it small & efficient. It would be really nice to have this supported in GarbageFu.