Wrong for me as well. The next one will be AB this coming weekend, and HonorFu doesn't list that, nor any other holiday weekend correctly. I play on the US servers.
Call to Arms: Arathi Basin! January 5 - January 8
Call to Arms: Alterac Valley! January 19 - January 22
Call to Arms: Warsong Gulch! January 26 - January 29
I can confirm that Defilers Emissaries just turned up in Orgrimmar (Oceania server). This is definitely an AB weekend, while HonorFu says it's a free weekend.
This isn't a bug in HonorFu so much as it is in Glory-2.0.
Edit: never mind.
Temporary fix: Change lines 906-916 in Glory-2.0.lua to the following:
function Glory:GetCurrentOrNextArathiWeekend()
return GetCurrentOrNextBattlegroundWeekend(1)
end
function Glory:GetCurrentOrNextWarsongWeekend()
return GetCurrentOrNextBattlegroundWeekend(4)
end
function Glory:GetCurrentOrNextAlteracWeekend()
return GetCurrentOrNextBattlegroundWeekend(3)
end
That gives the correct weekends for January. I'm not sure if it works for the rest of the year. I've modified my local copy, but am not going to touch the SVN version without a response from ckknight or someone else knowledgeable and authoritative.
BG weekends are wrong for me as well and as I haven't got the slightest idea what Glory is or even if I use it, I'd like to know if there's a fix coming for this.
Zealot, do you know if that's just returning the corresponding weekend number from the month? If so, some months will have 4 weekends, and some will have 5.
I believe the BGs are on a 4 week rotation no matter what, so it would make sense to me to set a start date, and calculate the number of weeks from there...forever.
I have no clue. I played around with my local copy of Glory until I found something that made it work for January. ckknight responded on IRC that it wouldn't be a horrible thing if we had to update it again next month if it doesn't work for it too, so I went ahead and committed my Glory changes.
If someone else can work up a better algorithm for it all, wonderful.
That's what I'm saying... it's wrong.
http://www.worldofwarcraft.com/info/events/calendar/
Call to Arms: Arathi Basin! January 5 - January 8
Call to Arms: Alterac Valley! January 19 - January 22
Call to Arms: Warsong Gulch! January 26 - January 29
I can confirm that Defilers Emissaries just turned up in Orgrimmar (Oceania server). This is definitely an AB weekend, while HonorFu says it's a free weekend.
Edit: never mind.
Temporary fix: Change lines 906-916 in Glory-2.0.lua to the following:
That gives the correct weekends for January. I'm not sure if it works for the rest of the year. I've modified my local copy, but am not going to touch the SVN version without a response from ckknight or someone else knowledgeable and authoritative.
Just did, and it seems to work. Thanks.
I believe the BGs are on a 4 week rotation no matter what, so it would make sense to me to set a start date, and calculate the number of weeks from there...forever.
If someone else can work up a better algorithm for it all, wonderful.