I think I'd go with an option. That would leave it up to the user. If you're going to do automatic scaling, I'd play with scaling based on the font size in the UI. IE fontSize + 4.
I noticed that it doesn't update on Loot properly, so I looked it up, and I think you forgot to RegisterEvent("BAG_UPDATE") ;) Tried it today and works ;)
I tryed out this mod and I can't seem to make it show gains/losses of honor/marks/arena points/emblems and such. Am I missing something? Or is this not implemented yet? I got the impression it was implemented that way when reading the forum and addon description. If it's not implemented that way, can it be? Thanks.
Edit: If anyone knows a mod out there that does track gains of all the varying forms of currency, please let me know. I have been searching all over. Thanks.
I noticed that it doesn't update on Loot properly, so I looked it up, and I think you forgot to RegisterEvent("BAG_UPDATE") ;) Tried it today and works ;)
Bye, Ravengus.
So this is why it isn't seeing me get the dalaran cooking token from the loot baggie, eh? tk, fixies, plzorz.
...I can't seem to make it show gains/losses of honor/marks/arena points/emblems and such. Am I missing something? Or is this not implemented yet? I got the impression it was implemented that way when reading the forum and addon description. If it's not implemented that way, can it be? Thanks...
It is not at the moment. I plan on upgrading it soon since I want to see how many food stamps I get during a raid instead of going back and looking for "You received 1 foodstamp" etc. in the chat log.
I am loathe to add BAG_UPDATE as that fires a lot for hunters during combat.
An event that fires once per second or so is hardly "a lot", compared to chat events, aura events, combat log events and hp/mana events, particularly if you do very little processing.
In any case, you can register for BAG_UPDATE on the event LOOT_OPENED, and unregister it on LOOT_CLOSED (I'm not sure if BAG_UPDATEs fire before or after LOOT_CLOSED, or simply delay it for a while)
You can use a timer to throttle down processing based on BAG_UPDATE events, if you are worried about performance. Just fire an update let's say after a second or 2 from the last event fired, regardless of how many times you get spammed by it.
.... I made that exact kind of suggestion to someone, somewhere else, involving a different addon, but regarding a very similar situation.. and got my ass chewed out and called a nub by said author for even suggesting it.
.... I made that exact kind of suggestion to someone, somewhere else, involving a different addon, but regarding a very similar situation.. and got my ass chewed out and called a nub by said author for even suggesting it.
...suggestion...regarding a very similar situation...and got my ass chewed out and called a nub by said author for even suggesting it...
That sucks dude. If it is any consolation, AutoBar throttles almost all events but especially bag events that way.
The bottom line is this: right now, with only Grid and some heal things I need enabled, my comp totally locks up during a faction boss fight. If I am lucky 20 seconds of < 1fps resolves itself and I can finish the fight. If not I get a dc.
Anyone that claims "its ok to waste cycles during combat" is just flat out wrong. Yes I realize other things are chewing up more cycles at that point, but any overhead whatsoever at that point is not helping.
That sucks dude. If it is any consolation, AutoBar throttles almost all events but especially bag events that way.
The bottom line is this: right now, with only Grid and some heal things I need enabled, my comp totally locks up during a faction boss fight. If I am lucky 20 seconds of < 1fps resolves itself and I can finish the fight. If not I get a dc.
Anyone that claims "its ok to waste cycles during combat" is just flat out wrong. Yes I realize other things are chewing up more cycles at that point, but any overhead whatsoever at that point is not helping.
I find this to be incorrect thinking. Because saving overhead on a negligible addon isn't helping the problem. Even if you did not throttle, I assure you your addon will not affect FPS in the slightest. Your 1 FPS is going to remain 1 FPS whether you throttle or not.
...I assure you your addon will not affect FPS in the slightest...
I think your math is wrong. When fps is high there is lots of slack in the system and as you say the tiny amount of time you use up per mod is not only negligible but irrelevant. However when the system is choking these tiny amounts are directly delaying the next frame getting pushed out. Tiny inefficiencies scale up to be big delays at that point.
It is true that disabling QuestHelper or some other beast may have actual measurable impact so you get bigger bang for your buck fixing such mods first. Fine. Meanwhile I try not to float bad code examples out there. It has taken more of my time to debate this than to actually check in good code.
Another way of phrasing this old boring argument is "todays inefficiencies are obsolete because the hardware improves to make it so we can write bad code and it will not matter".
Only it does matter. Look at the terrible javascript performance on IE. It is decades since a mac could not only provide a gui editor but keep up with your keyboard input. Not so when I do some web mail apps on IE. I actually have to go fix typos caused not by me, but by dropped characters because the web app is pitifully slow.
When you have a choice between good efficient code and sloppy code, just do the right thing. Take pride in your code.
...I can't seem to make it show gains/losses of honor/marks/arena points/emblems and such...
I checked in an alpha version that starts to show some of this. It is by no means complete yet. It also requires LibQTip to be integrated so the columns can have individual formatting with columns aligned finally as a fringe benefit.
This now has LibQtip to align columns and individually color particular cells. Let me know how well this scales on your particular UI's.
There is also a new setting for showing gold in the popup which defaults to false. Check it to show gold in the popup. The release version and current alpha will default to true for new users or reset SV.
Feature wise this seems complete to me now (+/- any tweaking needed for proper display on various ui scales, maintenance, etc.)
I may clean the code up a bit to take care of some algorithm necrosis that crept in during development. Other than that I declare it good and done.
Is it possible to make tooltip show all you current character currency data ? There is too many items to enable them all either on LDB feed or in summary, so i have only important ones enabled but sometimes you need to check some rare currency and need to open character info panel each time for that.
[2009/01/29 17:19:30-1102-x1]: Broker_Currency-v3.00.08.12\core.lua:627: attempt to compare nil with number
Broker_Currency-v3.00.08.12\core.lua:1009: in function `InitializeSettings'
Broker_Currency-v3.00.08.12\core.lua:571: in function <Interface\AddOns\Broker_Currency\core.lua:569>
Is it possible to make tooltip show all you current character currency data...
Good idea, messing with the settings all the time does suck. With the icons as column labels this is not strraightforward anymore.
Some possible approaches:
1) Some kind of click functionality on the broker itself to switch between displaying absolutely everything for the current character and what it normally does.
2) A modifier key that would temporarily switch the popup to showing everything for the current character only.
3) A new section you can turn on that displays everything for the current character but spread across the current number of columns and over multiple lines. The fever columns you have the more lines it would take so it could make the popup too long to fit on small screens.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI noticed that it doesn't update on Loot properly, so I looked it up, and I think you forgot to RegisterEvent("BAG_UPDATE") ;) Tried it today and works ;)
Bye, Ravengus.
Edit: If anyone knows a mod out there that does track gains of all the varying forms of currency, please let me know. I have been searching all over. Thanks.
So this is why it isn't seeing me get the dalaran cooking token from the loot baggie, eh? tk, fixies, plzorz.
I am loathe to add BAG_UPDATE as that fires a lot for hunters during combat.
It is not at the moment. I plan on upgrading it soon since I want to see how many food stamps I get during a raid instead of going back and looking for "You received 1 foodstamp" etc. in the chat log.
Originally I did not think that would be needed.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAn event that fires once per second or so is hardly "a lot", compared to chat events, aura events, combat log events and hp/mana events, particularly if you do very little processing.
In any case, you can register for BAG_UPDATE on the event LOOT_OPENED, and unregister it on LOOT_CLOSED (I'm not sure if BAG_UPDATEs fire before or after LOOT_CLOSED, or simply delay it for a while)
heh
break19
Oh, I do remember that one :p
That sucks dude. If it is any consolation, AutoBar throttles almost all events but especially bag events that way.
The bottom line is this: right now, with only Grid and some heal things I need enabled, my comp totally locks up during a faction boss fight. If I am lucky 20 seconds of < 1fps resolves itself and I can finish the fight. If not I get a dc.
Anyone that claims "its ok to waste cycles during combat" is just flat out wrong. Yes I realize other things are chewing up more cycles at that point, but any overhead whatsoever at that point is not helping.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI find this to be incorrect thinking. Because saving overhead on a negligible addon isn't helping the problem. Even if you did not throttle, I assure you your addon will not affect FPS in the slightest. Your 1 FPS is going to remain 1 FPS whether you throttle or not.
I think your math is wrong. When fps is high there is lots of slack in the system and as you say the tiny amount of time you use up per mod is not only negligible but irrelevant. However when the system is choking these tiny amounts are directly delaying the next frame getting pushed out. Tiny inefficiencies scale up to be big delays at that point.
It is true that disabling QuestHelper or some other beast may have actual measurable impact so you get bigger bang for your buck fixing such mods first. Fine. Meanwhile I try not to float bad code examples out there. It has taken more of my time to debate this than to actually check in good code.
Another way of phrasing this old boring argument is "todays inefficiencies are obsolete because the hardware improves to make it so we can write bad code and it will not matter".
Only it does matter. Look at the terrible javascript performance on IE. It is decades since a mac could not only provide a gui editor but keep up with your keyboard input. Not so when I do some web mail apps on IE. I actually have to go fix typos caused not by me, but by dropped characters because the web app is pitifully slow.
When you have a choice between good efficient code and sloppy code, just do the right thing. Take pride in your code.
I checked in an alpha version that starts to show some of this. It is by no means complete yet. It also requires LibQTip to be integrated so the columns can have individual formatting with columns aligned finally as a fringe benefit.
This now has LibQtip to align columns and individually color particular cells. Let me know how well this scales on your particular UI's.
There is also a new setting for showing gold in the popup which defaults to false. Check it to show gold in the popup. The release version and current alpha will default to true for new users or reset SV.
Feature wise this seems complete to me now (+/- any tweaking needed for proper display on various ui scales, maintenance, etc.)
I may clean the code up a bit to take care of some algorithm necrosis that crept in during development. Other than that I declare it good and done.
[2009/01/29 17:19:30-1102-x1]: Broker_Currency-v3.00.08.12\core.lua:627: attempt to compare nil with number
Broker_Currency-v3.00.08.12\core.lua:1009: in function `InitializeSettings'
Broker_Currency-v3.00.08.12\core.lua:571: in function <Interface\AddOns\Broker_Currency\core.lua:569>
---
Weird, I thought I am initializing that. Does it go away with a restart or does it keep happening?
Good idea, messing with the settings all the time does suck. With the icons as column labels this is not strraightforward anymore.
Some possible approaches:
1) Some kind of click functionality on the broker itself to switch between displaying absolutely everything for the current character and what it normally does.
2) A modifier key that would temporarily switch the popup to showing everything for the current character only.
3) A new section you can turn on that displays everything for the current character but spread across the current number of columns and over multiple lines. The fever columns you have the more lines it would take so it could make the popup too long to fit on small screens.
I like #2