Just a sugestion and perhaps abit of cosmetic adjustment.
I found that chocolate wont center verticaly the text perfectly on the bar and the icons are a bit distorted and small, I did played with bar vertical size and text size though
I included a image I made comparing Fubar to Chocolate, and I think you can see that the text could come 1-2px down and the icons could be a bit bigger or perhaps give us a option to tweak such things.
I found that chocolate wont center verticaly the text perfectly on the bar and the icons are a bit distorted and small, I did played with bar vertical size and text size though
I'll look into it. Probably a problem with the one pixel gap at the top that I have fixed but at some resolutions/settings is not there.
I don't want the icons to be the full height of the bar, maybe an option to set some insets.
I'm wondering if you can add in the feature of being able to lock chocolate bar so when you click on it it doesn't bring up the option menu. I like the ability to click on certain mods during combat, but have noticed from time to time during combat I accidentally click chocolate bar and it brings up the option screen during combat. I know you can lock all clicks during combat, but like I said there is the occasional mod I like to click open to see something quickly during a lull in a combat phase.
I'm wondering if you can add in the feature of being able to lock chocolate bar so when you click on it it doesn't bring up the option menu. I like the ability to click on certain mods during combat, but have noticed from time to time during combat I accidentally click chocolate bar and it brings up the option screen during combat. I know you can lock all clicks during combat, but like I said there is the occasional mod I like to click open to see something quickly during a lull in a combat phase.
Message: ...ns\ChocolateBar\libs\LibJostle-3.0\LibJostle-3.0.lua:90: hooksecurefunc(): FCF_UpdateCombatLogPosition is not a function
Time: 07/02/10 10:43:24
Count: 1
Stack: [C]: in function `hooksecurefunc'
...ns\ChocolateBar\libs\LibJostle-3.0\LibJostle-3.0.lua:90: in main chunk
Install LibJostle-3.0 as an independent install, and select alpha as the install type. Easily done with the Curse Client; a bit more work manually, but still doable.
my object is written to only have an icon in the event theres no text, as soon as theres any text the icon is removed (nil'd, tried false too).
the problem is that that only works on first load. for some reason if i set the icon to nil/false in the update it wont remove it? it just leaves it there.
if i set the icon to "" instead then it goes away, but i end up with a small blank space where the icon should be, its not completely gone.
not sure if LDB can actually handle this or if its an issue with CB? or i'm just doing it completely wrong?
is there any alpha versions for 4.0.x beta. CB kinda works on Beta atm but there is no way to use the options it that coudl be patched i would like to test it on beta thanks
is there any alpha versions for 4.0.x beta. CB kinda works on Beta atm but there is no way to use the options it that coudl be patched i would like to test it on beta thanks
ok thanks working on beta now just one small minor issues now. is the buffs and minimap dont move when the check mark is set to move blizzard frames. other then that its working like normal in beta
I tried this today and have a little problem.
I'm using an viewport addon, and so i dont want to have this bar over the complete screen.
So i went into the config, checked "free positioning", disabled "locked" and arranged a little smaler bar.
But i am not able to move it. Its allways sticked to the left corner and i cant move it away.
Is this intentional or does anyone have a idea?
text is always there, its never nil, it might be "" though, its the icon i'm setting to nil.
i was doing this because i was adding multiple textures in the text so didnt need the icon as well when it had text. ie i had the icon set only when i didnt add any text.
if im tracking a currency then theres no icon, except the icon never goes away when i set it to nil - but only if it was previously set.
if i do a uireload then the icon doesnt appear, if i then untrack all currencies (so the icon is set) then the icon comes back (working correctly), if i then track a currency (so the icon is set to nil) then the icon doesnt go away (this is the problem), its still there even though ive set it to nil.
i've tried nil and false (which are fine for no icon) and "" (which isnt, it leaves an empty space where an icon should go)
sorry this is long, i just wanted to try and clarify it properly.
self.text = ""
local hasText = false
-- expand all token headers
local numTokenTypes = GetCurrencyListSize( )
local name, isHeader, isExpanded, isUnused, isWatched, count, currencyType, icon
for j = numTokenTypes, 1, -1 do
name, isHeader, isExpanded = GetCurrencyListInfo( j )
if isHeader and not isExpanded then
ExpandCurrencyList( j, 1 )
end
end
numTokenTypes = GetCurrencyListSize( )
for j = 1, numTokenTypes do
name, isHeader, isExpanded, isUnused, isWatched, count, icon = GetCurrencyListInfo( j )
if not isHeader then
if ArkInventory.db.char.option.ldb.tracking.currency.tracked[name] then
self.text = string.format( "%s |T%s:0|t %d", self.text, icon or ArkInventory.Const.Texture.Missing, count or 0 )
hasText = true
end
end
end
if hasText then
self.icon = nil
else
self.icon = ArkInventory.Global.Location[ArkInventory.Const.Location.Token].Texture
end
r101 fixed the problem, thanks.
I found that chocolate wont center verticaly the text perfectly on the bar and the icons are a bit distorted and small, I did played with bar vertical size and text size though
I included a image I made comparing Fubar to Chocolate, and I think you can see that the text could come 1-2px down and the icons could be a bit bigger or perhaps give us a option to tweak such things.
here is the pic.
Thanks and keep up the good work.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt's an AceConfig thing.
But I just found a simple solution, at least it works for me, see Ticket
I'll look into it. Probably a problem with the one pixel gap at the top that I have fixed but at some resolutions/settings is not there.
I don't want the icons to be the full height of the bar, maybe an option to set some insets.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumjust added
1x ChocolateBar-r107\DragAndDrop.lua:86: attempt to index upvalue 'focus' (a nil value) ChocolateBar-r107\Chocolate.lua:290: in function <ChocolateBar\Chocolate.lua:286> Locals: frame = Chocolatetekability { 0 = <userdata> text = <unnamed> {} Update = <function> @ ChocolateBar\Chocolate.lua:253: isMoving = false settings = <table> {} obj = <table> {} name = "tekability" icon = <unnamed> {} bar = ChocolateBar1 {} } ChocolateBar = <table> { OnEnterWorld = <function> @ ChocolateBar\Core.lua:243: SetDefaultModuleLibraries = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:381: TempDisAutohide = <function> @ ChocolateBar\Core.lua:347: Enable = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:313: RegisterChatCommand = <function> @ Broker_Wintergrasper\Libs\AceConsole-3.0\AceConsole-3.0.lua:85: EnableModule = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:346: modules = <table> {} GetModule = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:230: IterateEmbeds = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:456: dragging = true NewModule = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:255: defaultModuleLibraries = <table> {} OnInitialize = <function> @ ChocolateBar\Core.lua:120: baseName = "ChocolateBar" UnregisterChatCommand = <function> @ Broker_Wintergrasper\Libs\AceConsole-3.0\AceConsole-3.0.lua:111: UpdateDB = <function> @ ChocolateBar\Core.lua:510: Disable = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:328: AnchorBars = <function> @ ChocolateBar\Core.lua:433: Printf = <function> @ Broker_Wintergrasper\Libs\AceConsole-3.0\AceConsole-3.0.lua:69: OnLeaveCombat = <function> @ ChocolateBar\Core.lua:258: GetName = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:298: DisableDataObject = <function> @ ChocolateBar\Core.lua:326: AddBar = <function> @ ChocolateBar\Core.lua:408: UpdateChoclates = <function> @ ChocolateBar\Core.lua:399: name = "ChocolateBar" UpdateBars = <function> @ ChocolateBar\Core.lua:425: IsEnabled = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:465: LibDataBroker_DataObjectCreated = <function> @ ChocolateBar\Core.lua:272: GetBars = <function> @ ChocolateBar\Core.lua:371: DisableModule = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:364: GetChocolate = <function> @ ChocolateBar\Core.lua:363: GetBar = <function> @ ChocolateBar\Core.lua:367: UnregisterMessage = <function> @ BankStack\lib\CallbackHandler-1.0\CallbackHandler-1.0.lua:181: EnableDataObject = <function> @ ChocolateBar\Core.lua:285: RegisterMessage = <function> @ BankStack\lib\CallbackHandler-1.0\CallbackHandler-1.0.lua:118: GetArgs = <function> @ Broker_Wintergrasper\Libs\AceConsole-3.0\AceConsole-3.0.lua:144: Print = <function> @ Broker_Wintergrasper\Libs\AceConsole-3.0\AceConsole-3.0.lua:54: SetBars = <function> @ ChocolateBar\Core.lua:375: OnEnterCombat = <function> @ ChocolateBar\Core.lua:248: OnDisable = <function> @ ChocolateBar\Core.lua:232: OnEnable = <function> @ ChocolateBar\Core.lua:219: IsModule = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:482: db = <table> {} SetDefaultModuleState = <function> @ AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:401: SetDropPoins = <function> @ ChocolateBar\Core.lua:105: Debug = <function> def ----
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumVery easy to fix to, just comment out
if not Jostle.hooks.FCF_UpdateCombatLogPosition then ...in LibJostle and update the minor number (for your local copy). After that, everything works like a charm.
Time: 07/02/10 10:43:24
Count: 1
Stack: [C]: in function `hooksecurefunc'
...ns\ChocolateBar\libs\LibJostle-3.0\LibJostle-3.0.lua:90: in main chunk
Locals:
-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Curse Premiumthe problem is that that only works on first load. for some reason if i set the icon to nil/false in the update it wont remove it? it just leaves it there.
if i set the icon to "" instead then it goes away, but i end up with a small blank space where the icon should be, its not completely gone.
not sure if LDB can actually handle this or if its an issue with CB? or i'm just doing it completely wrong?
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumText is a required field.
Fixed in r110.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm using an viewport addon, and so i dont want to have this bar over the complete screen.
So i went into the config, checked "free positioning", disabled "locked" and arranged a little smaler bar.
But i am not able to move it. Its allways sticked to the left corner and i cant move it away.
Is this intentional or does anyone have a idea?
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumtext is always there, its never nil, it might be "" though, its the icon i'm setting to nil.
i was doing this because i was adding multiple textures in the text so didnt need the icon as well when it had text. ie i had the icon set only when i didnt add any text.
if im tracking a currency then theres no icon, except the icon never goes away when i set it to nil - but only if it was previously set.
if i do a uireload then the icon doesnt appear, if i then untrack all currencies (so the icon is set) then the icon comes back (working correctly), if i then track a currency (so the icon is set to nil) then the icon doesnt go away (this is the problem), its still there even though ive set it to nil.
i've tried nil and false (which are fine for no icon) and "" (which isnt, it leaves an empty space where an icon should go)
sorry this is long, i just wanted to try and clarify it properly.
self.text = "" local hasText = false -- expand all token headers local numTokenTypes = GetCurrencyListSize( ) local name, isHeader, isExpanded, isUnused, isWatched, count, currencyType, icon for j = numTokenTypes, 1, -1 do name, isHeader, isExpanded = GetCurrencyListInfo( j ) if isHeader and not isExpanded then ExpandCurrencyList( j, 1 ) end end numTokenTypes = GetCurrencyListSize( ) for j = 1, numTokenTypes do name, isHeader, isExpanded, isUnused, isWatched, count, icon = GetCurrencyListInfo( j ) if not isHeader then if ArkInventory.db.char.option.ldb.tracking.currency.tracked[name] then self.text = string.format( "%s |T%s:0|t %d", self.text, icon or ArkInventory.Const.Texture.Missing, count or 0 ) hasText = true end end end if hasText then self.icon = nil else self.icon = ArkInventory.Global.Location[ArkInventory.Const.Location.Token].Texture end