Authors CurseForge

launchers = use label then text for display.

for data sources: (i can show you the code-ish logic better than explaining it.)

if obj.label and obj.value then
    if db.showLabel then
        ():SetText(label..value..(suffix or ""))
    else
        ():SetText(value..(suffix or ""))
    end
elseif obj.text then
    ():SetText(obj.text)
end

IMO that's the rational way of doing labels. However it's also been seen where the value is formatted into the label, but it's less prevalent.


On a side note, i also ran into this problem recently when adding a ldb feed to SickOfClickingDailies to show when the dailies reset.

arnath2, don't u just love standards :)

Why would it hold the sources name? it is an irrelevant piece of information to be held inside an object. (obj.name) suits this need perfectly, and in chocolate bar it does set obj.name = name.

Quote from arnath2

That said, I'm fairly certain (correct me if I'm wrong) that ChocolateBar shows label text for data sources if there is no text. It would be nice if this was toggle-able, i.e., show the text if there is some but otherwise show nothing.

Yes but text is a *required* field for any data source. If one data object does it wrong you can easily disable the text for it by dragging it to the toggle text drop point.

Well given my new understanding of how the label/value/suffix thing works in LDB, I'd like to reiterate my request for label support, particularly something like the bit of code OrionShock posted a few posts ago.

Why do you need label support?
Is it not clear form the icon and text what a data source does and which addon it probably is?

I have finally added localization.

Goto
http://www.wowace.com/projects/chocolatebar/localization/
if you want to help with the localization.

I have already done German.

Quote from yess

I have already done German.

Updated deDE a bit ;)

Btw: I fear I have to hack it so it stays English for me ;) All that chocolate stuff is very weird for me to read in German :o

I agree, but I believe its weird in English too^^
You could also play with the English game version like I do.

Btw: I like my wired German spelling, I do it deliberately but thanks for the fix^^

maybe a minor thing. But you use of LSM is a bit akward. Periodically when i load into the game the texture isn't set right.

local LSM = LibStub("LibSharedMedia-3.0")
LSM:RegisterCallback("LibSharedMedia_Registered", function(event, mediaType, value)
    if mediaType == "statusbar" then
        for k,v in pairs(chocolateBars) do
            v:UpdateTexture(db)
        end
    end
end)

Added to the end of the core file works just fine.

thanks, I'll add that. If I should change something else just let me know.

is there a way to select the font you want to use for all the text on the bars?

No, the only way to change the font at the moment is to change the WoW fonts like some font addons do.

But I can add an option to let you select a font provided by LibSharedMedia.

Quote from yess

No, the only way to change the font at the moment is to change the WoW fonts like some font addons do.

But I can add an option to let you select a font provided by LibSharedMedia.

Don't forget to also adjust the LSM callback to account for the fonts been added on load :)

Quote from yess

But I can add an option to let you select a font provided by LibSharedMedia.

yes please. i think a lot of people already use LSM based fonts for everything else (i know i do), so having the bars look the same as the rest of the UI would be really nice.

Quote from OrionShock

Don't forget to also adjust the LSM callback to account for the fonts been added on load :)

I won't, not this time:)

But I don't want to update all the frames with the font I get from LSM on every callback.
I am also not happy with the way I postponed the texture update for the bars until PLAYER_ENTERING_WORLD is fired.

Maybe its best to save the actual texture/font path. That way I don't even need the LSM callback and you can use textures from disabled addons.

The Nice part about the LSM callback is that if the addon is removed, then LSM returns a default element.. there are bennifits to LSM's callback.

What you could do is make a timmer and grab the update ~3sec after load

Yes I know about the default media but I don't think that it is better to get a wrong texture instead of none.
It makes more sense for the font. Some users will freak out when suddenly there isn't a font anymore^^
But it is not that hard to right click the panel and select a new font if you have removed the addon the font is from.

I really hate the idea of a timer oO

Also some addons won't load until a specific action like joining a raid. If you select a texture provided by that addon if will not show until then.

edit:

Quote from yssaril

to check if your font is available you can check with

LibStub("LibSharedMedia-3.0"):IsValid('font', font_name_here)

that returns true if its available and false if not :P

Ah ok, but when do I know that there are no more callbacks coming?