Display addons control how to display the DOs. If SBC wants to give you an option to change the text, then that's an extra feature of SBC.
There's 2 things here. First, if customizing display text is not in BB then this is a feature request. Second, if I customize the text in SBC the changes are also visible in BB which I find quite odd, but it's how I managed to get my setup. Is this expected behavior for one display addon to affect another?
With my limited knowledge on LDB's inner workings, I would say no, as that would mean that the display was altering the data object itself, thus effecting other displays...
I tried out ButtonBin to use one bin as a "dropdown" menu for a handful of my less used addons. The problem is I found no way to adjust the text that's shown for each addon unless I edited each of them under StatBlockCore. Am I just missing the option to change the display text for addons in ButtonBin because it seems rather odd having to use another display addon to change it.
I'm pretty sure block-level options have been added recently:
------------------------------------------------------------------------
r50 | dhedbor | 2008-11-09 23:57:01 +0000 (Sun, 09 Nov 2008) | 1 line
Changed paths:
M /trunk/ButtonBin.lua
- Allow block level override for text display even on bars with all text disabled.
------------------------------------------------------------------------
r49 | dhedbor | 2008-11-09 23:42:47 +0000 (Sun, 09 Nov 2008) | 3 lines
Changed paths:
M /trunk/ButtonBin.lua
- Rewrote text updating algorithm so it's no longer broken.
- Added ability to toggle labels, text and values individually (per bin and per block)
- Added configurable label, text, value and unit colors (per bin)
------------------------------------------------------------------------
r48 | dhedbor | 2008-11-09 20:20:09 +0000 (Sun, 09 Nov 2008) | 2 lines
Changed paths:
M /trunk/ButtonBin.lua
- Fixed initial sizing on on-mouseover bins.
- Fixed visibility issues when unlocking bins/buttons for mouse over bins.
------------------------------------------------------------------------
r47 | dhedbor | 2008-11-09 10:56:12 +0000 (Sun, 09 Nov 2008) | 1 line
Changed paths:
M /trunk/ButtonBin.lua
- Added option to set the tooltip scale (global/bin/block level available). Caveat: Only works on tooltips managed by ButtonBin, not custom OnEnter shown once, such as TabletLib
SBC shouldn't be affecting ButtonBin's displaying of blocks. If it is then try disabling SBC to see if it's hobbling ButtonBin.
You can enable or disable text, you can't edit the text per block.
Here's a couple screenshots explaining it, the bin in the top left. Left half of the text for Atlas is from SBC, right side is from BB:
Left side: ButtonBin with Atlas block showing it's Text.
Right side: BB with Atlas block hiding it's text, yet some text is still visible.
Top: SBC with Atlas block showing text as Atlas
Bottom: SBC with Atlas block showing text as AtlasBob and somehow this change shows up in the ButtonBin text display as well.
Sounds like SBC is indeed stomping the LDB plugins' data, which is bad bad bad.
Not really; all it's doing is changing the LDB object's label attribute. It's the same thing a plugin does when it sets its text or icon attributes; all display addons pick up on the changes. The only difference in this case is that instead of the plugin changing its own label, a display is doing it. Since most plugins are designed to be simple, and do not provide a full-fledged GUI through which something like configuring the label would be feasible, I think it's quite reasonable for a display addon to provide the interface for doing this.
Not really; all it's doing is changing the LDB object's label attribute. It's the same thing a plugin does when it sets its text or icon attributes; all display addons pick up on the changes. The only difference in this case is that instead of the plugin changing its own label, a display is doing it. Since most plugins are designed to be simple, and do not provide a full-fledged GUI through which something like configuring the label would be feasible, I think it's quite reasonable for a display addon to provide the interface for doing this.
Perhaps "internal label" for the display would be better? Have the display save a set label to its own config and use it if the label is edited.
Perhaps "internal label" for the display would be better? Have the display save a set label to its own config and use it if the label is edited.
Eh, that adds a layer of complexity that I don't think is really necessary. The LDB specification allows data objects to specify a "label", a "text", and an "icon" for display purposes. It seems pretty silly to say "okay, this data object specifies that its label is X, but we want to show Y here and Z there". I can't really think of too many reasons why you'd need to show a plugin on more than one display, and can't think of any reasons why you'd need to use a different label for the same plugin on each display. Thus, what you're suggesting is just extra bloat for no real purpose.
The whole story isn't quite so easy. Current spec doesn't require it and in fact asks displays to take the data from the name of the broker if it's missing. So there is a chance for odd behavior due to this. I tried to articulate this in the ldb thread, but failed I think :P
I can think of cases where people want specific local labels that differ per display (simply because one display may look good with say a full label whereas another may look good with an abbreviation for example), but as noone seems to have requested it yet it's a little much to implement for it yet. Global labels should do fine for most cases and in most cases any broker will only really show in one display anyway. If the rare exceptional case warrants the extra implementation is kind of in the eye of the display mod author.
Eh, that adds a layer of complexity that I don't think is really necessary. The LDB specification allows data objects to specify a "label", a "text", and an "icon" for display purposes. It seems pretty silly to say "okay, this data object specifies that its label is X, but we want to show Y here and Z there". I can't really think of too many reasons why you'd need to show a plugin on more than one display, and can't think of any reasons why you'd need to use a different label for the same plugin on each display. Thus, what you're suggesting is just extra bloat for no real purpose.
I don't even think it matters. Certainly doesn't to me. I was just trying to argue on the side of common practices. I was under the impression that changing the DO's fields from the display was considered wrong. If I remember correctly, that was brought up when talking about the minimap button with DO's. Displays shouldn't change DO fields seemed to be the consensus at that time.
I have a request. Would it be possible to custom name the bins? I tend to hide the bin icon and I keep forgetting what bin number refers to which bin on my screen. Or perhaps just force show the number when the bins are unlocked?
I'm back... from leveling. In either case, showing the bin ID when unlocked is a very valid request and easy enough to implement. Also I'm about to check in support for the texcoord/iconcoord and iconR/G/B used by for example TomTom crazy waypoint arrow.
I recently made the default layout be a top bar (well three bins actually, left center and right). Added optional "moving of blizzard frames" feature as well as the ability to move datablocks between bins on the individual datablock config page.
Hello, I'm trying to use button bin to create a couple of bins, 3 to be exact, 1 on the top left corner, 1 on the top middle and 1 in the bottom middle, I'm having problems with the one on the top middle and the one in the bottom middle, they keep dissapearing every time I do a reloadui or just join/rejoin, Do you know what might be causing this?
Could it be that WoW is unable to write to your addon file? Can you open your game directory and navigate to WTF/Account/<AccountName>/Saved Variables/ and see if you can open and change ButtonBin.lua manually?
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
There's 2 things here. First, if customizing display text is not in BB then this is a feature request. Second, if I customize the text in SBC the changes are also visible in BB which I find quite odd, but it's how I managed to get my setup. Is this expected behavior for one display addon to affect another?
I'm pretty sure block-level options have been added recently:
SBC shouldn't be affecting ButtonBin's displaying of blocks. If it is then try disabling SBC to see if it's hobbling ButtonBin.
Here's a couple screenshots explaining it, the bin in the top left. Left half of the text for Atlas is from SBC, right side is from BB:
Left side: ButtonBin with Atlas block showing it's Text.
Right side: BB with Atlas block hiding it's text, yet some text is still visible.
Top: SBC with Atlas block showing text as Atlas
Bottom: SBC with Atlas block showing text as AtlasBob and somehow this change shows up in the ButtonBin text display as well.
While I agree it's probably bad, it's what's letting me customize my text for BB. :)
Not really; all it's doing is changing the LDB object's label attribute. It's the same thing a plugin does when it sets its text or icon attributes; all display addons pick up on the changes. The only difference in this case is that instead of the plugin changing its own label, a display is doing it. Since most plugins are designed to be simple, and do not provide a full-fledged GUI through which something like configuring the label would be feasible, I think it's quite reasonable for a display addon to provide the interface for doing this.
Perhaps "internal label" for the display would be better? Have the display save a set label to its own config and use it if the label is edited.
Eh, that adds a layer of complexity that I don't think is really necessary. The LDB specification allows data objects to specify a "label", a "text", and an "icon" for display purposes. It seems pretty silly to say "okay, this data object specifies that its label is X, but we want to show Y here and Z there". I can't really think of too many reasons why you'd need to show a plugin on more than one display, and can't think of any reasons why you'd need to use a different label for the same plugin on each display. Thus, what you're suggesting is just extra bloat for no real purpose.
I can think of cases where people want specific local labels that differ per display (simply because one display may look good with say a full label whereas another may look good with an abbreviation for example), but as noone seems to have requested it yet it's a little much to implement for it yet. Global labels should do fine for most cases and in most cases any broker will only really show in one display anyway. If the rare exceptional case warrants the extra implementation is kind of in the eye of the display mod author.
I don't even think it matters. Certainly doesn't to me. I was just trying to argue on the side of common practices. I was under the impression that changing the DO's fields from the display was considered wrong. If I remember correctly, that was brought up when talking about the minimap button with DO's. Displays shouldn't change DO fields seemed to be the consensus at that time.