Authors CurseForge

I would like to bring attention to a minor issue. Some plugins seem to not be fully implementing their OnLeave handlers, specifically the second argument, motion, that it is passed. That argument evaluates as true if the OnLeave handler was called due to mouse movement, otherwise it means the frame lost focus for some other reason.

When a plugin is being dragged the motion arg will evaluate as false. This should result in any attached drop-down menu or tooltip being removed immediately. Ignoring that second arg results in plugins being dragged and still having their tooltip (or a menu) attached when it shouldn't.

Also, do NOT modify the frame that is passed as the first argument with OnEnter/OnLeave. You have no idea which display will be hosting your plugin and therefore don't know which fields are safe to modify.

dataObj.OnEnter = function(self, motion)
	self.tooltip = GameTooltip
	< snip >
end

dataObj.OnLeave = function(self, motion)
	if self.tooltip then
		self.tooltip:Hide()
		self.tooltip = nil
	end
end

The 'self' in those functions does not end up being dataObj, so stop playing with your 'self'. :)

If the display wants tips hidden while dragging, it should call the onleave when drag starts, and onenter when it ends. And yes, the DO shouldn't be changing that "self" really. Either way, it's something you should address to the specific authors who are doing things wrong, a general forum thread here is not likely to get their attention.

If you use OnTooltipShow then the display manages showing and hiding the tip.

Quote from StormFX

Ah. So is there anyway to hook into the object's OnDragStart or anything so I can my menu?

If you are anchoring anything to a plugin then you would be much better off switching to using OnEnter/OnLeave just so you have an easy way to know when to hide it.

I was thinking more along the lines of (rough outline):

local menuShowing = false

local function OnClick(self, button)
    if button == 'LeftButton' then
        -- Do stuff
    elseif button == 'RightButton' then
        -- Hide tooltip
        -- Show drop-down menu
        menuShowing = true
    end
end

local function OnEnter(self, motion)
    if menuShowing then
        -- Stop timer for hiding the drop-down menu
    else
        -- Show tooltip
    end
end

local function OnLeave(self, motion)
    if menuShowing then
        if motion then
            -- Start timer to hide the drop-down menu
        else
            -- Hide drop-down menu
            menuShowing = false
        end
    else
        -- Hide tooltip
    end
end