One "bug" I'd like to see fixed in Fortress is the use of global settings. It would be nice if changing them didn't require a reload but that is not my main gripe. My main problem is that if I want to change anything specific for one of the plug-ins, it dumps the global settings and reverts to the default (12 pt text, frame and background). I wish it would stick to the global and just change whatever I'm changing manually.
A second request would be the ability to set margins, both vertical and horizontal. Currently I'd like to increase the horizontal margins between blocks and reduce the vertical one, i.e. the blocks are too narrow and too high for my taste :-)
That's great I assumed it couldn't be done as some mods I have seen don't have it. ie Statblocks_Folks seems to be a replacement for GuildFu but I would really miss the ability to click tablet to invite etc..
I was very busy the last time and found no time to improve Fortress, but I'm back.
The first thing on my list is to improve the whole settings system. At the moment there are two setting types: Master and per plugin settings. Master settings affect every plugin until any setting is changed for the plugin itself. I plan to move this master/individual mode to a per setting basis. So you could handle the "Show label" option per plugin, but the color for the borders for all blocks.
Also on the list are some utility features like "Show all hidden blocks" and cascading new blocks so they don't clutter all on the same spot at the first login.
You missed a spot on your last commit - the Enabled toggle in Options calls EnablePlugin / DisablePlugin, but there is no method in the Fortress object by that name. EnableDataObject and DisableDataObject exist in Core.lua, though.
okay, that's the set. the get is still returning true always, which is apparently the same function that's called on load, since enable options default to true on every login.
The get returns 'true' because the enabled options is inherited by the master settings (without any chance to change it). I think 'enabled' should be handled individually for each plugin, I'll rework this part a bit.
Thanks for the report, I always manage to miss something in my tests :(
right, but the end result is every plugin becoming enabled on every login. it doesn't look like you're checking pluginSettings[name].enabled in your frame creation function, unless i'm misreading it.
edit: okay, i see it now, toggling enable forces a disable, but the db gets overridden by the default master inheritance. maybe Enabled shouldn't be inheritable?
also, can you change the slash handler to call InterfaceOptionsFrame_OpenToFrame() instead of AceConfigDialog, since none of the plugin options render in the ACD frame?
and, finally, the per object "Show Label" override logic seems to be broken when master is off
edit: okay, i see it now, toggling enable forces a disable, but the db gets overridden by the default master inheritance. maybe Enabled shouldn't be inheritable?
Aye, I'm changing this at the moment.
also, can you change the slash handler to call InterfaceOptionsFrame_OpenToFrame() instead of AceConfigDialog, since none of the plugin options render in the ACD frame?
That's a good idea, I'll change that.
Edit: Done, hopefully this is fixed now.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
A second request would be the ability to set margins, both vertical and horizontal. Currently I'd like to increase the horizontal margins between blocks and reduce the vertical one, i.e. the blocks are too narrow and too high for my taste :-)
That or the previously mentioned request of showing all hidden blocks attached to the current mouse target.
I too am having a hard time finding blocks that I've hidden. :-P
That will break more than it fixes. So far SBC is looking to be a better fit for me.
It can be done on a per-plugin basis with OnEnter and OnLeave.
(There's nothing like FuBar's explicit "set this option and it'll be handled for you" stuff.)
But it needs FuBar2Broker.
**hangs head in shame**
The first thing on my list is to improve the whole settings system. At the moment there are two setting types: Master and per plugin settings. Master settings affect every plugin until any setting is changed for the plugin itself. I plan to move this master/individual mode to a per setting basis. So you could handle the "Show label" option per plugin, but the color for the borders for all blocks.
Also on the list are some utility features like "Show all hidden blocks" and cascading new blocks so they don't clutter all on the same spot at the first login.
Thanks for the report, I always manage to miss something in my tests :(
edit: okay, i see it now, toggling enable forces a disable, but the db gets overridden by the default master inheritance. maybe Enabled shouldn't be inheritable?
also, can you change the slash handler to call InterfaceOptionsFrame_OpenToFrame() instead of AceConfigDialog, since none of the plugin options render in the ACD frame?
and, finally, the per object "Show Label" override logic seems to be broken when master is off
Aye, I'm changing this at the moment.
That's a good idea, I'll change that.
Edit: Done, hopefully this is fixed now.