Wallet

#1 Nov 4, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
So I've decided to start tackling a currency tracking addon for Broker. Nothing usable as of yet, but I plan to have it display BG marks, Badges, Honor and Arena points on the tooltip and to toggle between them all to display and track.

That said, I am a coding n00b and I am having the darnedest time getting the currency frame to toggle on click. Any ideas?

Rollback Post to Revision RollBack
#2 Nov 4, 2008
_ForgeUser384405
_ForgeUser384405

View User Profile

View Posts

Send Message
- Location:
- Join Date: 11/24/2007
- Posts: 23
- Member Details
broker_currency seems does the same.

Rollback Post to Revision RollBack
#3 Nov 4, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Oh cool, I will check that out. Maybe I don't need to put the effort in :P

Rollback Post to Revision RollBack
#4 Nov 9, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Ok so I worked on it anyways and put it up for approval on CurseForge.

Broker_Wallet is a simple currency display for LDB. You must use an addon such as Fortress, among others, to display.

Mouseover to view summary of currency tab, click to toggle and track a particular currency.

Thanks to the current creators of LDB addons for inspiration and letting me use your code. :)

Current Issues: May not update when you loot badges. Fix untested. Let me know if you see any issues.

Rollback Post to Revision RollBack
#5 Nov 24, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Can you guys take a look at this and tell me a good way to get the tracking to save to save across sessions? I think it's in the first part with I initialize the addon, but my novice coding skills are failing me.

What happens now is you pick a currency to track, log out, and when you log back in, it shows the correct amoutn of what you were tracking, but the icon is the default and the suffix says "Honor." What can I do?

local frame = CreateFrame("frame")
local OnEvent = function(self, event, ...) self[event](self, event, ...) end
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("Broker_Wallet", {
value = "0",
icon = "Interface\\Icons\\Inv_Misc_Coin_02",
suffix = " Honor",
})

local getSuffix = function(i)
return (i == 1 and " Honor") or (i == 2 and " Arena") or (i == 3 and " AV") or (i == 4 and " AB") or (i == 5 and " EotS") or (i == 6 and " SotA") or (i == 7 and " WSG") or (i == 8 and " LWG") or (i == 9 and " SKShards") or (i == 10 and " BoJ") or (i == 11 and " EoH") or (i == 12 and " EoV") or (i == 13 and " JCTokens") or (i == 14 and " Cooking")
end

function dataobj.OnTooltipShow(tooltip)
tooltip:AddLine("Broker_Wallet", 0,1,0, 0,1,0)
tooltip:AddLine(" ")
tooltip:AddDoubleLine("Honor Points:", GetHonorCurrency(), 1,1,1, 1,1,1)
tooltip:AddLine(" ")
tooltip:AddDoubleLine("Arena Points:", GetArenaCurrency(), 1,1,1, 1,1,1)
tooltip:AddLine(" ")
tooltip:AddDoubleLine("Alterac Valley Marks:", GetItemCount("20560"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Arathi Basin Marks:", GetItemCount("20559"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Eye of the Storm Marks:", GetItemCount("29024"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Strand of the Ancients Marks:", GetItemCount("42525"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Warsong Gulch Marks:", GetItemCount("20558"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Wintergrasp Marks:", GetItemCount("43589"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Stone Keeper's Shards:", GetItemCount("43228"), 1,1,1, 1,1,1)
tooltip:AddLine(" ")
tooltip:AddDoubleLine("Badges of Justice:", GetItemCount("29434"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Emblems of Heroism:", GetItemCount("40752"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Emblems of Valor:", GetItemCount("40753"), 1,1,1, 1,1,1)
tooltip:AddLine(" ")
tooltip:AddDoubleLine("Dalaran Jewelcrafter's Token:", GetItemCount("41596"), 1,1,1, 1,1,1)
tooltip:AddDoubleLine("Dalaran Cooking Token:", GetItemCount("43016"), 1,1,1, 1,1,1)
tooltip:AddLine(" ")
tooltip:AddLine("Click to toggle display.")
end

local session

function frame:HONOR_CURRENCY_UPDATE()
if(Broker_Wallet.displ == 1) then
dataobj.value = GetHonorCurrency()
elseif(Broker_Wallet.displ == 2) then
dataobj.value = GetArenaCurrency()
elseif(Broker_Wallet.displ == 3) then
dataobj.value = GetItemCount("20560")
elseif(Broker_Wallet.displ == 4) then
dataobj.value = GetItemCount("20559")
elseif(Broker_Wallet.displ == 5) then
dataobj.value = GetItemCount("29024")
elseif(Broker_Wallet.displ == 6) then
dataobj.value = GetItemCount("42525")
elseif(Broker_Wallet.displ == 7) then
dataobj.value = GetItemCount("20558")
elseif(Broker_Wallet.displ == 8) then
dataobj.value = GetItemCount("43589")
elseif(Broker_Wallet.displ == 9) then
dataobj.value = GetItemCount("43228")
elseif(Broker_Wallet.displ == 10) then
dataobj.value = GetItemCount("29434")
elseif(Broker_Wallet.displ == 11) then
dataobj.value = GetItemCount("40752")
elseif(Broker_Wallet.displ == 12) then
dataobj.value = GetItemCount("40753")
elseif(Broker_Wallet.displ == 13) then
dataobj.value = GetItemCount("41596")
elseif(Broker_Wallet.displ == 14) then
dataobj.value = GetItemCount("43016")
end
dataobj.text = dataobj.value.." "..dataobj.suffix
end

function frame:PLAYER_ENTERING_WORLD()
if(not Broker_Wallet) then Broker_Wallet = {} end
session = select(1)
self:HONOR_CURRENCY_UPDATE()
end

function frame:BAG_UPDATE()
self:HONOR_CURRENCY_UPDATE()
end

frame:SetScript("OnEvent", OnEvent)
frame:RegisterEvent"HONOR_CURRENCY_UPDATE"
frame:RegisterEvent"PLAYER_ENTERING_WORLD"
frame:RegisterEvent"BAG_UPDATE"

function dataobj.OnClick(self, button)
Broker_Wallet.displ = (Broker_Wallet.displ == 14 and 1) or (Broker_Wallet.displ and Broker_Wallet.displ+1) or 1
dataobj.suffix = getSuffix(Broker_Wallet.displ)
if(Broker_Wallet.displ == 1) then
dataobj.icon = "Interface\\Icons\\Inv_Misc_Coin_02"
elseif(Broker_Wallet.displ == 2) then
dataobj.icon = [[Interface\PVPFrame\PVP-ArenaPoints-Icon]]
elseif(Broker_Wallet.displ == 3) then
dataobj.icon = "Interface\\Icons\\Inv_Jewelry_Necklace_21"
elseif(Broker_Wallet.displ == 4) then
dataobj.icon = "Interface\\Icons\\Inv_Jewelry_Amulet_07"
elseif(Broker_Wallet.displ == 5) then
dataobj.icon = "Interface\\Icons\\Spell_Nature_EyeOfTheStorm"
elseif(Broker_Wallet.displ == 6) then
dataobj.icon = "Interface\\Icons\\Inv_Jewelry_Amulet_01"
elseif(Broker_Wallet.displ == 7) then
dataobj.icon = "Interface\\Icons\\Inv_Misc_Rune_07"
elseif(Broker_Wallet.displ == 8) then
dataobj.icon = "Interface\\Icons\\Inv_Jewelry_Ring_66"
elseif(Broker_Wallet.displ == 9) then
dataobj.icon = "Interface\\Icons\\INV_Misc_Platnumdisks"
elseif(Broker_Wallet.displ == 10) then
dataobj.icon = "Interface\\Icons\\Spell_Holy_ChampionsBond"
elseif(Broker_Wallet.displ == 11) then
dataobj.icon = "Interface\\Icons\\Spell_Holy_ProclaimChampion"
elseif(Broker_Wallet.displ == 12) then
dataobj.icon = "Interface\\Icons\\Spell_Holy_ProclaimChampion_02"
elseif(Broker_Wallet.displ == 13) then
dataobj.icon = "Interface\\Icons\\INV_Misc_Gem_Variety_01"
elseif(Broker_Wallet.displ == 14) then
dataobj.icon = "Interface\\Icons\\INV_Misc_Ribbon_01"
end
frame:HONOR_CURRENCY_UPDATE()
end

Rollback Post to Revision RollBack

#6 Nov 25, 2008

Torhal

Admin

CurseForge

Location: Meridianville
Join Date: 2/13/2008
Posts: 2,812
Member Details

I don't see that you're declaring SavedVariables anywhere.

I did see that your code could be greatly simplified, as:

local values = {
        GetHonorCurrency(),
        GetArenaCurrency(),
        GetItemCount("20560"),
        GetItemCount("20559"),
        GetItemCount("29024"),
        GetItemCount("42525"),
        GetItemCount("20558"),
        GetItemCount("43589"),
        GetItemCount("43228"),
        GetItemCount("29434"),
        GetItemCount("40752"),
        GetItemCount("40753"),
        GetItemCount("41596"),
        GetItemCount("43016")
}


function frame:HONOR_CURRENCY_UPDATE()
         dataobj.value = values[Broker_Wallet.displ]
         dataobj.text = dataobj.value.." "..dataobj.suffix
end

Also:

local icons = {
          "Interface\\Icons\\Inv_Misc_Coin_02",
          "Interface\\PVPFrame\\PVP-ArenaPoints-Icon",
          "Interface\\Icons\\Inv_Jewelry_Necklace_21",
          "Interface\\Icons\\Inv_Jewelry_Amulet_07",
          "Interface\\Icons\\Spell_Nature_EyeOfTheStorm",
          "Interface\\Icons\\Inv_Jewelry_Amulet_01",
          "Interface\\Icons\\Inv_Misc_Rune_07",
          "Interface\\Icons\\Inv_Jewelry_Ring_66",
          "Interface\\Icons\\INV_Misc_Platnumdisks",
          "Interface\\Icons\\Spell_Holy_ChampionsBond",
          "Interface\\Icons\\Spell_Holy_ProclaimChampion",
          "Interface\\Icons\\Spell_Holy_ProclaimChampion_02",
          "Interface\\Icons\\INV_Misc_Gem_Variety_01",
          "Interface\\Icons\\INV_Misc_Ribbon_01"
}


function dataobj.OnClick(self, button)
          Broker_Wallet.displ = (Broker_Wallet.displ == 14 and 1) or (Broker_Wallet.displ and Broker_Wallet.displ+1) or 1
          dataobj.suffix = getSuffix(Broker_Wallet.displ)
          dataobj.icon = icons[Broker_Wallet.displ]

          frame:HONOR_CURRENCY_UPDATE()
end

#7 Nov 25, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Thank you for the code cleanup, Torhal. That looks a heck of a lot better. In reference to the saved variables, I have it referenced in the .toc file, but I must have lost it from an older version somewhere along the line. Now I just need to figure out how to get it to work.

Rollback Post to Revision RollBack
#8 Nov 25, 2008
Torhal
Torhal

View User Profile

View Posts

Send Message
Admin
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,812
- Member Details
All you need to do is create a table named exactly the same as the TOC's SavedVariables:

In the TOC:

## SavedVariables: AddonNameDB

In the addon itself:

AddonNameDB = { var1, var2, etc } local function SomeFunc() if (whatever) then AddonNameDB.var1 = some_val end end

Note that this doesn't set default values and is a rather verbose usage, but it will save your values, once set, upon logout or /reloadui.
Rollback Post to Revision RollBack
#9 Nov 26, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
local dataobj = ldb:NewDataObject("Broker_Wallet", { value = "0", icon = "Interface\\Icons\\Inv_Misc_Coin_02", suffix = " Honor", })
This seems to be my problem. The value is saving to the variables file just fine, but how do I use that value to set the correct suffix and icon when the addon loads in?
Rollback Post to Revision RollBack
#10 Nov 26, 2008
Torhal
Torhal

View User Profile

View Posts

Send Message
Admin
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,812
- Member Details
function frame:ADDON_LOADED(event, addon) if addon ~= "Broker_Wallet" then return end dataobj.value = savedvariable.value dataobj.icon = savedvariable.icon dataobj.suffix = savedvariable.suffix end
Also, with getSuffix(); why not just make a table and do:

local function getSuffix(i) return sufword[i] end
...or just get rid of that function altogether and directly use the table. A function that only returns the value in a table is less efficient because of the overhead of the function call.

EDIT: Gah. I shouldn't read forums when I wake up. There was an error in the original post. :)
Last edited by Torhal: Nov 26, 2008

Rollback Post to Revision RollBack
#11 Nov 26, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Alright, the little part of my brain that understands coding is going nuts now. And hurts. ;)

I got the suffix function out of the way and I am using a table and it works beautifully. Thank you!

My problems are still stemming from my lack of understanding saved variables. This is what I see in the saved variables file:

Broker_Wallet = { ["displ"] = 1 --or some other value that is saved }
Now, that display value is saving correctly and the addon is calling it correctly, but I am not entirely sure how or why it is doing that, but I digress.

In my OnClick function, i use Broker_Wallet.displ value to determine the icon, value, and suffix. Is there a way to make dataobj.icon and dataobj.suffix to fire when the addon is loading in for the first time? Do I really need to save the icon and suffix values to savedvariables?
Rollback Post to Revision RollBack
#12 Nov 26, 2008
Torhal
Torhal

View User Profile

View Posts

Send Message
Admin
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,812
- Member Details
In the Broker_Wallet:ADDON_LOADED() function, just do:

function Broker_Wallet:ADDON_LOADED(event, addon) if addon ~= "Broker_Wallet" then return end self.displ = SavedVariables.displ dataobj.suffix = sufword[self.displ] dataobj.icon = icons[self.displ] end
...replacing SavedVariables with whatever name you assigned to them in the TOC.
Rollback Post to Revision RollBack
#13 Nov 26, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Cool! I will try it when I get home from work. Many thanks.

Rollback Post to Revision RollBack
#14 Nov 27, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
I am getting this error from Bugsack with that string placed as you gave it to me:

[2008/11/27 11:34:28-1851-x1]: Broker_Wallet-1.3\Broker_Wallet.lua:126: attempt to index global 'Broker_Wallet' (a nil value)

Here is the code:

function Broker_Wallet:ADDON_LOADED(event, addon) if addon ~= "Broker_Wallet" then return end self.displ = Broker_Wallet.displ dataobj.suffix = sufword[self.displ] dataobj.icon = icons[self.displ] end
Rollback Post to Revision RollBack
#15 Nov 27, 2008
Torhal
Torhal

View User Profile

View Posts

Send Message
Admin
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,812
- Member Details
Are you giving your savedvariables the same name as your addon?

function Broker_Wallet:ADDON_LOADED(event, addon) if addon ~= "Broker_Wallet" then return end self.displ = SavedVariableName.displ -- This should NOT be Broker_Wallet dataobj.suffix = sufword[self.displ] dataobj.icon = icons[self.displ] end
The "self" in Broker_Wallet:ADDON_LOADED() is referring to Broker_Wallet. Therefore, "self.displ = Broker_Wallet.displ" is the same as "self.displ = self.displ" and since Broker_Wallet.displ hasn't been defined at that point you get an error.
Rollback Post to Revision RollBack
#16 Nov 27, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
Gotcha, that's the problem then. So I should name the saved variables like Broker_WalletDB?

Rollback Post to Revision RollBack
#17 Nov 27, 2008
Torhal
Torhal

View User Profile

View Posts

Send Message
Admin
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,812
- Member Details
Indeed.

Rollback Post to Revision RollBack

#18 Nov 27, 2008

_ForgeUser11089718

Join Date: 10/4/2013
Posts: 4,945
Member Details

Ok, still getting errors. I don't know what I am doing wrong. I think its now not saving the value as it did before as it now shows nil. But the errors are really throwing me off. Here is Broker-Wallet.lua:

function ADDON_LOADED(event, addon)
        if addon ~= "Broker_Wallet" then return end
        
        self.displ = Broker_WalletDB.displ
        dataobj.suffix = suffix[self.displ]
        dataobj.icon = icons[self.displ]
end

local frame = CreateFrame("frame")
local OnEvent = function(self, event, ...) self[event](self, event, ...) end
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("Broker_Wallet")

frame:SetScript("OnEvent", OnEvent)
frame:RegisterEvent"HONOR_CURRENCY_UPDATE"
frame:RegisterEvent"PLAYER_ENTERING_WORLD"
frame:RegisterEvent"BAG_UPDATE"

function dataobj.OnTooltipShow(tooltip)
    tooltip:AddLine("Broker_Wallet", 0,1,0, 0,1,0)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Honor Points:", GetHonorCurrency(), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Arena Points:", GetArenaCurrency(), 1,1,1, 1,1,1)    
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Alterac Valley Marks:", GetItemCount("20560"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Arathi Basin Marks:", GetItemCount("20559"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Eye of the Storm Marks:", GetItemCount("29024"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Strand of the Ancients Marks:", GetItemCount("42525"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Warsong Gulch Marks:", GetItemCount("20558"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Wintergrasp Marks:", GetItemCount("43589"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Stone Keeper's Shards:", GetItemCount("43228"), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Badges of Justice:", GetItemCount("29434"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Emblems of Heroism:", GetItemCount("40752"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Emblems of Valor:", GetItemCount("40753"), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Dalaran Jewelcrafter's Token:", GetItemCount("41596"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Dalaran Cooking Token:", GetItemCount("43016"), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddLine("Click to toggle display.")
end

local values = {
        GetHonorCurrency(),
        GetArenaCurrency(),
        GetItemCount("20560"),
        GetItemCount("20559"),
        GetItemCount("29024"),
        GetItemCount("42525"),
        GetItemCount("20558"),
        GetItemCount("43589"),
        GetItemCount("43228"),
        GetItemCount("29434"),
        GetItemCount("40752"),
        GetItemCount("40753"),
        GetItemCount("41596"),
        GetItemCount("43016")
}

local icons = {
          "Interface\\Icons\\Inv_Misc_Coin_02",
          "Interface\\PVPFrame\\PVP-ArenaPoints-Icon",
          "Interface\\Icons\\Inv_Jewelry_Necklace_21",
          "Interface\\Icons\\Inv_Jewelry_Amulet_07",
          "Interface\\Icons\\Spell_Nature_EyeOfTheStorm",
          "Interface\\Icons\\Inv_Jewelry_Amulet_01",
          "Interface\\Icons\\Inv_Misc_Rune_07",
          "Interface\\Icons\\Inv_Jewelry_Ring_66",
          "Interface\\Icons\\INV_Misc_Platnumdisks",
          "Interface\\Icons\\Spell_Holy_ChampionsBond",
          "Interface\\Icons\\Spell_Holy_ProclaimChampion",
          "Interface\\Icons\\Spell_Holy_ProclaimChampion_02",
          "Interface\\Icons\\INV_Misc_Gem_Variety_01",
          "Interface\\Icons\\INV_Misc_Ribbon_01"
}

local suffix = {
        " Honor",
        " Arena",
        " AV",
        " AB",
        " EotS",
        " SotA",
        " WSG",
        " LWG",
        " SKShards",
        " BoJ",
        " EoH",
        " EoV",
        " JCTokens",
        " Cooking"
}

function frame:HONOR_CURRENCY_UPDATE()
         dataobj.value = values[Broker_Wallet.displ]
         dataobj.text = dataobj.value.." "..dataobj.suffix
end

function frame:PLAYER_ENTERING_WORLD()
    if(not Broker_Wallet) then Broker_Wallet = {} end
    self:HONOR_CURRENCY_UPDATE()
end

function frame:BAG_UPDATE()
    self:HONOR_CURRENCY_UPDATE()
end

function dataobj.OnClick(self, button)
          Broker_Wallet.displ = (Broker_Wallet.displ == 14 and 1) or (Broker_Wallet.displ and Broker_Wallet.displ+1) or 1
          dataobj.suffix = suffix[Broker_Wallet.displ]
          dataobj.icon = icons[Broker_Wallet.displ]
          frame:HONOR_CURRENCY_UPDATE()
end

Here is Broker_Wallet.toc:

## Interface: 30000
## Title: Broker_Wallet
## Author: Krevlorn
## Version: 1.3
## X-eMail: krevlorn@gmail.com
## Notes: Simple Currency display for LDB
## SavedVariables: Broker_WalletDB

LibStub.lua
CallbackHandler-1.0.lua
LibDataBroker-1.1.lua

Broker_Wallet.lua

Here is the saved variables file:

Broker_WalletDB = nil

and here are my errors from Bugsack:

[2008/11/27 17:06:35-1902-x1]: Broker_Wallet-1.3\Broker_Wallet.lua:101: attempt to concatenate field 'suffix' (a nil value)
Broker_Wallet-1.3\Broker_Wallet.lua:106: in function `?'
Broker_Wallet-1.3\Broker_Wallet.lua:14: in function <Interface\AddOns\Broker_Wallet\Broker_Wallet.lua:14>

[2008/11/27 17:06:35-1902-x10]: Broker_Wallet-1.3\Broker_Wallet.lua:101: attempt to concatenate field 'suffix' (a nil value)
Broker_Wallet-1.3\Broker_Wallet.lua:110: in function `?'
Broker_Wallet-1.3\Broker_Wallet.lua:14: in function <Interface\AddOns\Broker_Wallet\Broker_Wallet.lua:14>

#19 Nov 27, 2008

Torhal

Admin

CurseForge

Location: Meridianville
Join Date: 2/13/2008
Posts: 2,812
Member Details

You're not declaring things in proper order, so they don't exist when you call them. Also, ADDON_LOADED() wasn't properly named and was also not registered as an event.

I went ahead and re-worked your code and sectioned it in a sane manner. It now saves between sessions, and loads the value/text as well.

Broker_Wallet.lua:

-------------------------------------------------------------------------------
-- Addon namespace
local Broker_Wallet = CreateFrame("Frame")
_G["Broker_Wallet"] = Broker_Wallet

local LDB = LibStub:GetLibrary("LibDataBroker-1.1")
dataobj = LDB:NewDataObject("Broker_Wallet",
                {
                    value = "1",
                    icon = "Interface\\Icons\\Inv_Misc_Coin_02",
                    suffix = " Honor",
                })

-------------------------------------------------------------------------------
-- Local variables
local defaults = {
    displ = 1
}


local values = {
        GetHonorCurrency(),
        GetArenaCurrency(),
        GetItemCount("20560"),
        GetItemCount("20559"),
        GetItemCount("29024"),
        GetItemCount("42525"),
        GetItemCount("20558"),
        GetItemCount("43589"),
        GetItemCount("43228"),
        GetItemCount("29434"),
        GetItemCount("40752"),
        GetItemCount("40753"),
        GetItemCount("41596"),
        GetItemCount("43016")
}


local icons = {
    "Interface\\Icons\\Inv_Misc_Coin_02",
    "Interface\\PVPFrame\\PVP-ArenaPoints-Icon",
    "Interface\\Icons\\Inv_Jewelry_Necklace_21",
    "Interface\\Icons\\Inv_Jewelry_Amulet_07",
    "Interface\\Icons\\Spell_Nature_EyeOfTheStorm",
    "Interface\\Icons\\Inv_Jewelry_Amulet_01",
    "Interface\\Icons\\Inv_Misc_Rune_07",
    "Interface\\Icons\\Inv_Jewelry_Ring_66",
    "Interface\\Icons\\INV_Misc_Platnumdisks",
    "Interface\\Icons\\Spell_Holy_ChampionsBond",
    "Interface\\Icons\\Spell_Holy_ProclaimChampion",
    "Interface\\Icons\\Spell_Holy_ProclaimChampion_02",
    "Interface\\Icons\\INV_Misc_Gem_Variety_01",
    "Interface\\Icons\\INV_Misc_Ribbon_01"
}


local suffix = {
        " Honor",
        " Arena",
        " AV",
        " AB",
        " EotS",
        " SotA",
        " WSG",
        " LWG",
        " SKShards",
        " BoJ",
        " EoH",
        " EoV",
        " JCTokens",
        " Cooking"
}


local DISPL_MAX = 14


-------------------------------------------------------------------------------
-- Event handlers
Broker_Wallet:SetScript("OnEvent",
    function(self, event, ...)
        if self[event] then
            return self[event](self, event, ...)
        end
    end
)
Broker_Wallet:RegisterEvent("ADDON_LOADED")
Broker_Wallet:RegisterEvent("BAG_UPDATE")
Broker_Wallet:RegisterEvent("HONOR_CURRENCY_UPDATE")
Broker_Wallet:RegisterEvent("PLAYER_ENTERING_WORLD")


local function Update()
    dataobj.value = values[Broker_WalletDB.displ]
    dataobj.text = dataobj.value.." "..dataobj.suffix
end


function Broker_Wallet:ADDON_LOADED(event, addon)
        if addon ~= "Broker_Wallet" then return end

    Broker_WalletDB = Broker_WalletDB or defaults
    dataobj.suffix = suffix[Broker_WalletDB.displ]
        dataobj.icon = icons[Broker_WalletDB.displ]
    Update()
    self:UnregisterEvent("ADDON_LOADED")
end


function Broker_Wallet:HONOR_CURRENCY_UPDATE()
    Update()
end


function Broker_Wallet:PLAYER_ENTERING_WORLD()
    Update()
end


function Broker_Wallet:BAG_UPDATE()
    Update()
end


-------------------------------------------------------------------------------
-- LDB functions
function dataobj.OnTooltipShow(tooltip)
    tooltip:AddLine("Broker_Wallet", 0,1,0, 0,1,0)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Honor Points:", GetHonorCurrency(), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Arena Points:", GetArenaCurrency(), 1,1,1, 1,1,1)    
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Alterac Valley Marks:", GetItemCount("20560"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Arathi Basin Marks:", GetItemCount("20559"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Eye of the Storm Marks:", GetItemCount("29024"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Strand of the Ancients Marks:", GetItemCount("42525"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Warsong Gulch Marks:", GetItemCount("20558"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Wintergrasp Marks:", GetItemCount("43589"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Stone Keeper's Shards:", GetItemCount("43228"), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Badges of Justice:", GetItemCount("29434"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Emblems of Heroism:", GetItemCount("40752"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Emblems of Valor:", GetItemCount("40753"), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddDoubleLine("Dalaran Jewelcrafter's Token:", GetItemCount("41596"), 1,1,1, 1,1,1)
    tooltip:AddDoubleLine("Dalaran Cooking Token:", GetItemCount("43016"), 1,1,1, 1,1,1)
    tooltip:AddLine(" ")
    tooltip:AddLine("Click to toggle display.")
end


function dataobj.OnClick(self, button)
    local displ = Broker_WalletDB.displ

    Broker_WalletDB.displ = (displ == DISPL_MAX and 1) or (displ and displ + 1) or 1
    dataobj.suffix = suffix[Broker_WalletDB.displ]
    dataobj.icon = icons[Broker_WalletDB.displ]
    Update()
end

I also added support for AddonLoader in the TOC.

Broker_Wallet.toc

## Interface: 30000
## Title: Broker_Wallet
## Author: Krevlorn
## Version: 1.3
## X-eMail: krevlorn@gmail.com
## Notes: Simple Currency display for LDB
## SavedVariables: Broker_WalletDB

## LoadManagers: AddonLoader
## X-LoadOn-Always: Delayed

LibStub.lua
CallbackHandler-1.0.lua
LibDataBroker-1.1.lua

Broker_Wallet.lua

#20 Nov 27, 2008
_ForgeUser11089718
_ForgeUser11089718

View User Profile

View Posts

Send Message
- Join Date: 10/4/2013
- Posts: 4,945
- Member Details
I am in your debt Torhal. Thank you. As I said before, my coding skills are horrible. I think I understand what you did and why you did it. I will be putting you as co-author on the addon when I upload it. :)

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Previous Thread

Next Thread