Authors CurseForge

Quote from crowem00

could i use "PLAYER_AURAS_CHANGED" event
http://www.wowwiki.com/Events/Buff

11/8/2008 This was removed with 3.02. Use UNIT_AURA instead.

After looking through some event's, that seem's like it might be the correct one.

Test it, add it to your AddOn, make sure you have the coding correct, and cause the event to fire, if whatever you want to happen, occur's then it's the right event.

It says that event was removed two years ago, so probably not. :P The character stats frame seems to use these events (among others):
"COMBAT_RATING_UPDATE"
"PLAYER_EQUIPMENT_CHANGED"
"UNIT_STATS" (arg1 == "player")

Oh, didn't notice them lol.

Seem's "UNIT_STATS" would be what he is looking for since agility effect's crit chance, and possibly call PLAYER_EQUIPMENT_CHANGED beforehand.

But with "UNIT_STATS" if an item is equipped with crit chance as a stat, UNIT_STATS" won't recognize it, since it is for main stat's -- Stamina, Agility, etc..

i cant seem to get the event to work it causes and interface conflict



local function eventHandler(self, event, ...)
local critChance = GetCritChance()
local critChance = format("%.2f", critChance)
end

now from my label my chritChance Does not there

local myframe = CreateFrame("Frame", nil, UIParent)
myframe:SetWidth(150)
myframe:SetHeight(50)
myframe:RegisterEvent("UNIT_STATS")
myframe:SetScript("OnEvent", eventHandler)
myframe:Show()

crtm:SetPoint("CENTER", myframe, "CENTER", 30, 0)
crtm:SetText(critChance)
crtm:SetFont("Fonts\\FRIZQT__.TTF", 30)

You are confusing me with your code...

local function eventHandler(self, event, ...)
print("Hello World! Hello " .. event)
end

I don't use LUA for creating frame's so my little knowledge is much less here.

But why are you localizing the function?

This was given to me for help also by Phanx:

--
-- Create the frame
--

local f = CreateFrame("Frame", "OutsideFrame", UIParent)
f:SetMovable(true)
f:EnableMouse(true)
f:SetSize(200, 95)
f:SetPoint("CENTER", -2, 57)

--
-- Set the frame backdrop
--

f:SetBackdrop({
bgFile = [[Interface\DialogFrame\UI-DialogBox-Background]],
edgeFile = [[Interface\DialogFrame\UI-DialogBox-Border]],
tile = true,
tileSize = 32,
edgeSize = 32,
insets = { left = 11, right = 12, top = 12, bottom = 11 },
})
f:SetBackdropColor(0, 0.4, 0.8)
f:SetBackdropBorderColor(0, 0, 0)

--
-- Set the frame's drag scripts
--

f:SetScript("OnDragStart", function(self)
self:StartMoving()
end)

f:SetScript("OnDragStop", function(self)
self:StopMovingOrSizing()
end)

So to add a function to this frame, I'm assuming you would just do:

f:SetScript("OnEvent", function(self)
self:functionName(args)
end)

And just do:

function functionName(args)
-- What you want it to do
end

I think...

You might want to wait for a more educated answer before relying on my answer.

i am trying to make it so i can use the variables that are inside the function else where

Make them global variables.

how do i just do that just put global on the funciton and on the verables

this is what i did
if it is wrong let me know because the text does not show up
local critChance
function eventHandler(self, event, ...)
critChance = GetCritChance()
critChance = format("%.2f", critChance)
end
if i take critChane out of the function i see numbers

local myframe = CreateFrame("Frame", nil, UIParent)
myframe:SetWidth(150)
myframe:SetHeight(50)
myframe:RegisterEvent("UNIT_STATS")
myframe:SetScript("OnEvent", eventHandler)
myframe:Show()
myframe:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
myframe:SetMovable(true)
myframe:EnableMouse(true)
myframe:SetScript("OnMouseDown", function(self, button)
if button == "LeftButton" and not self.isMoving then
self:StartMoving();
self.isMoving = true;
end
end)
myframe:SetScript("OnMouseUp", function(self, button)
if button == "LeftButton" and self.isMoving then
self:StopMovingOrSizing();
self.isMoving = false;
end
end)
myframe:SetBackdrop(GameTooltip:GetBackdrop())

local crtlbl = myframe:CreateFontString(nil, "ARTWORK", "GameFontNormal")
crtlbl:SetPoint("CENTER", myframe, "CENTER", -30, 0)
crtlbl:SetText("crit%: ")
crtlbl:SetFont("Fonts\\FRIZQT__.TTF", 30)


local crtm = myframe:CreateFontString(nil, "ARTWORK", "GameFontNormal")
crtm:SetPoint("CENTER", myframe, "CENTER", 30, 0)
crtm:SetText(critChance)

Quote from myrroddin

No, put local variableName at the top of the file. You want it local to your addon, but global to the whole addon.

And was my example correct?

Well, you're still expecting it to happen automatically. The text will only change when you call SetText. The button isn't aware of that a variable was used to set its text. The following are exactly identical:

local a = 1
btn:SetText(a)

btn:SetText(1)

You're just assigning a new value to the variables, but that changes nothing. You need to SetText when you want the text to update.

Quote from wwwDot

Oh, didn't notice them lol.

Seem's "UNIT_STATS" would be what he is looking for since agility effect's crit chance, and possibly call PLAYER_EQUIPMENT_CHANGED beforehand.

But with "UNIT_STATS" if an item is equipped with crit chance as a stat, UNIT_STATS" won't recognize it, since it is for main stat's -- Stamina, Agility, etc..

Yes, you would use them all. COMBAT_RATING_UPDATE would fire for crit rating.

local critChance
function eventHandler(self, event, ...)
critChance = GetCritChance()
critChance = format("%.2f", critChance)
end

Define critChance in you local variable

local critChance = GetCritChance()

And you are just changing critChance with:

critChance = GetCritChance()
critChance = format("%.2f", critChance)

(I think. I don't really know about the format function, but it might not)

And this might be wrong:

myframe:SetScript("OnEvent", eventHandler)
myframe:Show()

Maybe try this:

myframe:SetScript("OnEvent", eventHandler(self, event)
myframe:Show()
end)

But like i said, i basically know nothing about frame's with lua.

Quote from wwwDot

Maybe try this:

myframe:SetScript("OnEvent", eventHandler(self, event)
myframe:Show()
end)

The first option you posted is correct, this one is wrong. Functions are first-order types, you can just pass then as variables. The moment you add parenthesis, it is assumed to be a function call no longer an access to the variable. Check the lua reference manual to get a more detailed explanation on this.

Quote from Elsia

The first option you posted is correct, this one is wrong. Functions are first-order types, you can just pass then as variables. The moment you add parenthesis, it is assumed to be a function call no longer an access to the variable. Check the lua reference manual to get a more detailed explanation on this.

I'm going to have to do this sometime soon, i want to totally cut xml from my AddOn's, even though it's KINDA easy to use.

i am wondring i have something wrong with my onevent
nothing shows up when it loads or changes stats
http://paste.wowace.com/3053/
will change it when i come up with something

local function eventHandler(self, event, ...)
local critChance = GetCritChance()
local critChance = format("%.2f", critChance)
crtm:SetText(critChance)
end

As i stated before, don't use local function, it's not needed.

Also, i don't know about frame's in lua, but in xml you need to tell the frame to have a text, before you can set the text to something.

So you would just set the text to "" and it would work great. You might need to do something like this in lua.

Where are you telling it to register the event?