Authors CurseForge

			<Color r="2" g="0.4" b="0.1" />
			<BorderColor r="1.5" g="0.2" b="0.4" />

2 and 1.5 are not valid values. Values must be in the range 0–1 (inclusive). I think WoW does error-correct and treat the 2 as a 1, but it's a simple mistake you can fix.

local hasSecondaryHandEnchant = GetWeaponEnchantInfo()

Programming doesn't work like that. Functions return specific values in a fixed order. Functions also have no awareness of what variables their returned values are being assigned to. You cannot magically get different values or in a different order by assigning them to variables with different names.

You also don't need to two functions to show/hide multiple frames.

Checking for enchants in OnLoad won't work because that information isn't available to the game client yet at that point. Register for PLAYER_ENTERING_WORLD and check there.

Your whole Lua file should look like this:

function MainWeapNote_OnLoad(self)
	self:RegisterEvent("PLAYER_ENTERING_WORLD")
	self:RegisterEvent("UNIT_INVENTORY_CHANGED")
end

function MainWeapNote_OnEvent(self, event, unit)
	if event == "UNIT_INVENTORY_CHANGED" and arg1 ~= "player" then return end

	local hasMainHandEnchant, _, _, hasSecondaryHandEnchant = GetWeaponEnchantInfo()

	local mainHandLink = GetInventoryItemLink("player", GetInventorySlotInfo("MainHandSlot"))
	local secondaryHandLink = GetInventoryItemLink("player", GetInventorySlotInfo("SecondaryHandSlot"))
	local hasFishingPole = mainHandLink and select(7, GetItemInfo(mainHandLink)) == "Fishing Poles"

	if ( mainHandLink and not hasFishingPole and not hasMainHandEnchant ) then
		MainWeapNote:Show()
	else
		MainWeapNote:Hide()
	end

	if ( secondaryHandLink and not hasSecondaryHandEnchant ) then
		SecondaryWeapNote:Show()
	else
		SecondaryWeapNote:Hide()
	end
end

And then you should remove the OnLoad and OnEvent handlers for the SecondaryWeapNote frame in your XML file.

Finally, if you're getting errors, post the errors. Just saying "it doesn't work and there are some errors" is pointless.

local secondaryHandLink = GetInventoryItemLink("player", GetInventorySlotInfo("MainHandSlot"))

Need's to be SecondaryHandSlot

Also, i have it do that stuff on load, so it will check, one it loads. Because before, it would always pop up when you first logged into the game, even if you had your poison's applied, that way fixed it.

Well, i just hit a road block. I was editing 1 more thing in my .xml's that i wanted to test (Everything has been working perfectly) But that edit didn't work, and it was only a cosmetic edit, so i put the .xml's back to the way they were. Now, neither of the notification's are firing. I'm also not receiving any error's upon load or event firing.

Here are my files:
MainHand.lua
MainHand.xml
RogueNote.toc
SecondHand.lua
SecondHand.xml

Quote from wwwDot

Also, i have it do that stuff on load, so it will check, one it loads. Because before, it would always pop up when you first logged into the game, even if you had your poison's applied, that way fixed it.

That's why I suggested listening for PLAYER_ENTERING_WORLD. Information about your temporary enchants is not available in OnLoad during initial login. It is available in OnLoad if you're just reloading the UI without logging out, but most users will consider an addon that doesn't work without a UI reload to be broken.

For a more detailed explanation of the loading process, see:
http://www.wowpedia.org/Events_that_fire_during_the_loading_process#Saved_variables_loading

In short, here's a list of events that fire on login, in sequence, along with whether or not information about your temporary enchants is available when that event fires:

1. OnLoad - NO
2. ADDON_LOADED - NO
3. SPELLS_CHANGED - YES
4. PLAYER_LOGIN - YES
5. PLAYER_ENTERING_WORLD - YES
6. PLAYER_ALIVE - YES
7. UNIT_INVENTORY_CHANGED - YES

Here's the same list for a UI reload:

1. OnLoad - YES
2. ADDON_LOADED - YES
3. PLAYER_LOGIN - YES
4. PLAYER_ENTERING_WORLD - YES

Note that information is always available after a reload, and that some events that fire after logging in do not fire after a reload.

As you can see, PLAYER_ENTERING_WORLD always fires, and the information you want is always available when it does fire. You could use PLAYER_LOGIN instead, but P_E_W will also update your frame when you pass through a loading screen (eg. hearthing, entering/leaving an instance).

Oh, ok, i see. But my problem is still with them being broke O.o, there is NO reason why it should be, but it is.

This works:

local m = CreateFrame("Frame", "MainWeapNote", UIParent)
m:SetPoint("BOTTOM", UIParent, "CENTER", 0, 10)
m:SetSize(360, 35)
m:SetBackdrop({
	bgFile = [[Interface\Tooltips\UI-Tooltip-Background]], tile = true, tileSize = 16,
	edgeFile = [[Interface\Tooltips\UI-Tooltip-Border]], edgeSize = 16,
	insets = { left = 5, right = 4, top = 5, bottom = 4 },
})
m:SetBackdropColor(0, 0, 0)
m:SetBackdropBorderColor(0.2, 1, 0.2)
m:SetMovable(true)
m:EnableMouse(true)
m:RegisterForDrag("LeftButton")
m:SetScript("OnDragStart", m.StartMoving)
m:SetScript("OnDragStop", m.StopMovingOrSizing)

m.text = m:CreateFontString(nil, "OVERLAY", "GameFontNormal")
m.text:SetText("No poison on main hand weapon!")
m.text:SetPoint("LEFT", m, 10, 0)
m.text:SetPoint("RIGHT", m, -10, 0)
m.text:SetJustifyH("CENTER")


local o = CreateFrame("Frame", "OffWeapNote", UIParent)
o:SetPoint("BOTTOM", UIParent, "CENTER", 0, 10)
o:SetSize(360, 35)
o:SetBackdrop({
	bgFile = [[Interface\Tooltips\UI-Tooltip-Background]], tile = true, tileSize = 16,
	edgeFile = [[Interface\Tooltips\UI-Tooltip-Border]], edgeSize = 16,
	insets = { left = 5, right = 4, top = 5, bottom = 4 },
})
o:SetBackdropColor(0, 0, 0)
o:SetBackdropBorderColor(0.2, 1, 0.2)
o:SetMovable(true)
o:EnableMouse(true)
o:RegisterForDrag("LeftButton")
o:SetScript("OnDragStart", o.StartMoving)
o:SetScript("OnDragStop", o.StopMovingOrSizing)

o.text = o:CreateFontString(nil, "OVERLAY", "GameFontNormal")
o.text:SetPoint("LEFT", o, 10, 0)
o.text:SetPoint("RIGHT", o, -10, 0)
o.text:SetJustifyH("CENTER")
o.text:SetText("No poison on off hand weapon!")


local f = CreateFrame("Frame")
f:RegisterEvent("PLAYER_ENTERING_WORLD")
f:RegisterEvent("UNIT_INVENTORY_CHANGED")
f:SetScript("OnEvent", function(self, event, arg1)
	if event == "UNIT_INVENTORY_CHANGED" and arg1 ~= "player" then return end

	local hasMainHandEnchant, _, _, hasOffHandEnchant = GetWeaponEnchantInfo()
	-- print(event, "MH", hasMainHandEnchant and "Y" or "N", "OH", hasOffHandEnchant and "Y" or "N")

	local mainHandLink = GetInventoryItemLink("player", GetInventorySlotInfo("MainHandSlot"))
	if not hasMainHandEnchant and mainHandLink and select(7, GetItemInfo(mainHandLink)) ~= "Fishing Poles" then
		m:Show()
	else
		m:Hide()
	end

	if not hasOffHandEnchant and GetInventoryItemLink("player", GetInventorySlotInfo("SecondaryHandSlot")) then
		o:Show()
	else
		o:Hide()
	end
end)

I hate XML, so the frames are created in pure Lua. If you want to do it in XML, I'll leave it up to you to figure out how to convert it.