As I've said, there is no replacement for PLAYER_REGEN_DISABLED and _ENABLED yet.
As of current build, I've got these events (Mekkatorque). There are also still used by Blizzard code (including Blizzard_CombatText) to detect start and end of combat. Isn't it a server issue ?
The main breakage isn't determining whether you are in combat lockdown or not. The main breakage is that everyone uses those 2 events to tell when the player enters and exits combat (eg, boss mods, unit frames, etc) and there aren't any equivalent events that do that.
In my particular case, I've got an addon (FlaskMinder) that can be set to check your flask / elixir status when combat starts... truthfully, I don't really use that option much - preferring to check on a ready-check event, but it was one such use of "PLAYER_REGEN_DISABLED" that I had in the code.
I'll work around it - I can use the "if InCOmbatLockdown()" to supress timer and expiration-based warnings during comabt (what't the point of my addon reminding you your food just wore off when you're in combat and can't actually do anything about it at the moment anyway?)
I finally got my Beta install up and running and can start testing things out for real.
Thanks for the InCombatLockdown() idea though - I think I can work around my issues with that.
In all my testings, isNotRadial is not working. That what is used in blizz code and what is documented in UIDropDownMenu.lua. I haven't tried isNotRadio. I guess I should. Where did you get that?
fwiw, it wouldn't suprise me to see a typo in the docs.
the docs on live say "menuTable" is the entry for the subtable of a dropdown, when in reality it's "menuList".
the docs on live say "menuTable" is the entry for the subtable of a dropdown, when in reality it's "menuList".
It's been that way since that code was implemented. It's been noted by a couple of us in the thread for the excellent dropdown menu guide on this forum.
if info.isNotRadio then
_G[listFrameName.."Button"..index.."Check"]:SetTexCoord(0.0, 0.5, 0.0, 0.5);
_G[listFrameName.."Button"..index.."UnCheck"]:SetTexCoord(0.5, 1.0, 0.0, 0.5);
else
_G[listFrameName.."Button"..index.."Check"]:SetTexCoord(0.0, 0.5, 0.5, 1.0);
_G[listFrameName.."Button"..index.."UnCheck"]:SetTexCoord(0.5, 1.0, 0.5, 1.0);
end
Hmmm... can't connect to test right now but when I run the addon kit on the beta repository, I have the following in UIDropDownMenu.lua
if not info.notCheckable then
if info.isNotRadial then
_G[listFrameName.."Button"..index.."Check"]:SetTexCoord(0.0, 0.5, 0.0, 0.5);
_G[listFrameName.."Button"..index.."UnCheck"]:SetTexCoord(0.5, 1.0, 0.0, 0.5);
else
_G[listFrameName.."Button"..index.."Check"]:SetTexCoord(0.0, 0.5, 0.5, 1.0);
_G[listFrameName.."Button"..index.."UnCheck"]:SetTexCoord(0.5, 1.0, 0.5, 1.0);
end
I'm resurrecting this thread now that the addons are active on the beta servers.
(I'll edit when I find others and list replacements if I find any)
Functions that are no longer available:
GetArenaCurrency() -- I think this currency no longer exists
GetHonorCurrency() -- I think this currency no longer exists
I was wrong. As it was pointed out by Elkano, GetArenaCurrency() can be replaced by GetCurrencyInfo(390) and GetHonorCurrency() by GetCurrencyInfo(392).
For compatibility, I used:
local GetArenaCurrency = GetArenaCurrency or function() return select(2,GetCurrencyInfo(390)) or 0 end
local GetHonorCurrency = GetHonorCurrency or function() return select(2,GetCurrencyInfo(392)) or 0 end
The one thing I'm not sure about is that 390 is also used for Conquest currency. As I didn't do any PvP on the beta server, I not sure what it means.
I don't seem to be having any trouble in my (limited) testing of PLAYER_REGEN_ENABLED/DISABLED. But I have only tested on single mobs outside of instances and not in a raid.
Did they change the dstGUID flags? Here is the ID's I found for Crystalline Ice Elemental:
Live = 0xF5300066CC12D00B
Cat = 0xF13066CC001BDA96
I was using this code on live to get unitID:
mobID = tonumber(string.sub(dstGUID, 9, 12), 16)
So I switched to the following for cat and it seems to be giving me the same unitID's I expect:
Given that these two events cause the "Entering combat" and "Leaving combat" messages to be displayed as floating combat text (and that I display them), I think I haven't got any issue with it, either outside or in 5-man instance.
something weird is going on with aceconfig layouts after the latest patch, every now and then the pane with the options in it shifts to overlap the tree view when you change one of the values in it. re-opening the frame corrects it.
In English, localized_label == "Justice Points". icon_file_name == "pvecurrency-justice" (doesn't have the path). I use this to insert the justice point icon in my strings:
You can throw the presenceId onto BNGetToonInfo to at least get his toon name, but from what i can tell, thats it.
Although you can still get the real name from the friends list, can't you?
Edit: guess the id that gettooninfo takes is not the same as the presence id.
But you could iterate the friend list and compare presence ids?
Oh well, i don't see where i ever needed the name anyway
As of current build, I've got these events (Mekkatorque). There are also still used by Blizzard code (including Blizzard_CombatText) to detect start and end of combat. Isn't it a server issue ?
In my particular case, I've got an addon (FlaskMinder) that can be set to check your flask / elixir status when combat starts... truthfully, I don't really use that option much - preferring to check on a ready-check event, but it was one such use of "PLAYER_REGEN_DISABLED" that I had in the code.
I'll work around it - I can use the "if InCOmbatLockdown()" to supress timer and expiration-based warnings during comabt (what't the point of my addon reminding you your food just wore off when you're in combat and can't actually do anything about it at the moment anyway?)
I finally got my Beta install up and running and can start testing things out for real.
Thanks for the InCombatLockdown() idea though - I think I can work around my issues with that.
fwiw, it wouldn't suprise me to see a typo in the docs.
the docs on live say "menuTable" is the entry for the subtable of a dropdown, when in reality it's "menuList".
It's been that way since that code was implemented. It's been noted by a couple of us in the thread for the excellent dropdown menu guide on this forum.
Hmmm... can't connect to test right now but when I run the addon kit on the beta repository, I have the following in UIDropDownMenu.lua
Seek the MPQEditor thread on wowinterface on how to get the actual source.
I'll have a look, thanks.
I was wrong. As it was pointed out by Elkano, GetArenaCurrency() can be replaced by GetCurrencyInfo(390) and GetHonorCurrency() by GetCurrencyInfo(392).
For compatibility, I used:
The one thing I'm not sure about is that 390 is also used for Conquest currency. As I didn't do any PvP on the beta server, I not sure what it means.
The first player that gets on a mob's hate list doesn't fire that event.
Subsequent threat situation changes do.
Did they change the dstGUID flags? Here is the ID's I found for Crystalline Ice Elemental:
Live = 0xF5300066CC12D00B
Cat = 0xF13066CC001BDA96
I was using this code on live to get unitID:
So I switched to the following for cat and it seems to be giving me the same unitID's I expect:
In English, localized_label == "Justice Points". icon_file_name == "pvecurrency-justice" (doesn't have the path). I use this to insert the justice point icon in my strings:
There is no more player name for BN chat (arg2) insteaad there is a presence ID which looks like a hyperlink
|Knn|Knnnnnnnn|K
These are used everywhere in place of a toon name.
Although you can still get the real name from the friends list, can't you?
Edit: guess the id that gettooninfo takes is not the same as the presence id.
But you could iterate the friend list and compare presence ids?
Oh well, i don't see where i ever needed the name anyway