I would like to read the full info for buffs people have; specifically Well Fed. I want to read the mouse over text. UnitBuff() only provides the name and not the full details such as what attributes it buffs.
If you're getting it from UnitAura, you'd probably have to parse the tooltip text to determine what bonuses were being provided. Another option is to capture and cache it at the time that it's applied via the combat log. Then you'd have the spell ID and could maintain a mapping of spell IDs to their various effects.
Rather than "intrusively" inspecting each player's buffs by parsing the tooltips (which happen to be very inconsistent with each other), I too think it would be easiest just to monitor the combat log. That way you could keep a simple list of SpellIDs to blacklist or whitelist.
When your addon observes someone in your raid gaining a blacklisted aura, it could report to the raid chat, "If you want to eat junk food before a raid, you'd better do it somewhere I can't see you, <NAME>!"
Edit: This would also make your addon easy to localize, and possibly quite popular if you can make it say something amusing. :)
Another option is to capture and cache it at the time that it's applied via the combat log. Then you'd have the spell ID and could maintain a mapping of spell IDs to their various effects.
Interesting. But is there a way to read directly the spell id or must it be from the combat log. Also it will not spot people when I am out of range.
Rather than "intrusively" inspecting each player's buffs by parsing the tooltips (which happen to be very inconsistent with each other), I too think it would be easiest just to monitor the combat log. That way you could keep a simple list of SpellIDs to blacklist or whitelist.
When your addon observes someone in your raid gaining a blacklisted aura, it could report to the raid chat, "If you want to eat junk food before a raid, you'd better do it somewhere I can't see you, <NAME>!"
Edit: This would also make your addon easy to localize, and possibly quite popular if you can make it say something amusing. :)
You would set a GameTooltip frame to contain the given buff using GameTooltip:SetUnitAura() and then read the lines from it. There's some good info on how to do that here:
Better idea... you want people to have food buffs? Bring feasts. If someone were to bitch about my choice food (or not), I'd ignore it if he wasn't willing to put his money where my mouth is.
Better idea... you want people to have food buffs? Bring feasts. If someone were to bitch about my choice food (or not), I'd ignore it if he wasn't willing to put his money where my mouth is.
Very good point. Fish feasts are relatively easy to make now anyways since you can fish up all the fish standing in one spot in Wintergrasp.
Plus, there's just something familial about everyone in the guild sitting down in front of a roasted pig or platter of fish before the raid. :)
I totally see why this is an issue you're trying to solve with your addon... My guild recently did a naxx where one of our hunters (who admittedly is rather young) came prepared for the raid.... we said have a flask, and he had one ... yep... one of the Grulls lair exclusive ones.
So, the raid leader's addon said he checked out as having a flask, but the guild leader who happened to be in raid too had a different addon, saw he had a flask that was completely useless, and called him on it.
We all had a good laugh, but it illustrates the differences in addons checking for perparedness.
As with everything else in life, you can do the quick low-impact way (just look for Well fed), or you can do the deeper, more time/energy intensive way (determining the type and appropriateness).
They're both valid approaches, but depend upon what your addon's purpose is.
In my guild (with that hunter incident as a single, rather funny exception), they're mostly concerned that everyone's made the effort to show up with consumables and has remembered to use them. Raid leader checks before first boss in each wing of Naxx or before starting OS/VOA, and after any wipe recovery. For us, it's enough cuz anyoe without a flask / food buff, is that way cuz they forgot to apply it, not because they're being cheap and trying to get away with something.
Guess it depends on the philosophy behind your addon. Light weight, but superficial, or exacting, but with lots of maintenance/overhead.
I really respect addon authors who maintain item databases and such in their code - but for me, Bliz changes too many things too often, so I try and stay lightweight.
Wish I could provide some actual useful code advice instead of philosophy though.
Better idea... you want people to have food buffs? Bring feasts. If someone were to bitch about my choice food (or not), I'd ignore it if he wasn't willing to put his money where my mouth is.
Feasts are not the best food. In our guild we expect top buffing, enchants, flasks, foods etc. Which is why I wrote RBS in the first place. I got sick of slackers. I would love an addon that checks enchants too.
You would set a GameTooltip frame to contain the given buff using GameTooltip:SetUnitAura() and then read the lines from it. There's some good info on how to do that here:
Feasts are not the best food. In our guild we expect top buffing, enchants, flasks, foods etc. Which is why I wrote RBS in the first place. I got sick of slackers. I would love an addon that checks enchants too.
Fish Feasts are the best food (if not ppl need hit/crit/haste or whatever more). Our guild bank is buying fish from members so we always have fish feasts in progress raids.
So I guess the best way would be reading the tooltip and scanning for >= 46 spellpower and/or >= 80 attack power (or that other haste/hit/crit stuff) instead of maintaining a list of valid buffs.
Fish Feasts are the best food (if not ppl need hit/crit/haste or whatever more). Our guild bank is buying fish from members so we always have fish feasts in progress raids.
Rather offtopic, but fish feasts are not the best for AP-based classes, they should use agi/str instead since those scale with talents/BoK. So there is merit in doing a more comprehensive check than "did he eat a feast" if the intention is to detect the absolute best food buff.
Rather offtopic, but fish feasts are not the best for AP-based classes, they should use agi/str instead since those scale with talents/BoK. So there is merit in doing a more comprehensive check than "did he eat a feast" if the intention is to detect the absolute best food buff.
Isn't "the best" food buff kind of subjective? If you're not hit capped (yes, I know, a guild who would be insisting on best buffs surely wouldn't take someone not hit capped along on an important raid), then +40 hit food might be best for you. If you're a prot or ret pally, wouldn't the "double-whammy" of AP AND Spell Power from a fish feast be the "best food"?
It seems like you want your addon to be able to min/max food buffs for your raid, and I'm just wondering if that's not a LOT of extra work for a somewhat diminished return. It's going to take a bunch of rules processing to determine what's best, and in the end, it's still (in my opinion) kind of subjective.
Of course, as I said in a previous post, while I'd never again be part of a hard-core raiding guild (too mush stress for me), I understand that hardcore guilds often do care very much about getting every last benefit they can from buffs/talent builds, etc.
Rather offtopic, but fish feasts are not the best for AP-based classes, they should use agi/str instead since those scale with talents/BoK. So there is merit in doing a more comprehensive check than "did he eat a feast" if the intention is to detect the absolute best food buff.
Scaling with kings doesn't automatically make it better. Aldriana's and Vulajin's sheets show AP food as the best for rogues by roughly 60 DPS (without 4 piece t8 ).
More semi-related derailment: the Arms warriors in my guild are eating Hearty Rhino for armor pen and our DKs are eating Dragonfin Filet for Strength. They (rightfully) consider Fish Feasts to be inferior food buffs. On the other hand, the Fish Feast buff is markedly better than anything else for an Enhancement Shaman or a Ret Paladin because they buff both AP and spellpower.
More semi-related derailment: the Arms warriors in my guild are eating Hearty Rhino for armor pen and our DKs are eating Dragonfin Filet for Strength. They (rightfully) consider Fish Feasts to be inferior food buffs. On the other hand, the Fish Feast buff is markedly better than anything else for an Enhancement Shaman or a Ret Paladin because they buff both AP and spellpower.
Which is exactly why I think this sort of addon is stupid. Making sure people are eating is one thing, checking that they have the "best" is far too subjective to be worth all the extra code.
Which is exactly why I think this sort of addon is stupid. Making sure people are eating is one thing, checking that they have the "best" is far too subjective to be worth all the extra code.
/agreed
... though would you not agree that all Bacon-based food buffs are best, being made of nature's perfect food?
Which is exactly why I think this sort of addon is stupid. Making sure people are eating is one thing, checking that they have the "best" is far too subjective to be worth all the extra code.
It's not subjective - it's simple maths and is a science. However making an addon which determines roles, gear stats, encounter and so on is far too silly. Hence all I do is at least ensure people are using WotLK 40 stam food. One of those is the best and it's up to the player to choose which.
The same thing for flasks and elixirs. Although that would be much more achieveable.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
http://www.wowwiki.com/Well_Fed shows a long list and I want to determine which it is.
The point is to check everyone has the best possible food not just some cheap ass food.
Ideally I would like the spellid and I can enumerate the good food ids. Or maybe read the mouse over text and interpret the stats there.
Any ideas?
When your addon observes someone in your raid gaining a blacklisted aura, it could report to the raid chat, "If you want to eat junk food before a raid, you'd better do it somewhere I can't see you, <NAME>!"
Edit: This would also make your addon easy to localize, and possibly quite popular if you can make it say something amusing. :)
How can I read the tooltip text for the buff?
Interesting. But is there a way to read directly the spell id or must it be from the combat log. Also it will not spot people when I am out of range.
Hah interesting idea. Thanks.
You would set a GameTooltip frame to contain the given buff using GameTooltip:SetUnitAura() and then read the lines from it. There's some good info on how to do that here:
http://www.wowwiki.com/UIOBJECT_GameTooltip
Yep, that would be a drawback of that method.
Very good point. Fish feasts are relatively easy to make now anyways since you can fish up all the fish standing in one spot in Wintergrasp.
Plus, there's just something familial about everyone in the guild sitting down in front of a roasted pig or platter of fish before the raid. :)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumSo, the raid leader's addon said he checked out as having a flask, but the guild leader who happened to be in raid too had a different addon, saw he had a flask that was completely useless, and called him on it.
We all had a good laugh, but it illustrates the differences in addons checking for perparedness.
As with everything else in life, you can do the quick low-impact way (just look for Well fed), or you can do the deeper, more time/energy intensive way (determining the type and appropriateness).
They're both valid approaches, but depend upon what your addon's purpose is.
In my guild (with that hunter incident as a single, rather funny exception), they're mostly concerned that everyone's made the effort to show up with consumables and has remembered to use them. Raid leader checks before first boss in each wing of Naxx or before starting OS/VOA, and after any wipe recovery. For us, it's enough cuz anyoe without a flask / food buff, is that way cuz they forgot to apply it, not because they're being cheap and trying to get away with something.
Guess it depends on the philosophy behind your addon. Light weight, but superficial, or exacting, but with lots of maintenance/overhead.
I really respect addon authors who maintain item databases and such in their code - but for me, Bliz changes too many things too often, so I try and stay lightweight.
Wish I could provide some actual useful code advice instead of philosophy though.
Feasts are not the best food. In our guild we expect top buffing, enchants, flasks, foods etc. Which is why I wrote RBS in the first place. I got sick of slackers. I would love an addon that checks enchants too.
That looks good thanks. I will try it.
So I guess the best way would be reading the tooltip and scanning for >= 46 spellpower and/or >= 80 attack power (or that other haste/hit/crit stuff) instead of maintaining a list of valid buffs.
Rather offtopic, but fish feasts are not the best for AP-based classes, they should use agi/str instead since those scale with talents/BoK. So there is merit in doing a more comprehensive check than "did he eat a feast" if the intention is to detect the absolute best food buff.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIsn't "the best" food buff kind of subjective? If you're not hit capped (yes, I know, a guild who would be insisting on best buffs surely wouldn't take someone not hit capped along on an important raid), then +40 hit food might be best for you. If you're a prot or ret pally, wouldn't the "double-whammy" of AP AND Spell Power from a fish feast be the "best food"?
It seems like you want your addon to be able to min/max food buffs for your raid, and I'm just wondering if that's not a LOT of extra work for a somewhat diminished return. It's going to take a bunch of rules processing to determine what's best, and in the end, it's still (in my opinion) kind of subjective.
Of course, as I said in a previous post, while I'd never again be part of a hard-core raiding guild (too mush stress for me), I understand that hardcore guilds often do care very much about getting every last benefit they can from buffs/talent builds, etc.
Scaling with kings doesn't automatically make it better. Aldriana's and Vulajin's sheets show AP food as the best for rogues by roughly 60 DPS (without 4 piece t8 ).
Which is exactly why I think this sort of addon is stupid. Making sure people are eating is one thing, checking that they have the "best" is far too subjective to be worth all the extra code.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium/agreed
... though would you not agree that all Bacon-based food buffs are best, being made of nature's perfect food?
It's not subjective - it's simple maths and is a science. However making an addon which determines roles, gear stats, encounter and so on is far too silly. Hence all I do is at least ensure people are using WotLK 40 stam food. One of those is the best and it's up to the player to choose which.
The same thing for flasks and elixirs. Although that would be much more achieveable.