Authors CurseForge

Hi,
the event PARTY_KILL does not recognize the kills of a Hunter/DK pet.
Now, my question is: can PARTY_KILL trigger the kills of own pets?
I tried it this way:
When i exchange "pet" with "player" and i kill some enemie, the if-party gets executed.

local petID = UnitGUID("pet");
local toEnemy = CombatLog_Object_IsA(dstFlags, PS_COMBATLOG_FILTER_ENEMY_PLAYERS)

if (eventType == "PARTY_KILL" and srcGUID == pet and toEnemy ) then
.
.
.
bla
.
.
.
end

Quote from zeriouz

Hi,
the event PARTY_KILL does not recognize the kills of a Hunter/DK pet.
Now, my question is: can PARTY_KILL trigger the kills of own pets?
I tried it this way:
When i exchange "pet" with "player" and i kill some enemie, the if-party gets executed.

local petID = UnitGUID("pet");
local toEnemy = CombatLog_Object_IsA(dstFlags, PS_COMBATLOG_FILTER_ENEMY_PLAYERS)

if (eventType == "PARTY_KILL" and srcGUID == pet and toEnemy ) then
.
.
.
bla
.
.
.
end

srcGUID == pet -- pet is nil so this is always false. Unless pet is being set somewhere that you didn't paste.

Parse for all damage events.
- Store all sources of events doing more than 0 damage to dst.
Parse for UNIT_DIED.
- Give killing blow to last stored source doing damage to dst.

This may be wrong but is as good as it gets for any combatant who doesn't trigger the PARTY_KILL event.

At the moment i think pet are not registered in PARTY_KILLS so if MrBiggleworth gets killed by a pet the addon will not register the event :(

Acheron recently added logic to try to track pet deaths, might try taking a peek at its source to see what it does.