So I've noticed something weird started recently with two addons, and I'm wondering if it could be a pattern:
1. The default Blizzard compass thing doesn't get turned off by Chinchilla's Compass module on login or reloadui, but if I toggle the module off and back on it will then hide the default compass. The code to hide the default compass is called in the Compass module's OnEnable(), and I added print() statements to verify that it is indeed being run at login/reloadui but not taking effect.
2. Chatter's Chat Font module is not applying the selected font size at login/reloadui. Like with Cholula's Compass module, Chatter's Chat Font module is also calling the code to do this in its OnEnable() method, which is also being run at startup/reloadui. Toggling the module's enable setting off and back on causes it to call OnEnable() again and the setting then takes effect.
Is OnEnable() for Rock and Ace3 addon modules being called at the wrong time on login/reloadui, so that some operations they try to do won't have any effect? Or is there something else going on?
Edit: I guess maybe they're isolated cases after all, as nobody seems to know anything.
What's weird is that the issues with both modules disappear if you disable and then enable them, so I think it may be some kind of a timing issue with regards to when they are automatically enabled at startup.
Okay, I scoured for Ace3 examples to adapt to Chatter and found Bartender4's StanceBar module. Attached is my cut at a fix to Chatter's ChatFont module for review. It seems to work, but since I don't know what I'm doing I'm not sure how elegant it is :p
Edit: Chinchilla's issue seems to be different. Blizzard changed the default minimap compass to show at a different time, and delaying until PLAYER_ENTERING_WORLD was not enough. I'm going to ninja-commit a fix since ckknight is AWOL working on the curse client.
Edit 2: Haven't received any feedback here or from Antiarc on IRC, so I'm just going to check in my Chatter ChatFont hack unless anyone has any objections.