As far as I remember they didn't implement the "isMine" change until a few builds after the PTR went up and that mod was broken since the very start of the 3.1 PTR.
...essentially button (frame) names have changed from $parentDebuffX to $parentAuraX. This need to be reflected in both the aforementioned files. Unfortunately, the EU PTR went down, as soon as I was testing the fixes (and I don't even know if anything else can break later down the road), but seems that the addon can be 'revived' without too much hassle (hopefully).
Good to know that hopefully the mod won't require any significant changes in order to get it working again, I like the Blizzard unit frames just hate that they don't by default show pet/party buffs/debuffs or show the full amount of target debuffs.
To fix the "isMine" issue is that as simple as replacing it with "caster"?
No you need to match a unit token to it now (its not a boolean anymore). A very simplified fix for the case of checks would be :
If isMine then ...
If isMine == "player" then
Anyway, concerning the actual addon, I believe I've fixed the basics (at the very least it doesn't error in combat anymore and seems okish), though a better test would obviously be in a raid. This is just a quick attempt fiddling with the obvious changes and should be regarded as such.
No you need to match a unit token to it now (its not a boolean anymore). A very simplified fix for the case of checks would be :
If isMine then ...
If isMine == "player" then
Anyway, concerning the actual addon, I believe I've fixed the basics (at the very least it doesn't error in combat anymore and seems okish), though a better test would obviously be in a raid. This is just a quick attempt fiddling with the obvious changes and should be regarded as such.
Appears to be working without errors so far, I just need to work out the isMine stuff so my pets debuff doesn't show big like I cast it.
[edit]
Most players buffs seem to be big like I cast them too, but I'm guessing that's the same thing an isMine issue, just trying to figure out where I'm supposed to put the check in TargetBuffs.lua
[edit again]
Enabling the debug at the bottom of the TargetBuffs.lua so that there are 40 buffs/debuffs on the target/pet frame errors when I summon or have my pet out, so looks like something we've missed.
Chatter , DBM , WIM are the addons that didn't immediately work for on the 3.1 PTR.
Mind you I haven't really installed many addon on the PTR as yet.
Chatter could do with an update for 3.1 (*prods Antiarc and Grum*) but I'm using Prat-3.0 now (I like the concept of disabling parts of it).
DBM I heard reports that it was blocking whispers by the crew at deadlybossmods.com are onto. They have declared DBM 4.10 compatiable with the 3.10 PTR and the live realms. Versions previous to 4.10 will not work on the PTR. (just checked that now lol)
WIM I dont normally use but wanted it as I was offering free glyphs on the PTR and I wanted something to manage my whispers better. I couldn't get it to work so I replaced it with Cellular which does. Cellular still has a problem with Nested preference menus tho so I had to edit the savedvariables .wtf files directly (logically name prefences FTW!)
WIM I dont normally use but wanted it as I was offering free glyphs on the PTR....
The Dalaran Inscription trainer has a glyph vendor next to him selling *every* known glyph in the game for PTR testers. Blues posted about this before, but for some obscure reason, very few people know about it.
Basically:
- Changes to chat filters: chat addons, boss mods...
- Changes to the buff API: unitframe addons, the gazillion of timer addons out there, buff/debuff watcher addons, the malygos helper addons, combat log parsers (read damage meter and the likes)...
- GetPlayerFacing(): TomTom (and I think it affects Astrolabe, right? So any addon using it?), gathering addons...
- Equipment Manager: not sure it's going to break anything, but instead offers extra functionality...
- Dual-spec and Glyphs: any addon that has to do with talents and/or glyphs...
- Objective Tracking: does that break existing quest/achievement addons?
- Queuing for BGs anywhere: don't see how that would affect add-ons...
- Changes to LFG: not many addons have ventured there...
- New arena frames: still can't find any comments about it. Curious as to what unitframe addon authors think of it. Sounds like Proximo.
- Dropdown menus: Tristanian addressed that.
- Color-blind features: good stuff. Doubt it breaks anything, probably makes some addons redundant.
Did I miss anything?
Overall, quite a few things need updated, but it's nothing huge and it's more about added functionality than anything.
- Objective Tracking: does that break existing quest/achievement addons?
Anything that references the old frame names or any functions that no longer exist will need to be updated. This includes minimap addons with movers for the quest tracker, etc. PocketPlot has been updated already for the PTR - the file is on the Beta files tab of its download page on wowi.
Appears to be working without errors so far, I just need to work out the isMine stuff so my pets debuff doesn't show big like I cast it.
[edit]
Most players buffs seem to be big like I cast them too, but I'm guessing that's the same thing an isMine issue, just trying to figure out where I'm supposed to put the check in TargetBuffs.lua
[edit again]
Enabling the debug at the bottom of the TargetBuffs.lua so that there are 40 buffs/debuffs on the target/pet frame errors when I summon or have my pet out, so looks like something we've missed.
I have simulated the previous behavior of the boolean and even tested the debugging code which was ultimately linked to a *sigh* Sea dependency (don't remember anyone using that lib in years), slightly cleaned it up and implemented checks that prevent frame anchoring to non-existent parents. Should be working as intended now, I hope.
- Color-blind features: good stuff. Doubt it breaks anything, probably makes some addons redundant.
Tooltip scanning addons will break if they scanned for specific lines (Example: line 2 and 3 for soulbound status of an item, would have to be updated to scan 2/3/4.)
I have simulated the previous behavior of the boolean and even tested the debugging code which was ultimately linked to a *sigh* Sea dependency (don't remember anyone using that lib in years), slightly cleaned it up and implemented checks that prevent frame anchoring to non-existent parents. Should be working as intended now, I hope.
From limited testing this morning it seems to be all working correctly now. Thanks so much.
Did a bit more testing not sure if this is a bug with the debug code or weather it would actually cause issues when in use but here's the debug code running on live:
And here it is using the PTR version:
Whilst it no longer errors it doesn't seem to be enabling the correct number of debuffs for the pet.
Did a bit more testing not sure if this is a bug with the debug code or weather it would actually cause issues when in use but here's the debug code running on live:
Continue this on pm's, there is no reason to derail this thread for a specific issue.
Not true. All addons have the potential to break, but that doesn't mean they will. I have addons that haven't changed at all since WoW 1.x, and I don't foresee them ever breaking.
The Dalaran Inscription trainer has a glyph vendor next to him selling *every* known glyph in the game for PTR testers. Blues posted about this before, but for some obscure reason, very few people know about it.
Actually Xinhuan I was offering them before the glyph vendor was there.
They weren't there for the first few builds and there were a lot of "special" people on the PTR doing price gouging. Even now I've got 764 glyphs on the AH at 1 copper each just to offset this.
Also at first when the vendors were put in they would despawn each time the world server would go down.
Actually, speaking of, are the new glyphs going to be on research or what? I tried research on the PTR and got a whole lot of bupkiss.
Expect to pay through the ass for them.
Added around 50 new glyph recipes. These new recipes can be obtained from Books of Glyph Mastery found as world drops on Northrend monsters. Reading a Book of Glyph Mastery randomly discovers one of the newly-added recipes.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Found the culprit.
For starters, this hook:
...is invalid, since RefreshBuffs has been replaced by RefreshAuras. This needs to be changed in both PetBuffs.lua and PartyBuffs.lua.
The 2nd significant change that breaks the addon can easily be seen here : http://wowcompares.com/0109722/FrameXML/PartyFrameTemplates.xml?diff=3099551
...essentially button (frame) names have changed from $parentDebuffX to $parentAuraX. This need to be reflected in both the aforementioned files. Unfortunately, the EU PTR went down, as soon as I was testing the fixes (and I don't even know if anything else can break later down the road), but seems that the addon can be 'revived' without too much hassle (hopefully).
To fix the "isMine" issue is that as simple as replacing it with "caster"?
Anyway, concerning the actual addon, I believe I've fixed the basics (at the very least it doesn't error in combat anymore and seems okish), though a better test would obviously be in a raid. This is just a quick attempt fiddling with the obvious changes and should be regarded as such.
Appears to be working without errors so far, I just need to work out the isMine stuff so my pets debuff doesn't show big like I cast it.
[edit]
Most players buffs seem to be big like I cast them too, but I'm guessing that's the same thing an isMine issue, just trying to figure out where I'm supposed to put the check in TargetBuffs.lua
[edit again]
Enabling the debug at the bottom of the TargetBuffs.lua so that there are 40 buffs/debuffs on the target/pet frame errors when I summon or have my pet out, so looks like something we've missed.
Mind you I haven't really installed many addon on the PTR as yet.
Chatter could do with an update for 3.1 (*prods Antiarc and Grum*) but I'm using Prat-3.0 now (I like the concept of disabling parts of it).
DBM I heard reports that it was blocking whispers by the crew at deadlybossmods.com are onto. They have declared DBM 4.10 compatiable with the 3.10 PTR and the live realms. Versions previous to 4.10 will not work on the PTR. (just checked that now lol)
WIM I dont normally use but wanted it as I was offering free glyphs on the PTR and I wanted something to manage my whispers better. I couldn't get it to work so I replaced it with Cellular which does. Cellular still has a problem with Nested preference menus tho so I had to edit the savedvariables .wtf files directly (logically name prefences FTW!)
Regarding the chat filters just found this on the deadlybossmods.com front page :
A lot of people are currently reporting that DBM breaks their chat on the PTR when using a chat mod like Prat.
This is not a bug of DBM.
The reason for this problem is that Blizzard updated their chat filter API and the latest alpha version of DBM already makes use of this updated API.
But many chat mods still use the old chat filter API, making them incompatible with every mod that uses the new one.
Having this problem on the live realm means that you installed the alpha of DBM 4.10 there. Please use DBM 4.0.x on the live realm!
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe Dalaran Inscription trainer has a glyph vendor next to him selling *every* known glyph in the game for PTR testers. Blues posted about this before, but for some obscure reason, very few people know about it.
- Changes to chat filters: chat addons, boss mods...
- Changes to the buff API: unitframe addons, the gazillion of timer addons out there, buff/debuff watcher addons, the malygos helper addons, combat log parsers (read damage meter and the likes)...
- GetPlayerFacing(): TomTom (and I think it affects Astrolabe, right? So any addon using it?), gathering addons...
- Equipment Manager: not sure it's going to break anything, but instead offers extra functionality...
- Dual-spec and Glyphs: any addon that has to do with talents and/or glyphs...
- Objective Tracking: does that break existing quest/achievement addons?
- Queuing for BGs anywhere: don't see how that would affect add-ons...
- Changes to LFG: not many addons have ventured there...
- New arena frames: still can't find any comments about it. Curious as to what unitframe addon authors think of it. Sounds like Proximo.
- Dropdown menus: Tristanian addressed that.
- Color-blind features: good stuff. Doubt it breaks anything, probably makes some addons redundant.
Did I miss anything?
Overall, quite a few things need updated, but it's nothing huge and it's more about added functionality than anything.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAnything that references the old frame names or any functions that no longer exist will need to be updated. This includes minimap addons with movers for the quest tracker, etc. PocketPlot has been updated already for the PTR - the file is on the Beta files tab of its download page on wowi.
I have simulated the previous behavior of the boolean and even tested the debugging code which was ultimately linked to a *sigh* Sea dependency (don't remember anyone using that lib in years), slightly cleaned it up and implemented checks that prevent frame anchoring to non-existent parents. Should be working as intended now, I hope.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumTooltip scanning addons will break if they scanned for specific lines (Example: line 2 and 3 for soulbound status of an item, would have to be updated to scan 2/3/4.)
From limited testing this morning it seems to be all working correctly now. Thanks so much.
And here it is using the PTR version:
Whilst it no longer errors it doesn't seem to be enabling the correct number of debuffs for the pet.
Continue this on pm's, there is no reason to derail this thread for a specific issue.
All addons break eventually. And not all authors can keep updating them.
Not true. All addons have the potential to break, but that doesn't mean they will. I have addons that haven't changed at all since WoW 1.x, and I don't foresee them ever breaking.
Actually Xinhuan I was offering them before the glyph vendor was there.
They weren't there for the first few builds and there were a lot of "special" people on the PTR doing price gouging. Even now I've got 764 glyphs on the AH at 1 copper each just to offset this.
Also at first when the vendors were put in they would despawn each time the world server would go down.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumExpect to pay through the ass for them.