Authors CurseForge

Imho use 0 for all the pre Wrath raids but maybe put an alias for the TBC raids to point to the 10 or 25 man difficulty index. Addons can ignore the 0 index if they find anything under the other indexes but only having a 0 index indicates its a 40 man. It allows for easier updating of the old stuff if blizzard ever decides to mess with the difficulty indexes.

I've noticed in the LibPeriodicTable-3.1-ClassSpell r212 there is still no addition of Divine Sacrifice under the Protection Paladin.

Divine Sacrifice ID: 64205

I did some checking on how to edit it to use the spell but I figure I'd post it here as well if I'm running into using the spell call in an addon someone else probably has as well.

Is there any easy way to add it in my own edit, I gave it a shot but don't understand the forumla quite yet. Or any pointers if possible.

Quote from Elkano

The class spells are automatically mined from wowhead. Unfortunately they suck... spells you learn from talents aren't included in their list...

Umm... on wowhead, working through the dropdowns:

Database -> Spells -> Class Skills -> Paladins
This one won't have Divine Sacrifice.

Database -> Spells -> Talents -> Paladins
This one will.

Am I missing something? The data is there.

Yes you are, the "Database -> Spells -> Talents -> Paladins" is showing the talents not the spells learned from talents.

When a talent gives a new ability, the spell ID for the ability/resulting buff is the same as the talent. Using the Divine Sacrifice example above, you can find the spell ID 64205, which Requital gave above, by going to Database -> Spells -> Talents -> Paladins.

Class skills function the same way: if one generates, say, a debuff on a mob, the spell ID of that debuff is the same as the ability that's on the player's toolbar.

So I'm still not sure where the problem is.

Why not add Database -> Spells -> Talents -> Paladins to the dataminer?

because then part of the dataminer would have to be rewritten to not only scan talents but then somehow figure out if the talent is just a talent or actually gives you a spell.

though i assume they would be happy to add that to the dataminer if you can figure out how to do that and write a patch for the miner

Alright. Can I ask why you'd want to separate talents that give an ability from those that don't?

i think for completeness one would want set of default spells (with earliest level), a set of talented spells, and just talents (this would include talent that give spells too i would assume). that way all your bases are covered.

Quote from Shadoweric

When a talent gives a new ability, the spell ID for the ability/resulting buff is the same as the talent. Using the Divine Sacrifice example above, you can find the spell ID 64205, which Requital gave above, by going to Database -> Spells -> Talents -> Paladins.

Class skills function the same way: if one generates, say, a debuff on a mob, the spell ID of that debuff is the same as the ability that's on the player's toolbar.

So I'm still not sure where the problem is.

This is wrong. That may be the default behavior but not all spells act that way. Hell look at palidin healing spells, I'm fairly certain almost all of them use a different spell ID for the heal event in the combat log than the spells in the spellbook.

I'd have to check, but I'm prety sure they do use the same ID (FoL and HL are straight-forward and good examples of that). What's likely different is when an ability generates multiple effects. Beacon of Light will generate 2 buffs: Beacon of Light, which uses the same ID again, and Light's Beacon, which is another one.

Or to use a talent that gives an ability, Killing Spree for a rogue. The ability you get uses the same ID as the talent, and so does the buff the rogue gets (I did check that via combat log), but the extra attacks generated are 2 different spell IDs.

I spent a decent amount of time identifying all this when looking for all possible player-generated bleed effects in the game (I was an Assassination rogue: Hunger for Blood needs a bleed), in order to quickly know via addons when I could use Hunger for Blood without applying my own bleed first


Either way, I understand now that it'd be preferable to separate talents that give and ability from those that don't. Fair enough. The data is there though, if not easily sorted.

What Elkano said.

The miner code to handle these single exceptions:

-- Adds items not mineable / easily mineable to the end of a set
-- For instance rank 1 talents to ClassSpell
local additionalSetItems = {
	["ClassSpell.Druid.Balance"] = ",-5570:30,-33831:50,-50516:50,-48505:60",
	["ClassSpell.Druid.Feral Combat"] = ",-49377:30,-33878:50,-33876:50,-50334:60",
	["ClassSpell.Druid.Restoration"] = ",-17116:30,-18562:40,-48438:60",
	["ClassSpell.Mage.Frost"] = ",-12472:20,-11958:30,-11426:40,-31687:50,-44572:60",
	["ClassSpell.Paladin.Protection"] = ",-64205:20",
	["ClassSpell.Rogue.Combat"] = ",-51690:60",
}

So please post your rank 1 talents so they can get added to the class spells.

All trinkets should get mined now. Needed splitting out on quality.

I noticed an error in Currency items. It has some instances of double commas"...,,...". Seems wrong.

Quote from pompachomp

When are the drops from ToC and Onyxia going to get included into LPT?

PT3 is generally maintained by authors of mods. Your question is best answered by saying what mod you are using that is missing them and then asking its author to fix it.