And wouldn't you know it, someone has reported another issue, this time with the worldframemousedown.
2x LibResComm-1.0-90072:320: bad argument #1 to 'match' (string expected, got nil)
LibResComm-1.0-90072:320: in function `worldFrameOnMouseDown'
LibResComm-1.0-90072:374: in function <...ibs\LibResComm-1.0\LibResComm-1.0\LibResComm-1.0.lua:373>
<in C code>: ?
I know the cause, I think. The L variable isn't picking up CORPSE_TOOLTIP outside of the enUS.
It's because your locale code replaces everything from the enUS locale when it encounters a locale that is not enUS.
Edit: Phanx said something about it in the other thread, although he didn't say it might lead to errors.
Edit again:
Example:
local t = {
a = "1",
}
t = {
b = "2",
}
print(t.a) -- prints nil (or nothing since nil is the only thing passed) because ["a"] no longer exists.
-- whereas
local t = {
a = "1",
}
t.b = "2"
print(t.a) -- prints "1"
I just downloaded a copy of r75 directly from the project page, and don't see any problems with the encoding for any language. All characters are properly displayed, and the file is properly recognized as having UTF8 encoding by my editor.
If it works, then the ticket can be closed. Just asking before I close the ticket. On a side note, the only way I have been able to get a release tag is name it starting with "v", but I would prefer to use DathRarhek's naming, which started with "r", just like the alphas.
I would imagine it is a setting in the repository, but what?
From "Files," click the file you want to change after tagging it on the left, click "File Management" on the right, click "Edit file" below that, change "File type" to "Release," click "Update."
As for any repo way, I don't know, I just use "v<version number>."
Personally, I use "r<revision>" for alpha/beta versions, and just "<version>" for release versions. Prepending the version number with a "v" ends up being redundant, since everywhere the version number is shown also includes the word "Version". There's not much point in using something that works out to "Version version 5".
I'm fairly sure the strings returned by HasSoulstone() match up to global strings and spell names. If this is indeed the case, then we can remove localization, but we will need users from non-English locales to verify that the text shown on the Blizzard dialog matches.
If anyone reading plays in a non-English locale, the next time you die with a self-res option available, please type the relevant command below (depending on which type of self-res you have available), and report back in this thread with what is shown in your chat frame.
And that is why I left it as an alpha upload. Although, besides adding ptBR, I didn't change any code. Phanx fixed my redundant load step, but that was in the toc.
I need people in non-English clients to confirm the results of the commands I previously posted before I can remove the translations. It's not a high priority, but if you know anyone who plays in another language, please point them at my post.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I know the cause, I think. The L variable isn't picking up CORPSE_TOOLTIP outside of the enUS.
Edit: Phanx said something about it in the other thread, although he didn't say it might lead to errors.
Edit again:
Example:
please see my tickets:
http://www.wowace.com/addons/librescomm-1-0/tickets/
I posted fixes since r68
http://www.wowace.com/addons/librescomm-1-0/tickets/9-r68-v70-localization-drycode-errors/
Gave explanations and links to the LUA manual to help.
I would imagine it is a setting in the repository, but what?
From "Files," click the file you want to change after tagging it on the left, click "File Management" on the right, click "Edit file" below that, change "File type" to "Release," click "Update."
As for any repo way, I don't know, I just use "v<version number>."
Vendetta?
If anyone reading plays in a non-English locale, the next time you die with a self-res option available, please type the relevant command below (depending on which type of self-res you have available), and report back in this thread with what is shown in your chat frame.
Reincarnate
Twisting Nether
Use Soulstone
How goes the possible removing of localization?