Authors CurseForge

Quote from xbeeps

It's better to use unit names rather than units. All API functions that take a unitID can also take a unit name as long as you're grouped, which is always the case.

Anyway, you need to make sure the code is aware of the fully qualified names ("Name-Realm"). I just checked the LibResComm code and it currently isn't, but it can be fixed in the addon, if you want to, because it only affects reception.

When you receive a ress message you need to consider if the name of the target is really correct. Consider this:

Player P1 is on Realm A
Player P2 is on Realm B
Player P3 is on Realm B

P2 resses P3

P2 will transmit a message where it says "RES P3". Because P2 and P3 are on the same realm the name given will be "P3", because that is the fully qualified name as seen from P2.

However, from the point of view of P1, who (also) receives the message, "P3" is known as "P3-B", because P1 and P3 are on different realms.

Another situation is when for example P3 resses P1. When P1 receives that message it will be "P1-A", and the realm needs to be stripped from that name to actually work. Note that P2 will also receive the message, but will *not* have to strip the realm!

Consequently, if nothing is done about the name, it will not be successfull when using the name in API's.

To fix that, you need to convert the names received. In LibHealComm-3.0 i use the following code to do that:

local function extractRealm(fullName)
    return fullName:match("^[^%-]+%-(.+)$");
end

-- Convert a remotely generated fully qualified name to
-- a local fully qualified name.
local function convertRealm(fullName, remoteRealm)
    if (remoteRealm) then
        local name, realm = fullName:match("^([^%-]+)%-(.+)$");
        if (not realm) then
            -- Apply remote realm if there is no realm on the target
            return fullName .. "-" .. remoteRealm;
        elseif (realm == playerRealm) then
            -- Strip realm if it is equal to the local realm
            return name;
        end
    end
    return fullName;
end

Then, when you get a name in, you do something like this:

targetName = convertRealm(targetName,  extractRealm(sender))

Where targetName is the name of the target and sender is the name of the player sending the message.

Ideally this should be build into LibResComm-1.0 similar to how it is built into LibHealComm-3.0, so that the fully qualified names delivered by the library are always correct instead of reflecting the sender's realm.

svn propset svn:keywords Revision LibResComm-1.0

Quote from Phanx

Neither; it is an SVN property, and is set through your SVN client. However, when you did an SVN checkout, the property should have been automatically set, just like SVN externals, SVN eol-style, and/or any other properties that were previously set by other developers.