Hm, you mean this should already work?
Then I'll assume it checks the debuff name, not the debuff ID, right? Then that's the problem, because Blizzard localized 69633 as "Schattenschleier" but 24674 as "Schleier des Schattens" :rolleyes:
It has to use name, since (de)buffs wont return their id , only spellname , unfortunately. Locale-independent as they promised ;)
Same was on the english locale on ptr.
"Veil of Shadows " vs "The Veil of Shadows" iirc. Should make a difference.
Just unnecessary, odds are it'll stay with checking by name because it's a huge pain to figure out what the actual spellID of everything is without testing it yourself, and then you add in heroic vs non-heroic. Checking by spellID will be more for things like Maexxna's Necrotic Poison which is a variable healing reduction based on heroic/non heroic.
I haven't noticed this UnitAura change, is there a discussion about it somewhere ?
It's the first I've seen of this too. both wowwiki and wowprogramming pages on UnitAura have been updated with the new return parameters though.
Another thing I've noticed is that I don't believe the Luck of the Draw buff is being correctly detected by LibHealComm-4.0.
Using v1.5.5-release in any PuG now the estimated figures for my holy priests heals are under the actual values by a significant margin. This is on an enGB client, btw.
I'll try to post some actual figures tonight, renew seems to be a good test of consistent healing output.
Ah yea oops, I forgot to add upgrade code for the self modifiers stuff too. It's actually going to be inaccurate too if you reload after getting the aura because it doesn't recheck to see if you already have a self modifier buff.
Which is ultimately why I want to move to checking UnitAura eventually for all self modifiers, but don't want to setup a bunch of 3.3 only checks right now.
Small bug in the wrapper, basically if someone is using LHC-4.0 + LWHC-1.0, and LWHC-1.0 sends the fake version request first, anyone else using the wrapper will think that person is using LHC3 not LHC4.
Latest tag will fix that so it'll ignore the wrapper fake versions and shouldn't do that.
2) The HOT effect from the combination of sacred shield and flash of light
3) to have it not only on irc but here as well so it wont be forgotten,
changing the debilitate debuff to spellid because german translation fails in utgarde keep and other spells might have the same translation for synonyms as well so its results are inaccurate .
Improved devotion Aura
Increases the armor bonus of your Devotion Aura by 17% and increases the amount healed on any target affected by any of your Auras by 2%.
Improved Devotion Aura cannot be detected without a lot of talent syncing and trickery which is why it's not supported.
Bonuses are something I'm mostly waiting for data on. I'm not sure if the 2 piece is a flat +35% modifier or something else, although I assume it's the former, but would like some solid info. I also need more data on how 2 piece Druid works and a combat log of the 4 piece proc to see about adding support for that.
I'm not moving a single debuff to spell ids because it's not setup to handle it right now. I'm still trying to find out if anyone is still on <3.3 because if nobody is then the entire system is primarily moving to spell ids.
Hots I'm undecided on. I'm not a fan of adding it in because it either requires a new set of comm code, and the HoT is going to be inaccurate because it's based off the estimated amount of the heal rather than the actual. Or, it requires sending two full comm messages per Flash of Light, which isn't exactly the most efficient solution.