Authors CurseForge

Quote from xbeeps

The API looks good. However, for GetHealAmount doesn't seem possible to get the amount of healing incoming to a target from everyone else but yourself before your currently casting heal lands (which is kind of the core functionality used by VisualHeal and the unit frame addons that properly show these as separate, and only show the incoming heals from others that land before your own). For example, if i know that my own heal will land at the time in endTime i will call GetHealAmount like this:

HealComm:GetHealAmount(guid, HealComm.ALL_HEALS, endTime)

However, there's no way to know if the heal I'm currently casting will be included in that, because the timeframe ends exactly on the point where my heal lands. I guess it depends on both rounding errors and whether you use > or >= for comparison, or other subtle things, so it's not possible to subtract the players heal size from the value returned. Regardless, from an API point of view, it should be possible to get the heal amount without the player contribution. LHC-3.0 never returned the heal from yourself in this call, and relied on the addon to remember that value by itself whenever a heal was active (which is just a matter of saving the amount in a local variable whenever a heal start event is triggered with the player as the healer).

Apart from that, i think everything looks good. Perhaps you want to reconsider exposing the internal tables, because when they are exposed you get locked down in how they are laid out, because changing them is an API change.

-- Add in the players own heals
local healed = playerHeals[target] or 0

-- Add in any heals from other people
local incoming = select(2, HealComm:UnitIncomingHealGet(target, 0))
if( incoming ) then
healed = healed + incoming
end

-- Apply any healing debuffs
healed = math.floor(healed * HealComm:UnitHealModifierGet(target))

	local playerHealed = HealComm:GetHealAmount(guid, HealComm.ALL_HEALS, nil, UnitGUID("player"))
	local restHealed = HealComm:GetHealAmount(guid, HealComm.ALL_HEALS) - playerHealed
	
	playerHealed = math.floor(playerHealed * HealComm:GetHealModifier(guid))
	restHealed = math.floor(restHealed * HealComm:GetHealModifier(guid))

lib.healingModifiers = lib.healingModifiers or {
[spellname1] = 0.5,
[spellname2] = 1,
}

lib.healingModifiers = lib.healingModifiers or {
[spellname1] = 0.5,
[spellname2] = 1,
[spellname3] = 1,
}

if AuraHandler then AuraHandler(...) end

Quote from Kollektiv

In response to: http://forums.wowace.com/showpost.php?p=286146&postcount=90

You should've looked at how LHC4 did it first :p. The way it does it now is

-- Snipped --

It is not doing it the way you described. The new entries in the upgraded version flat out never get added.

Also, AuraHandler should be something like below

if AuraHandler then AuraHandler(...) end

lib.healingModifiers = lib.healingModifiers or {
    [1] = 0.50,
    [2] = 1,
}

lib.healingModifiers[3] = 2

Quote from xbeeps

Hmm, i'm not sure you understand the problem. I want two quantites:

1) The heal that is incoming *only* from others *before* my heal lands.
2) The heal that is incoming from me.

2 is trivial, but 1 is not with the current API. Calling this:

local restHealed = HealComm:GetHealAmount(guid, HealComm.ALL_HEALS) - playerHealed

Will give me all heals that finish before and after mine, because there is no time frame given. I need those that land before mine only. Therefore, the extra argument is added:

local restHealed = HealComm:GetHealAmount(guid, HealComm.ALL_HEALS, endTimeOfCurrentlyCastingPlayerSpell) - playerHealed

However, as the boundary time is exactly the same time as the player spell lands, it is not possible to know if the currently casting player spell is or is not included in the quantity returned from GetHealAmount.

Maybe this picture explains it better: http://www.wowace.com/addons/visualheal/images/4-heal-bar/

Note the "Incoming heals from others that will complete before yours"

function HealComm:GetOtherHealAmount(guid, bitFlag, time)
	local amount = 0
	for casterGUID, spells in pairs(pendingHeals) do
		if( casterGUID ~= playerGUID ) then
			amount = amount + filterData(spells, guid, bitFlag, time)
		end
	end
	
	return amount > 0 and amount or nil
end

Quote from Kollektiv

You should've looked at how LHC4 did it first :p. The way it does it now is
<snip>
It is not doing it the way you described. The new entries in the upgraded version flat out never get added.

Quote from Kollektiv

Not a bug, but I suggest you check that GetSpellInfo(spellid) exists outside the table constructor to safeguard the lib from breaking on patch days. You never know when blizz will remove a spellid.

Quote from Kollektiv

Ah, I see how you'll add new entries. Sorry for wasting your time, I've never done something like that.

One more thing, I think you should register CLEU, CHAT_MSG_ADDON, UNIT_AURA, and the rest for healers only when the player is in a group.

Quote from xbeeps

That'll would work fine. You can also consider just adding a flag to the list of arguments, like this:

GetHealAmount(guid, bitFlag[, time[, includePlayer[, casterGuid]]])

Or perhaps a HealComm.PLAYER_HEALS bit ? Dunno if that would create some other consistency problems though. You decide!

Quote from xbeeps

I understand, my suggestions were to avoid adding the extra function, by just providing the extra semantics in an extra parameter instead of in the function name, to avoid cluttering the API.