you'll note that every lib has the actual library code in a directory off the trunk - so that if you embed it you dont pull down the entire standalone lib code and any other libs it has (like libstub and cbh and others), you just get that subdirectory which is just library code.
if the lib is small and is just the toc and lua file then the occasional extra toc file i dont mind, but the babble libs are totally different, is that because theyre automatically being built? or did someone just forget when they set it up?
Every lib basically requires LibStub (or some other loading/versioning stub). We could've put LibStub inside the LibBabble-3.0.lua file, and you wouldn't have noticed at all. Its a 1kb text file, shh :p
I guess we could setup the babble libs to pull libstub using externals, and disable nolib creation.
I need to add a new batch of cataclysm related things anyhow.
Ideally all libs would be set up to pull LibStub, CallbackHandler, and any other things they depend on as externals... would be nice not to have 10 copies of LibStub included in a single addon, and would be nice not to have 50 copies of LibStub on my hard drive in a default setup. Yeah, disk space is cheap, but that's not the point. :p
I guess we could setup the babble libs to pull libstub using externals, and disable nolib creation.
I need to add a new batch of cataclysm related things anyhow.
or we could just put the core library files into a subdirectory like how all the others appear to do so people dont have to pull files they dont need if its not for standalone use? no need to go and get all exotic.
personally i dont care, it doesnt affect my mod having the extra files in there it doesnt need, i just thought it was odd that that library was setup differently to all the others and thought id bring it up.
The only extra file in a properly setup repo for a library will be the TOC file so adding extra directories is a waste and from my experience a complete PITA. Just look at LibSharedMedia-3.0 and how fucked up things are because of the extra directory, we can't remove it and we can't remove the top level lib.xml without breaking addons.
The only extra file in a properly setup repo for a library will be the TOC file so adding extra directories is a waste and from my experience a complete PITA. Just look at LibSharedMedia-3.0 and how fucked up things are because of the extra directory, we can't remove it and we can't remove the top level lib.xml without breaking addons.
well pick a way that works and break it, isnt that the whole point of having major lib versions? so you can break things without impacting anyone using a lower version of a lib.
its not like cataclysm isnt going to break stuff, its doing that rather nicely, so why not "fix" things now if its needed, while people will accept some breakage? authors are updating their mods now, its the best time to make changes like this and get people to use them.
Also, pulling sub-directories are only possible with SVN.
oh, i didnt know that, only ever used svn for wowace. so git and mercurial users have to pull the whole thing? having the libs setup with sub directories just for svn users (for embedding purposes) doesnt seem to be worth the hassle then (unless theres also another reason?).
I think all the libs are using SVN. One of the major reasons IMO is because SVN gives you a nice rev number to pass to LibStub.
I hope not many people do that. On the libs i maintain its only in use on the legacy libraries from before the new packager. There are some downsides of this that many people just choose to ignore and then run into some weird trouble. - Someone copying your libs into their own repository, and thus losing revision information, for example.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumie; this is my svnexternals properties
you'll note that every lib has the actual library code in a directory off the trunk - so that if you embed it you dont pull down the entire standalone lib code and any other libs it has (like libstub and cbh and others), you just get that subdirectory which is just library code.
if the lib is small and is just the toc and lua file then the occasional extra toc file i dont mind, but the babble libs are totally different, is that because theyre automatically being built? or did someone just forget when they set it up?
-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorEvery lib basically requires LibStub (or some other loading/versioning stub). We could've put LibStub inside the LibBabble-3.0.lua file, and you wouldn't have noticed at all. Its a 1kb text file, shh :p
I guess we could setup the babble libs to pull libstub using externals, and disable nolib creation.
I need to add a new batch of cataclysm related things anyhow.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumor we could just put the core library files into a subdirectory like how all the others appear to do so people dont have to pull files they dont need if its not for standalone use? no need to go and get all exotic.
personally i dont care, it doesnt affect my mod having the extra files in there it doesnt need, i just thought it was odd that that library was setup differently to all the others and thought id bring it up.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Curse Premiumwell pick a way that works and break it, isnt that the whole point of having major lib versions? so you can break things without impacting anyone using a lower version of a lib.
its not like cataclysm isnt going to break stuff, its doing that rather nicely, so why not "fix" things now if its needed, while people will accept some breakage? authors are updating their mods now, its the best time to make changes like this and get people to use them.
oh, i didnt know that, only ever used svn for wowace. so git and mercurial users have to pull the whole thing? having the libs setup with sub directories just for svn users (for embedding purposes) doesnt seem to be worth the hassle then (unless theres also another reason?).
-
View User Profile
-
View Posts
-
Send Message
Curse Premium& to clarify, if a lib was using git instead, then you'd have to pull the whole repo as an external. What repo the addon is using is irrelevant.
-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorI hope not many people do that. On the libs i maintain its only in use on the legacy libraries from before the new packager. There are some downsides of this that many people just choose to ignore and then run into some weird trouble. - Someone copying your libs into their own repository, and thus losing revision information, for example.