Authors CurseForge

LibStub and CallbackHandler-1.0 based version of ItemBonusLib-1.0.

Please report bugs and feature requests here.

Note that Notifications is done now using 3 methods : A CallbackHandler based method :

function foo:OnInitialize()
  LibStub("LibItemBonus-2.0"):RegisterCallback(self, "ItemBonusLib_Update", function () dosomethinghere() end)
end

An AceEvent-3.0 based method, if AceEvent-3.0 is available :

function foo:OnInitialize()
  LibStub("AceEvent-3.0"):Embed(self)
  self:RegisterMessage("ItemBonusLib_Update")
end

function foo:ItemBonusLib_Update()
  dosomethinghere()
end

And finally the previous AceEvent-2.0 method, if AceEvent-2.0 is available :

function foo:OnInitialize()
  AceLibrary("AceEvent-2.0"):Embed(self)
  self:RegisterEvent("ItemBonusLib_Update")
end

function foo:ItemBonusLib_Update()
  dosomethinghere()
end

Quote from Xinhuan »

Ahdri, can you type "//ibonus details" without the quotes (yes there are 2 slashes in there, Jerry made a mistake with the slash command)?

Fixed in r68609.

I'm using LibItemBonus-2.0 Revision: 70494.

In the function lib:ScanItemLink() in core.lua on line 835 the code for weapon speed reads:

b.WEAPON_SPEED = get_speed(self.tooltip.lefts[i]:GetText())

This was not reading weapon speeds correctly for me on a enUS client. I believe the code should be:

b.WEAPON_SPEED = get_speed(self.tooltip.rights[i]:GetText())

And thanks for the work you have put into this latest version. It's wonderful.

Here is the Traditional Chinese(zhTW) parsing pattern.

On ONLY my hunter, I get the following errors upon login. The first one happens once, the second two repeat extremely quickly. This ONLY happens on my hunter and I believe it has to do with my Dragonstalker's Leggings (Hunter Tier 2). If I put my Tier 2 leggings into my bank, log out and back in, I do not get any errors.

I should also note that the memory usage of LibItemBonus-2.0 skyrockets right after login and keeps going up to over 15MB before a automatic garbage collection happens, dropping it back to normal, where it then climbs right back up, rinse and repeat.

Any idea?

Thank you!

[2008/04/26 08:27:05-1602-x1]: LibItemBonus-2.0\LibItemBonus-2.0\core.lua:859: attempt to index field '?' (a nil value)
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:914: in function `BuildBonusSet'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:983: in function `ScanEquipment'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:58: in function <...ce\AddOns\LibItemBonus-2.0\LibItemBonus-2.0\core.lua:50>

---

[2008/04/26 08:27:05-1602-x742]: table: 116D61D8: Chat Command 'ibonus' already exists, will not overwrite.:
AceConfigCmd-3.0\AceConfigCmd-3.0.lua:711: in function `CreateChatCommand'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:581: in function `OnInitialize'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:57: in function <...ce\AddOns\LibItemBonus-2.0\LibItemBonus-2.0\core.lua:50>

---

[2008/04/26 08:27:05-1602-x742]: LibItemBonus-2.0\LibItemBonus-2.0\core.lua:844: attempt to index local 'set' (a nil value)
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:914: in function `BuildBonusSet'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:983: in function `ScanEquipment'
LibItemBonus-2.0\LibItemBonus-2.0\core.lua:58: in function <...ce\AddOns\LibItemBonus-2.0\LibItemBonus-2.0\core.lua:50>

---

I've got a number of mods installed that add things to tooltips for items. Thank you for clearing up what was happening.

the pattern for the ignore armor effect does not work in the french locale:

pattern = "Vos attaques ignorent (%d)+ points de l'armure de votre adversaire%.", effect = "IGNOREARMOR" },

the working pattern is :

pattern = "Vos attaques ignorent (%d+) points de l'armure de votre adversaire%.", effect = "IGNOREARMOR" },

Getting the following error on my Hunter only, I have 9 lvl 70s of each class and my Hunter is the only one to throw this error on login,

[2008/08/20 18:03:53-2512-x2]: LibItemBonus-2.0\LibItemBonus-2.0\core.lua:627: attempt to index upvalue 'L' (a nil value)
(tail call): ?:
AceEvent-2.0-66043 (Ace2):910: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:903>

---

Strange... I don't really understand how this backtrace can occur. The function at line 627 is :CheckPassive(), which is only called inside :AddBonusInfo(), and is not a tail call. What's even more strange is the presence of AceEvent-2.0 in this backtrace, as there's no entry point in the library that should come from AceEvent-2.0.

Which of your addons is the one using LibItemBonus-2.0 ?

I use several but Fubar_ItemBonusFu seems to be the one your looking for.
I did change the lib calls from 1.0 to this version in my local copy and all is working fine except for hunters and the error I posted above.

Any suggestions on a fix?

Ok did some research and was able to track down the offending mod that is causing the aboved error I posted befor, it is NOT Fubar_ItemBonusesFu.
The addon causing the error on my Hunter is ClosetGnome_Fishing.

I will post a comment in the appropiate forum post related to ClosetGnome_Fishing.

Maybe take alook at the code in ClosetGnome_Fishing to track bug down?

Quote from Maytrix »

Maybe take alook at the code in ClosetGnome_Fishing to track bug down?

I will ... done :-)

How exactly have you modified your ClosetGnome_Fishing copy to use LibItemBonus-2.0 instead of ItemBonusLib-1.0 ? Have you changed the TOC ?

Make sure to load the complete lib by adding LibItemBonus-2.0\lib.xml to the TOC or <Include file="LibItemBonus-2.0/lib.xml"/> in embeds.xml

Quote from Jerry »

I will ... done :-)

How exactly have you modified your ClosetGnome_Fishing copy to use LibItemBonus-2.0 instead of ItemBonusLib-1.0 ? Have you changed the TOC ?

Make sure to load the complete lib by adding LibItemBonus-2.0\lib.xml to the TOC or <Include file="LibItemBonus-2.0/lib.xml"/> in embeds.xml

I did not edit ClosetGnome_Fishing someone else did, I have the current version from svn. But I was able to track it down as being the mod causing the error on my Hunter I posted earlier.
I did edit Fubar_ItemBonuses to use it tho and it appears to be working properly.

We've translated some patterns, now WoWEQUIP works for base stats, healing, damage, attack power etc, but not for enchants, socket bonuses and gem stats.

GENERIC_PATTERNS = {
["^%+?(%d+)%%?(.*)$"] = true,

I've understood this strng as template for stats like:
"+24 Stamina" and etcetera, this can be a white stat on item, a socket bonus or a socketed gem bonus, but in ruRU we have different patterns for White stats and socket bonuses\gem stats:
"Stamina: +24" for stats
"+24 to stamina" for socket bonuses and gem stats.
Should I write two different templates to read these stats from tooltips or smth? Thanks.

Quote from Hertz »

We've translated some patterns, now WoWEQUIP works for base stats, healing, damage, attack power etc, but not for enchants, socket bonuses and gem stats.I've understood this strng as template for stats like:
"+24 Stamina" and etcetera, this can be a white stat on item, a socket bonus or a socketed gem bonus, but in ruRU we have different patterns for White stats and socket bonuses\gem stats:
"Stamina: +24" for stats
"+24 to stamina" for socket bonuses and gem stats.
Should I write two different templates to read these stats from tooltips or smth? Thanks.

"Stamina: +24" can be expressed by the following pattern :

 ["^(.*): %+(%d+)$"] = false

false here means that the stat name appear before the value.

Are you planning to upgrade LibItemBonus-2.0 for WotLK?
The new spellpower seems to have a new name, everything else so far works.

Thank you, Jerry, for explaining these mechanics. You've helped us alot;-)
2dr_AllCOM3
This is very easy to correct, so don't worry:)

So far I've translated everything possible to ruRU locale. There are some problems with enchants and stats like +40 spell damage on weapon because of localization's ambiguity, but it will be okay after 3.0 because Spellpower changes +Healing and +Damage.
Also, I have question about some ratings:

["Two-Handed Axe Skill Rating"] = "CR_WEAPON_AXE_2H",
{ pattern = "Immune to Disarm%.", effect = "DISARMIMMUNE", value = 1 }, -- 12639
{ pattern = "Increases healing done by spells and effects by up to (%d+)%.", effect = "HEAL" },
["axe skill"] = "CR_WEAPON_AXE", -- and all other skill ratings

I thought they all were removed in 2.0.3 and in 2.1, weren't they? Thanks.