What was the reason for this?
I was just going to suggest the opposite but found this post while looking through the thread to see if it had already been suggested.
I was going to suggest this directory structure:
lib.xml (for backwards compatibility)
This is much better in my opinion because addons can include the inner "LibHealComm-3.0" folder and not get the unnecessary crap that gets included now (CBH + LS, addons using libs that use any of these should be providing their own).
Also, I've attached a diff with some slight improvements. Use it if you want to.
And if you don't mind I can do more. I love optimizing ;)
That was done because ckknight believes that is the best way to do it, and therefore it was a requirement for inclusion of LibHealComm-3.0 in PitBull. The directory structure you suggest, is what LibHealComm-3.0 had before (like it's predecessor HealComm-2.0). Personally i don't care anymore, because reaching a consensus in this community is like threading a needle that doesn't have a hole. I hate the mess created by especially callbackhandler (and i hate how much time i have wasted trying to determine how the author wants it embedded/disembedded). But there's nothing to do about it now - LibHealComm-3.0 will not change structure anymore based on personal preferences, unless there are compelling arguments, or the community as a whole reaches consensus (or hell freezes over...). I'm fully aware that CBH+LibStub are pulled in when embedded, but they are not referenced (because they are not in lib.xml), and therefore not even touched by WoW, so they have no influence on load-time, they only take up an insignificant amount of disk-space.
Less useless directories please and move the lib lua files into the main directory. All libraries need to start doing this, the extra directories for a single file each is fucking annoying.
Did you read my post?
"LibHealComm-3.0 will not change structure anymore based on personal preferences, unless there are compelling arguments, or the community as a whole reaches consensus"
I see no compelling arguments.
Quote from Ragnor »
The convoluted embedded libraries system is hilarious(ly bad).
Yes, and for as long as some people keep insisting that LibStub and CallbackHandler cannot be treated like any other library (even though that's exactly what they are technically - perhaps not mentally for LibStub, but what does that matter) the problem will persist, and people will be unhappy about it. I've been moderated once for suggesting to put LibStub in a standalone, so i don't see any solution to this, as some people don't even want a healthy discussion about the topic.
I don't know if you're joking, but this whole statement is so idiotic, i don't even know where to start. Sorry, but you're walking all over me and a lot of users. I've spent hours and hours and for some reason continue to spend additional hours on this crap because some clever guys decided LibStub and CallbackHandler are so god damn special that special rules have to be invented for them, and the reasoning behind it has to be shrouded in darkness, and any discussion about the merits moderated away from these forums. I dislike this attitude, and i dislike the attitude towards users (of addons) in this community (the "don't care about it, just do what i say" mentality), and it is beginning to push me to the point where i don't want to participate anymore. Currently this is causing me more pain than joy, and the only reason i code addons, is because it is a hobby to me that i enjoy.
I don't see how my statement was "walking all over" anyone. It was not my intention to devaule your efforts to decipher the rules concerning embedding libraries, and it certainly was not my intention to discourage discussion. I was simply stating my agreement with previous posters. In no way was I attempting to issue a command that anyone was required to obey. My statement reflected how I run my addons, which I feel has saved me a lot of headaches over the last two years. However, as apparently you found it enormously offensive, I have deleted it.
essmene, the information is incorrect - HealBot is *not* compatible with LHC-3. If you install LHC-3, then obviously you're compatible with LHC-3, but that has *nothing* to do with HealBot. Heck, you could say Auctioneer is compatible with LHC-3 if you install LHC-3.
The only thing Healbot tries to do is parse incoming LHC-3 messages. This can work, but doesnt have to work, and the moment the LHC-3 values sent are changed it'll break. It's the attitude Microsoft had for a decade too, "of course we'll import all kind of email formats to Outlook. But don't expect to ever be able to export your emails again, we don't want you to leave for another program - not even for Outlook/Mac".
in other words, I'd like to ask you to remove the note regarding Healbot and maybe replace it with "Healbot attempts to read incoming heals from LHC-3, but chances are this will break any day. Besides that, Healbot does not send outgoing heals in the format LHC-3 requires. The only way this can change is if the Healbot author replaces his proprietary, non-documented format by LibHealComm-3, as LHC-3 will never, ever attempt to reverse engineer Healbot messages".
I just looked at the code (and it wasn't pretty) and I wouldn't actually call it support. More like a hackjob to listen to its communication and it's not picking up all of the info. Only heal starts, no stops. And on multitarget heals it'll only pick up one of the targets.
My biggest WTF though was that there was a bunch of advertising in the downloaded zip and there was also an ad in some of the error messages (commented out, but still) :o
I don't think Healbot should be on that list and I wouldn't recommend using it to my worst enemies :P
EDIT: I removed it from the list. If someone feel that was dumb, spank me and put it up again.
Library setup in a free mod for a hobby game is serious business.
yes it is serious buisness, as blizzard (like sometimes Sun with Java) forgot to add a useful library management. And people like me want to come home - hit one button on any application and know my addons are up to date and will work the the game i am playing. I don't want to sort out 20 dependencies by hand - or handfix stuff.
I really appreciate the hard work people are putting into the addons - especially the really painless working file distribution on wowace.com and the active community around it. It comes to serious business and upset people if a major addon is checked in and released broken - or a sub library. (e.g. sometime ago dogtag breaking PitBull for some reason).
But it usually gets fixed within hours - and not within the next content patch in 1 month.
Right, im registered for the callback for healing starting, some of the names of players being healed are sometimes name-server or sometimes name, and im expecting only name-server so this becomes a problem, is there a reason why the server isnt being sent?