Just a little suggestion - or maybe not so little. It would be nice if you could get a "humanized" title for each of the sets. This would ease the use of PT in addons that display such titles for the user to choose or whatever the addon does. I know there are a lot of sets. So perhaps it's a bit too much to ask for. But it would encourage addons to use the same titles for the sets when displaying them to the user. Depending on ambition level there could be both a short and long title. And then comes the translation... hmm.. no small task indeed.
On a related note. I notice on SVN that there are a lot of updates to PT. Are these mostly item additions/corrections in existing sets? Or do the sets change fairly often too? Most importantly, are sets ever removed entirely?
Just a little suggestion - or maybe not so little. It would be nice if you could get a "humanized" title for each of the sets. This would ease the use of PT in addons that display such titles for the user to choose or whatever the addon does. I know there are a lot of sets. So perhaps it's a bit too much to ask for. But it would encourage addons to use the same titles for the sets when displaying them to the user. Depending on ambition level there could be both a short and long title. And then comes the translation... hmm.. no small task indeed.
Hrm.. well, the current ones are meant to be relatively 'humanized', minus the period delimiters. Get rid of those and you've got a pretty coherent and readable categorization (regrettably minus localization). see the baggins set picker for a decent example.
On a related note. I notice on SVN that there are a lot of updates to PT. Are these mostly item additions/corrections in existing sets? Or do the sets change fairly often too? Most importantly, are sets ever removed entirely?
Over the past week I've done some changes to the core, for which there were a number of commits. But for the most part, yeah, there'll be a commit every couple of days to update the wowhead-mined sets, most notably InstanceLoot sets. A set will pretty much never be deleted.
Quote from Moggar »
Since the modularisation of PT3, I can no longer see the rep part in PT3Browser, where did it go?
PT3Browser still needs updated to work with the LoD stuff as well as a couple other recent changes. Likely that your reputation module was not loaded as of when your PT3Browser menu was generated.
So the question is: why exactly do you need to know which things are "scrolls" or "potions" as opposed to items that buff me in some way?
Because the sets are not only used by the user of an item as Autobar-thinking is assuming. As a more basic example my bags of my AH/bank char don't care for effects as much as they care for item type, value and so on. If I want some quick money by selling some bank stock then sets by effect don't allow me to pinpoint the more valuable types of items.
Potions grouped together is especially interesting to have after grind-crafting for discoveries. Collecting together pots from various byeffect sets seems also like much of a pain.
I'm sure there would be many more concrete examples that one could come up with.
I see the reasoning to keep the required maintenance low and (before LoD was introduced) the additional memory cost, just want to prevent this extremely useful set library of becoming a bit too restricted on just one "view of things".
How about a set for "keys"? I am particularly thinking of keys that can go into the keyring. You can't always rely on the item-type for this. Some keys have the item-type Key but still cannot go into the keyring - I don't know what the logic is here.. if any.
That'd be cool, only problem is generation.. I know I don't have all the keys, and http://www.wowhead.com/?items=13 appears to have items that can't go in the keyring. I'll get it started with what I've got.
That'd be cool, only problem is generation.. I know I don't have all the keys, and http://www.wowhead.com/?items=13 appears to have items that can't go in the keyring. I'll get it started with what I've got.
Yea, it will take a while to complete it I guess. I have no idea how many keys exist in the game. I will look at what my chars have. Though I don't think I have any rare ones.
I was wondering why AutoBar didn't recognize my Tender Wolf Steaks. I'm guessing it's because the item isn't in Consumable.Food.Buff.Stamina and/or Consumable.Food.Buff.Spirit.
I am wondering, why does instanceloot have so many items that are not specific to the boss or instance. Is it really needed to show that a boss can drop gray/white/ and BoE green/blue/epic items which can drop anywhere in the world? I am using PT3Browser as an addon to look up information about items, and I have it that the instanceloot is "polluted" with items that are not specific to that boss.
Is there a special reason for this, or could this be "fixed"?
I am wondering, why does instanceloot have so many items that are not specific to the boss or instance. Is it really needed to show that a boss can drop gray/white/ and BoE green/blue/epic items which can drop anywhere in the world? I am using PT3Browser as an addon to look up information about items, and I have it that the instanceloot is "polluted" with items that are not specific to that boss.
Is there a special reason for this, or could this be "fixed"?
The PT3 set is rather fully populated so that it can be used for other purposes than just looking up boss drops -- if someone wants to profile the amount of netherweave that drops from bosses, then good for them. If you want to get rid of the junk items, use Cartographer_InstanceLoot, which provides filters for quality and droprate.
The problem with cartographer instanceloot is that is does not work properly for me, because I do not have the looknfeel module enabled (and I dont want to enable it). Thanks for your reaction though.
In PeriodicTable-3.0-InstanceLoot, I believe the hierarchy string "Sunken Temple" is incorrect and should instead be "The Temple of Atal'Hakkar", since I get complaints from PeriodicTable that, for example, "InstanceLoot.The Temple of Atal'Hakkar.Kazkaz the Unholy" doesn't exist.
Thanks for adding "Misc.Key". I checked my chars, but they have nothing you haven't listed. If anyone else know of other keys (that can go in the keyring), please do share. :)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
"...eriodicTable-3.0\\PeriodicTable-3.0-AllData\\PeriodicTable-3.0-AllData.lua:1139: '}' expected (to close '{' at line 12) near ']'"
This did not occur with the prior r30064 & earlier.
On a related note. I notice on SVN that there are a lot of updates to PT. Are these mostly item additions/corrections in existing sets? Or do the sets change fairly often too? Most importantly, are sets ever removed entirely?
Over the past week I've done some changes to the core, for which there were a number of commits. But for the most part, yeah, there'll be a commit every couple of days to update the wowhead-mined sets, most notably InstanceLoot sets. A set will pretty much never be deleted.PT3Browser still needs updated to work with the LoD stuff as well as a couple other recent changes. Likely that your reputation module was not loaded as of when your PT3Browser menu was generated.
Item ID: 21519
Should probably go in
Consumable.Buff.Spirit.Target
Because the sets are not only used by the user of an item as Autobar-thinking is assuming. As a more basic example my bags of my AH/bank char don't care for effects as much as they care for item type, value and so on. If I want some quick money by selling some bank stock then sets by effect don't allow me to pinpoint the more valuable types of items.
Potions grouped together is especially interesting to have after grind-crafting for discoveries. Collecting together pots from various byeffect sets seems also like much of a pain.
I'm sure there would be many more concrete examples that one could come up with.
I see the reasoning to keep the required maintenance low and (before LoD was introduced) the additional memory cost, just want to prevent this extremely useful set library of becoming a bit too restricted on just one "view of things".
Yea, it will take a while to complete it I guess. I have no idea how many keys exist in the game. I will look at what my chars have. Though I don't think I have any rare ones.
http://wow.allakhazam.com/db/item.html?witem=18045
Is this the correct place to report stuff like this ?
Is there a special reason for this, or could this be "fixed"?
I guess PT3 wasn't 'done' when it was released. :(
Time to try to figure out what I need to change to get GarbageFu working again. :(
I've committed a fix for GarbageFu; although I didn't test it in context (with Auctioneer loaded), it should work just fine.