Now you should have a folder with the data.lua file in it (somewhere other than in your WoW folders). You know it is an SVN file because it has a green checkmark on it (up to date) or a red exclamation point on it (it differs from the checked out version) and there is a ".svn" folder inside the folder as well.
1) Before making changes right click on data.lua and select "SVN Update" which copies the latest changes to your file.
2) Make your changes.
3) Right click on data.lua and select "TortoiseSVN/Diff", this brings up a diff of your changes. Verify that you made the changes you intended to and nothing else.
4) Right click on data.lua and select "SVN Commit" which copies your changes up to wowace for everyone to see & use.
5) The commit requires a log message with a list of changes and the mod name on the first line:
PeriodicTable-3.0:
- Small Pumpkin 4656:61
- Roasted Moonglaze Tenderloin 24105:61
- Healing Herb 961:61
- Savoury Deviate Delight 6657 added to Consumable.Food.Buff.Other
6) Wait for someone to run compresssplit or do it yourself & check in the changed lib files it creates.
7) Use WoWAceUpdater or something to check out the latest version which will now have your changes in it.
I would also recommend joining the wowace IRC channel b4 you check in & monitoring it for a bit to see if your changes were catastrophic, especially the first time you do it. It is also a good place to get help.
We can work on these directions till they are easily comprehensible & maybe add a SVN for PeriodicTable page to the wiki.
I also noticed that just changing data.lua doesn't seem to have actually changed any of the in-game data. It seems there's something you have to do to 'compress' the data because the compressed data is what is actually used in-game. How do I do that?
I also noticed that just changing data.lua doesn't seem to have actually changed any of the in-game data. It seems there's something you have to do to 'compress' the data because the compressed data is what is actually used in-game. How do I do that?
Yeah, this is why I haven't fixed Netherspite's loot showing up in Lady Vashj's loot table yet. :P
I also noticed that just changing data.lua doesn't seem to have actually changed any of the in-game data. It seems there's something you have to do to 'compress' the data because the compressed data is what is actually used in-game. How do I do that?
Yeah, this is why I haven't fixed Netherspite's loot showing up in Lady Vashj's loot table yet. :P
There is a LUA script to run that generates all the other data files with compressed values. I haven't been able to run it locally on my PC even though the LUA interpreter is installed. I've made myself a little Perl script that does the compression for some of them and I use that whenever I need to add stuff to my local copy. Not the best way to do things since it need to be manually redone every time there is an update to PT3.
Can someone explain how to run the script locally?
My limited understanding gleaned the words "from the console" when it came to needing to compress the data. I assumed that was something you could actually do in WoW itself, but I really wouldn't know.
I'd be interested in learning, but whenever I find what I think are instructions, they never really seem to be in a language I understand... And here I was, thinking I was a quick learner. Thanks to Toadkiller's help, I think I understand everything except for the 'compressing' bit.
Right, the compress thing. I updated the instructions to mention this. I think I used a batch file back on XP but I just do not remember anymore.
The good news is that if u do check in your changes then the next time someone else compresses & checks in, your changes will become available.
On Vista I added a startup script to PowerShell that just automatically does it, so I can just run it from the start menu:
C:\Users\Dirk\Documents\wow2.00\dev\PeriodicTable-3.0\lua5.1.exe C:\Users\Dirk\Documents\wow2.00\dev\PeriodicTable-3.0\compresssplit.lua
One day when I am less lazy I should figure out the signed scripting facility they have.
If someone can post their XP instructions we should have enough info to put up the wiki page.
I have a compresssplit.bat file that contains the line:
lua5.1.exe compresssplit.lua
but I dunno if thats what I had working on XP or if its some hack while trying to get a bat file working on Vista.
I reverted your changes duplicating some food buffs under Consumable.Buff.*, as well as the oil buffs.
Technically they could be placed there, but the whole Consumable.Buff.* section was originally created for AutoBar to simplify applying buffs. So currently Consumable.Buff is for buffs applyable at any time including combat to the caster or sometimes the casters target. The food buff section is for stuff u eat when not in combat.
This means no food buffs there for now & no oil either. These are all available under other sets already.
Now a consolidation could be made to add other targets / types to the current .self & .target
So .weapon .shield .chest
Also .food can be used to merge in all of the food buffs.
The flasks remain for now but need to be split out into .flask
Miss clicking on a flask is a hideously costly thing so AutoBar needs to be able to split them out.
This is a lot of work so the question is why you need it done?
Speaking of flasks, it seems like a number of them are missing from the Consumable.Buff.* section. Specifically, I know that Flask of Relentless Assault and the Unstable Flasks aren't there. After some quick investigation, I also see that Haste Potion and most of the discovered flasks and Shattrath flasks are missing.
Do we still run the data miner for PT3? These seem like pretty big omissions.
P.S. I'll return later with item ids for the things I know are missing.
I have committed the changes to the dataminer, and also regenerated the data. I have carefully checked each changes to the data, and I'm pretty sure I did not completly break anything.
As a result, a lot of loot tables have been cleaned from InstanceLoot and InstanceLootHeroic, as wowhead removed the world drops from their boss loot tables. The Poisons related tables have been generated. The "Tradeskill.Gem.Cut" datamining module does not use a fixed table of raw gems, so a lot of new gems have been added to it.
I also manually added Cookie's Jumbo Gumbo to the relevant tables.
By "Combo" do you mean Flasks? Or do you mean both Battle and Guardian elixirs together in one table?
It is possible to mine this data directly from Wowhead. I've added the handler to dataminer, but I haven't checked anything in.
I also took the liberty of modding dataminer to accept a parameter indicating which PT3 set to mine. Updating the all 1400 or so sets is a bit unkind toward wowhead if you ask me.
By "Combo" do you mean Flasks? ... It is possible to mine this data directly from Wowhead. I've added the handler to dataminer, but I haven't checked anything in...
Yes, so these are the 3 elixer types, "Guardian", "Battle" & "Both Guardian & Battle". Mmm maybe "Both" is a better word. At any rate the "flask" set is complete as is right now.
I called it combo since I do not trust Blizzard to keep flasks as the only combo items. Since it is still recent we could change the name to "Both".
The sets could be mined or they can be cobbled together from existing sets as a multiset. If they are accurately mineable that is a better way.
Yes, so these are the 3 elixer types, "Guardian", "Battle" & "Both Guardian & Battle". Mmm maybe "Both" is a better word. At any rate the "flask" set is complete as is right now.
I called it combo since I do not trust Blizzard to keep flasks as the only combo items. Since it is still recent we could change the name to "Both".
The sets could be mined or they can be cobbled together from existing sets as a multiset. If they are accurately mineable that is a better way.
Okay I've updated PT3 with these changes. FYI Wowhead supports searching on Effect Text. Since Battle Elixir and Guardian Elixir is in the effect text for elixirs, it's easy to search.
Okay I've updated PT3 with these changes. FYI Wowhead supports searching on Effect Text. Since Battle Elixir and Guardian Elixir is in the effect text for elixirs, it's easy to search.
Nice, I am going to add 3 buttons for this to the AutoBar alpha then. Can you filter out the Flaskataur's rubbish? It was PTR only but wowhead hasn't removed it...
To clear up lingering confusion & summarize:
Consumable.Buff Type
gives you any item with either a battle or guardian or both in one effect.
Consumable.Buff Type.Battle
gives you any item with only a battle effect.
Consumable.Buff Type.Both
gives you any item with both a battle and a guardian effect. (aka flasks at the moment)
Consumable.Buff Type.Guardian
gives you any item with only a guardian effect.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Well you do need to know basically how to check stuff out & in & merge if necessary in SVN.
From: http://www.wowace.com/wiki/SVN_For_Beginners
1) Read and sign the SVN Rules: http://www.wowace.com/wiki/SVN_Rules
2) Install Tortoise SVN: http://tortoisesvn.tigris.org/
3) Get an SVN account: http://www.wowace.com/wiki/SVN_Rules#Getting_an_Account
4) Folllow "Checkout your addon from the SVN" to check out either all of PT3 or just data.lua
Now you should have a folder with the data.lua file in it (somewhere other than in your WoW folders). You know it is an SVN file because it has a green checkmark on it (up to date) or a red exclamation point on it (it differs from the checked out version) and there is a ".svn" folder inside the folder as well.
1) Before making changes right click on data.lua and select "SVN Update" which copies the latest changes to your file.
2) Make your changes.
3) Right click on data.lua and select "TortoiseSVN/Diff", this brings up a diff of your changes. Verify that you made the changes you intended to and nothing else.
4) Right click on data.lua and select "SVN Commit" which copies your changes up to wowace for everyone to see & use.
5) The commit requires a log message with a list of changes and the mod name on the first line:
PeriodicTable-3.0:
- Small Pumpkin 4656:61
- Roasted Moonglaze Tenderloin 24105:61
- Healing Herb 961:61
- Savoury Deviate Delight 6657 added to Consumable.Food.Buff.Other
6) Wait for someone to run compresssplit or do it yourself & check in the changed lib files it creates.
7) Use WoWAceUpdater or something to check out the latest version which will now have your changes in it.
I would also recommend joining the wowace IRC channel b4 you check in & monitoring it for a bit to see if your changes were catastrophic, especially the first time you do it. It is also a good place to get help.
We can work on these directions till they are easily comprehensible & maybe add a SVN for PeriodicTable page to the wiki.
Yeah, this is why I haven't fixed Netherspite's loot showing up in Lady Vashj's loot table yet. :P
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThere is a LUA script to run that generates all the other data files with compressed values. I haven't been able to run it locally on my PC even though the LUA interpreter is installed. I've made myself a little Perl script that does the compression for some of them and I use that whenever I need to add stuff to my local copy. Not the best way to do things since it need to be manually redone every time there is an update to PT3.
Can someone explain how to run the script locally?
Best
I'd be interested in learning, but whenever I find what I think are instructions, they never really seem to be in a language I understand... And here I was, thinking I was a quick learner. Thanks to Toadkiller's help, I think I understand everything except for the 'compressing' bit.
The good news is that if u do check in your changes then the next time someone else compresses & checks in, your changes will become available.
On Vista I added a startup script to PowerShell that just automatically does it, so I can just run it from the start menu:
C:\Users\Dirk\Documents\wow2.00\dev\PeriodicTable-3.0\lua5.1.exe C:\Users\Dirk\Documents\wow2.00\dev\PeriodicTable-3.0\compresssplit.lua
One day when I am less lazy I should figure out the signed scripting facility they have.
If someone can post their XP instructions we should have enough info to put up the wiki page.
I have a compresssplit.bat file that contains the line:
lua5.1.exe compresssplit.lua
but I dunno if thats what I had working on XP or if its some hack while trying to get a bat file working on Vista.
I reverted your changes duplicating some food buffs under Consumable.Buff.*, as well as the oil buffs.
Technically they could be placed there, but the whole Consumable.Buff.* section was originally created for AutoBar to simplify applying buffs. So currently Consumable.Buff is for buffs applyable at any time including combat to the caster or sometimes the casters target. The food buff section is for stuff u eat when not in combat.
This means no food buffs there for now & no oil either. These are all available under other sets already.
Now a consolidation could be made to add other targets / types to the current .self & .target
So .weapon .shield .chest
Also .food can be used to merge in all of the food buffs.
The flasks remain for now but need to be split out into .flask
Miss clicking on a flask is a hideously costly thing so AutoBar needs to be able to split them out.
This is a lot of work so the question is why you need it done?
Do we still run the data miner for PT3? These seem like pretty big omissions.
P.S. I'll return later with item ids for the things I know are missing.
Mmm, I know I do not since few of the AutoBar categories are mineable.
The dataminer is currently completely broken due to internal changes in wowhead response pages.
I started to update it, and will commit a fixed version soon, as well as updated data.
As a result, a lot of loot tables have been cleaned from InstanceLoot and InstanceLootHeroic, as wowhead removed the world drops from their boss loot tables. The Poisons related tables have been generated. The "Tradeskill.Gem.Cut" datamining module does not use a fixed table of raw gems, so a lot of new gems have been added to it.
I also manually added Cookie's Jumbo Gumbo to the relevant tables.
Also added
Consumable.Buff Type.Battle
Consumable.Buff Type.Combo
Consumable.Buff Type.Guardian
The Combo (Flasks) one is complete the other 2 are placeholders mostly.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt is possible to mine this data directly from Wowhead. I've added the handler to dataminer, but I haven't checked anything in.
I also took the liberty of modding dataminer to accept a parameter indicating which PT3 set to mine. Updating the all 1400 or so sets is a bit unkind toward wowhead if you ask me.
Yes, so these are the 3 elixer types, "Guardian", "Battle" & "Both Guardian & Battle". Mmm maybe "Both" is a better word. At any rate the "flask" set is complete as is right now.
I called it combo since I do not trust Blizzard to keep flasks as the only combo items. Since it is still recent we could change the name to "Both".
The sets could be mined or they can be cobbled together from existing sets as a multiset. If they are accurately mineable that is a better way.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI have a question before I do so. Do I need to run pt3lod.bat before committing or just compresssplit.lua?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumShouldn't be necessary. Referencing "Consumable.Buff Type" will give you all itemids from all three groups right?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumOkay I've updated PT3 with these changes. FYI Wowhead supports searching on Effect Text. Since Battle Elixir and Guardian Elixir is in the effect text for elixirs, it's easy to search.
Nice, I am going to add 3 buttons for this to the AutoBar alpha then. Can you filter out the Flaskataur's rubbish? It was PTR only but wowhead hasn't removed it...
To clear up lingering confusion & summarize:
Consumable.Buff Type
gives you any item with either a battle or guardian or both in one effect.
Consumable.Buff Type.Battle
gives you any item with only a battle effect.
Consumable.Buff Type.Both
gives you any item with both a battle and a guardian effect. (aka flasks at the moment)
Consumable.Buff Type.Guardian
gives you any item with only a guardian effect.