Ideally there is a (gui)field that can be used to set a particular group to be initially open & which subsequently tracks the open/close state in Waterfall.
The second argument to :Open is what section to display initially.
For example, with BigWigs' options dialog, I check GetRealZoneText() and GetZoneText() when you open it to see if we have any boss modules for your current zone, and if you do, I set Waterfall to open on the section for those bosses (Options.lua:208).
Is there a way to display table data in the waterfall GUI?
Would TableTopLib work? (Is it compatible with Waterfall?) [Is there TableTopLib guide somewhere?]
I am working on a Suicide Kings (loot distribution) mod. I'd like to be able to display a list of all players in the loot list sorted by roll value. I have the mod to the point of storing the data, but am not sure how to make it display in the GUI or if it is possible.
Everything else in waterfall has been great and pretty easy to figure out. Very excellent mod!
Possibly a bug in Waterfall. One user has a screenshot showing that he selected one option on the left half, and then it tries to show options on the right half for a different option, and as such, ends up seeing no options on the right half. He is using deDE, and this problem happens with the CooldownTimers2 options. Please see the following screenshot.
In that screen, the left side shows that "Gruppen Einstellungen" is selected, but the right side is trying to show options for "Begleiter Cooldowns" (as you can see at the top). Since this is an AceOptions table, I dont see how it could be a problem on the CDT2 side of things, although I did look. Could you double check and let me know if you find anything on the Waterfall side?
I can't reproduce that error on the enUS version so not sure whats going on there, I do notice that there is no obvious error reporting addon installed. Do you know if script errors are enabled in that screenshot? My guess is that an error is happening which is preventing the refresh from happening.
Update: I think i just reproduced it, Selecting the Group Settings option is getting me this error and leaving the title from the previous page
[2007/09/08 11:07:11-1182-x10]: CooldownTimers2\Options.lua:530: attempt to index field '?' (a nil value)
Waterfall-1.0-47874:2921: in function `Refresh'
Waterfall-1.0-47874:670: in function `AddControl'
Waterfall-1.0-47874:1132: in function `FeedAceOptionsTable'
Waterfall-1.0-47874:408: in function `children'
Waterfall-1.0-47874:1564: in function `ChangePane'
Waterfall-1.0-47874:3690: in function `SetSelected'
Waterfall-1.0-47874:3795: in function <...CooldownTimers2\Libs\Waterfall-1.0\Waterfall-1.0.lua:3793>
Hi! Today I was looking at the files in some addons and noticed that Waterfall-1.0's TOC calls individual Ace2 library LUAs directly. It would be interesting, for those of us who use WAU (not my case though) if this were replaced by a single call to "embeds.xml", as other addons do. What do you think?
[2007/09/18 04:37:21-121-x1]: Waterfall-1.0-49207 (Waterfall-1.0):301: bad argument #1 to 'pairs' (table expected, got function)
Waterfall-1.0-49207 (Waterfall-1.0):301: in function <...AddOns\Waterfall-1.0\Waterfall-1.0\Waterfall-1.0.lua:282>
Waterfall-1.0-49207 (Waterfall-1.0):354: in function <...AddOns\Waterfall-1.0\Waterfall-1.0\Waterfall-1.0.lua:282>
Waterfall-1.0-49207 (Waterfall-1.0):354: in function `contentsFunc'
Waterfall-1.0-49207 (Waterfall-1.0):3834: in function `Refresh'
Waterfall-1.0-49207 (Waterfall-1.0):4028: in function `SetContent'
Waterfall-1.0-49207 (Waterfall-1.0):1635: in function `SetTree'
Waterfall-1.0-49207 (Waterfall-1.0):468: in function <...AddOns\Waterfall-1.0\Waterfall-1.0\Waterfall-1.0.lua:430>
<in C code>: in function `Open'
Niagara-1.0 r46206\Niagara.lua:223: in function `OnClick'
FuBarPlugin-2.0-48629:944: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:941>
FuBar-49053\FuBar.lua:1157: in function <Interface\AddOns\FuBar\FuBar.lua:1155>
---
[2007/09/18 14:44:16-2075-x1]: Waterfall-1.0-49207 (Omen):301: bad argument #1 to 'pairs' (table expected, got function)
Waterfall-1.0-49207 (Omen):301: in function <...ace\AddOns\Omen\Libs\Waterfall-1.0\Waterfall-1.0.lua:282>
Waterfall-1.0-49207 (Omen):354: in function <...ace\AddOns\Omen\Libs\Waterfall-1.0\Waterfall-1.0.lua:282>
Waterfall-1.0-49207 (Omen):354: in function <...ace\AddOns\Omen\Libs\Waterfall-1.0\Waterfall-1.0.lua:282>
Waterfall-1.0-49207 (Omen):354: in function `contentsFunc'
Waterfall-1.0-49207 (Omen):3834: in function `Refresh'
Waterfall-1.0-49207 (Omen):4028: in function `SetContent'
Waterfall-1.0-49207 (Omen):1635: in function `SetTree'
Waterfall-1.0-49207 (Omen):468: in function `Open'
Niagara-1.0 r46206\Niagara.lua:223: in function `OnClick'
FuBarPlugin-2.0-48629 (BugSack):944: in function <...Ons\BugSack\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:941>
FuBar-49053\FuBar.lua:1157: in function <Interface\AddOns\FuBar\FuBar.lua:1155>
Getting the same error as Otto and nothing is displaying in the Niagara panel.
---------------------------------------------------
Tried reverting to the previous revision, but no luck. Is this an incompatibility issue with the new fubar?
Error: bad argument #1 to 'pairs' (table expected, got function)
AddOn: Waterfall-1.0
File: Waterfall-1.0.lua
Line: 301
Count: 1
Started receiving this error after installing Niagara last night. I'm not entirely sure what it means, but any help would be greatly appreciated in alleviating the problem.
Edit: Oh, as a clarification. This error is produced when I click on the Niagara Fubar button. It opens up the Niagara window, however it's blank. I'd usually file this under Niagara as a bug, however it's Waterfall's code that's causing the error.
Same error as Otto and Enaya, happening in nearly all addons with a Waterfall menu - I've checked Niagara, Omen, Prat, BigWigs, ItemValue. Interestingly, Baggins still works, but it's the only one I've found so far.
ok i just updated my addons getting this error when i try to use niagra this has been happening last few updates causes Niagras page to be blank
[2007/09/19 11:38:18-181-x1]: Waterfall-1.0-49271 (Waterfall-1.0):286: args must be a table: Current Path:.
Waterfall-1.0-49271 (Waterfall-1.0):286: in function `contentsFunc'
Waterfall-1.0-49271 (Waterfall-1.0):3834: in function `Refresh'
Waterfall-1.0-49271 (Waterfall-1.0):4028: in function `SetContent'
Waterfall-1.0-49271 (Waterfall-1.0):1635: in function `SetTree'
Waterfall-1.0-49271 (Waterfall-1.0):468: in function `Open'
Niagara-1.0 r46206\Niagara.lua:223: in function `OnClick'
FuBarPlugin-2.0-48629:944: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:941>
FuBar-49053\FuBar.lua:1157: in function <Interface\AddOns\FuBar\FuBar.lua:1155>
---
Added a columns parameter for the dropdown (shows up with a validated text field with an array of valid values). This gets around the lack of scrolling in the dropdown for dropdowns taller than the screen. Well up to a point at any rate. It is also a nice way to have the popup be a grid of values to select from in some cases.
I've finally tracked down the issue with Niagara, It was manually pulling in PitBulls config table which is now incompatible with Waterfall. I've committed a fix to Niagara and all should be working again.
No idea where this is coming from, I've had a few errors with Prat involved.
[2007/09/19 09:16:30-29-x1]: Waterfall-1.0-49271 (Automaton):286: args must be a table: Current Path:.
Waterfall-1.0-49271 (Automaton):286: in function `contentsFunc'
Waterfall-1.0-49271 (Automaton):3834: in function `Refresh'
Waterfall-1.0-49271 (Automaton):4028: in function `SetContent'
Waterfall-1.0-49271 (Automaton):1635: in function `SetTree'
Waterfall-1.0-49271 (Automaton):468: in function <...ddOns\Automaton\Libs\Waterfall-1.0\Waterfall-1.0.lua:430>
<in C code>: in function `Open'
TunnelVision-0.4\Core.lua:245: in function `OnClick'
FuBarPlugin-2.0-48629 (Prat):944: in function <...AddOns\Prat\libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:941>
FuBar-49053\FuBar.lua:1157: in function <Interface\AddOns\FuBar\FuBar.lua:1155>
---
new one right after, I think I'll try logging in then out. BTW this one came when I tried to open Niagra.
[2007/09/19 09:29:08-29-x1]: Waterfall-1.0-49271 (Automaton):286: args must be a table: Current Path:.
Waterfall-1.0-49271 (Automaton):286: in function `contentsFunc'
Waterfall-1.0-49271 (Automaton):3834: in function `Refresh'
Waterfall-1.0-49271 (Automaton):4028: in function `SetContent'
Waterfall-1.0-49271 (Automaton):1635: in function `SetTree'
Waterfall-1.0-49271 (Automaton):468: in function <...ddOns\Automaton\Libs\Waterfall-1.0\Waterfall-1.0.lua:430>
<in C code>: in function `Open'
Niagara-1.0 r46206\Niagara.lua:105: in function `func'
Dewdrop-2.0-48630 (Prat):721: in function <...terface\AddOns\Prat\libs\Dewdrop-2.0\Dewdrop-2.0.lua:660>
I added a dragLink item. It lets you drag items from bags & inventory & spells from your spell book or action bar. Untested is dragging a macro from your macros, certainly this has no icon feedback yet.
It is not finished yet but pretty usable now with both item & spell dragging supported with icon updates etc (spell icons only if BabbleSpell is kicking around). BabbleSpell can be dropped some fine day when Blizzard allows lookup of spell textures using spell name instead of only spellbook index.
Still ToDo for this:
1) Drag & drop rearranging of their order if inside a group (in the tree section).
2) Perhaps a small icon representation if they are in the tree section.
going to try setting this up again as last time i couldnt figure it out - was around the time wowace crashed and the api documentation didnt exist (still sort of doesnt)
i've created a dropdown - figured out that it needs string (not numeric) "keys" to work but i can't figure out how to have a "label" for the dropdown? ie in the first post on this thread the screen shot shows a dropdown with the text "Color threshold", how do i add that? via :AddControl() - i don't have an aceoptions table.
does anyone have any documentation for :AddControl()
can you feed an aceoptions table into the tree at any point? eg i need to add the basic profile change stuff in there - under dewdrop i just feed in a basic aceoptions table and it gets added to the bottom of my menu (or where ever i fed it in)
You can feed an options table in, but you will have to do the tree for it yourself.
waterfall:FeedAceOptionsTable(options, path, levels) inside of a contents function will feed the controls for the table.
e.g waterfall:FeedAceOptionsTable(self.opts, "Profile", 2) to feed self.opts.args.Profile getting controls 2 levels deep
The way to get a label for a dropdown is to add a label control before it.
There isnt really any documentation for the Base API as its more a foundation for the options table support than anything.
Honestly if you're going to be starting a GUI from scratch it would be better to look into AceGUI-3.0.
I havent got the API docs for that written yet but there will be some on the way, if you want an example you can look at /wowace/branches/Ace3/Beta/tests/AceGUITest/"" target="" data-ensure-absolute>AceGUITest. I'll be on irc over the weekend if you want some hints for getting started.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
The second argument to :Open is what section to display initially.
For example, with BigWigs' options dialog, I check GetRealZoneText() and GetZoneText() when you open it to see if we have any boss modules for your current zone, and if you do, I set Waterfall to open on the section for those bosses (Options.lua:208).
Would TableTopLib work? (Is it compatible with Waterfall?) [Is there TableTopLib guide somewhere?]
I am working on a Suicide Kings (loot distribution) mod. I'd like to be able to display a list of all players in the loot list sorted by roll value. I have the mod to the point of storing the data, but am not sure how to make it display in the GUI or if it is possible.
Everything else in waterfall has been great and pretty easy to figure out. Very excellent mod!
http://img293.imageshack.us/img293/8686/wowscrnshot090407160641oi5.jpg
In that screen, the left side shows that "Gruppen Einstellungen" is selected, but the right side is trying to show options for "Begleiter Cooldowns" (as you can see at the top). Since this is an AceOptions table, I dont see how it could be a problem on the CDT2 side of things, although I did look. Could you double check and let me know if you find anything on the Waterfall side?
Update: I think i just reproduced it, Selecting the Group Settings option is getting me this error and leaving the title from the previous page
[2007/09/08 11:07:11-1182-x10]: CooldownTimers2\Options.lua:530: attempt to index field '?' (a nil value)
Waterfall-1.0-47874:2921: in function `Refresh'
Waterfall-1.0-47874:670: in function `AddControl'
Waterfall-1.0-47874:1132: in function `FeedAceOptionsTable'
Waterfall-1.0-47874:408: in function `children'
Waterfall-1.0-47874:1564: in function `ChangePane'
Waterfall-1.0-47874:3690: in function `SetSelected'
Waterfall-1.0-47874:3795: in function <...CooldownTimers2\Libs\Waterfall-1.0\Waterfall-1.0.lua:3793>
---------------------------------------------------
Tried reverting to the previous revision, but no luck. Is this an incompatibility issue with the new fubar?
Started receiving this error after installing Niagara last night. I'm not entirely sure what it means, but any help would be greatly appreciated in alleviating the problem.
Edit: Oh, as a clarification. This error is produced when I click on the Niagara Fubar button. It opens up the Niagara window, however it's blank. I'd usually file this under Niagara as a bug, however it's Waterfall's code that's causing the error.
Added a columns parameter for the dropdown (shows up with a validated text field with an array of valid values). This gets around the lack of scrolling in the dropdown for dropdowns taller than the screen. Well up to a point at any rate. It is also a nice way to have the popup be a grid of values to select from in some cases.
I've finally tracked down the issue with Niagara, It was manually pulling in PitBulls config table which is now incompatible with Waterfall. I've committed a fix to Niagara and all should be working again.
[2007/09/19 09:16:30-29-x1]: Waterfall-1.0-49271 (Automaton):286: args must be a table: Current Path:.
Waterfall-1.0-49271 (Automaton):286: in function `contentsFunc'
Waterfall-1.0-49271 (Automaton):3834: in function `Refresh'
Waterfall-1.0-49271 (Automaton):4028: in function `SetContent'
Waterfall-1.0-49271 (Automaton):1635: in function `SetTree'
Waterfall-1.0-49271 (Automaton):468: in function <...ddOns\Automaton\Libs\Waterfall-1.0\Waterfall-1.0.lua:430>
<in C code>: in function `Open'
TunnelVision-0.4\Core.lua:245: in function `OnClick'
FuBarPlugin-2.0-48629 (Prat):944: in function <...AddOns\Prat\libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:941>
FuBar-49053\FuBar.lua:1157: in function <Interface\AddOns\FuBar\FuBar.lua:1155>
---
new one right after, I think I'll try logging in then out. BTW this one came when I tried to open Niagra.
[2007/09/19 09:29:08-29-x1]: Waterfall-1.0-49271 (Automaton):286: args must be a table: Current Path:.
Waterfall-1.0-49271 (Automaton):286: in function `contentsFunc'
Waterfall-1.0-49271 (Automaton):3834: in function `Refresh'
Waterfall-1.0-49271 (Automaton):4028: in function `SetContent'
Waterfall-1.0-49271 (Automaton):1635: in function `SetTree'
Waterfall-1.0-49271 (Automaton):468: in function <...ddOns\Automaton\Libs\Waterfall-1.0\Waterfall-1.0.lua:430>
<in C code>: in function `Open'
Niagara-1.0 r46206\Niagara.lua:105: in function `func'
Dewdrop-2.0-48630 (Prat):721: in function <...terface\AddOns\Prat\libs\Dewdrop-2.0\Dewdrop-2.0.lua:660>
I added a dragLink item. It lets you drag items from bags & inventory & spells from your spell book or action bar. Untested is dragging a macro from your macros, certainly this has no icon feedback yet.
It is not finished yet but pretty usable now with both item & spell dragging supported with icon updates etc (spell icons only if BabbleSpell is kicking around). BabbleSpell can be dropped some fine day when Blizzard allows lookup of spell textures using spell name instead of only spellbook index.
Still ToDo for this:
1) Drag & drop rearranging of their order if inside a group (in the tree section).
2) Perhaps a small icon representation if they are in the tree section.
i've created a dropdown - figured out that it needs string (not numeric) "keys" to work but i can't figure out how to have a "label" for the dropdown? ie in the first post on this thread the screen shot shows a dropdown with the text "Color threshold", how do i add that? via :AddControl() - i don't have an aceoptions table.
does anyone have any documentation for :AddControl()
can you feed an aceoptions table into the tree at any point? eg i need to add the basic profile change stuff in there - under dewdrop i just feed in a basic aceoptions table and it gets added to the bottom of my menu (or where ever i fed it in)
waterfall:FeedAceOptionsTable(options, path, levels) inside of a contents function will feed the controls for the table.
e.g waterfall:FeedAceOptionsTable(self.opts, "Profile", 2) to feed self.opts.args.Profile getting controls 2 levels deep
The way to get a label for a dropdown is to add a label control before it.
There isnt really any documentation for the Base API as its more a foundation for the options table support than anything.
Honestly if you're going to be starting a GUI from scratch it would be better to look into AceGUI-3.0.
I havent got the API docs for that written yet but there will be some on the way, if you want an example you can look at /wowace/branches/Ace3/Beta/tests/AceGUITest/"" target="" data-ensure-absolute>AceGUITest. I'll be on irc over the weekend if you want some hints for getting started.