Authors CurseForge

cheers, worked a treat changing to getFunc and setFunc.

I was following the examples in the API docs (which uses "get" and "set"), i had looked at the source, but my LUA knowledge is fairly new, and i only got the basics about what type takes what parameters.

suggestion: can you add color support for labels?
i've made the following changes to a local copy and it seems to work (diff file).

--- Waterfall-1.0.lua   2007-03-06 12:54:46.390625000 +0000
+++ Waterfall-1.0_withcolor.lua  2007-03-06 13:04:46.125000000 +0000
@@ -472,6 +472,9 @@
        control = getObj(WaterfallLabel)
        setCommonAttributes(control,info)
        control.justifyH = info.justifyH
+        control.r = info.r
+        control.g = info.g
+        control.b = info.b
        control:Refresh()
    elseif info.type == "button" then
        control = getObj(WaterfallButton)
@@ -1759,6 +1762,7 @@
        self.frame:SetScript("OnUpdate", labelFixWidth)
    end
    self.text:SetJustifyH(self.justifyH or "LEFT")
+    self.text:SetTextColor(self.r or 1, self.g or 1, self.b or 1)
 end
 -----------------
 -- ColorSwatch Class --

i'm really liking this library!

thanks,
mark

i've been working a lot with waterfall for last few days.

i've added a new type, a hybrid of a button and a label called "linklabel" that you can click on (calls linkFunc with linkArg's), has tooltips and color support.

i'd like to contribute it to the library, but don't know the best way to go about it.

example screenshot here.

mark

There's bit of a problem with long names, they tend to get cut off. One way to get around that would be to anchor the names to left side and actual controls to right side so that resizing the window would show more of the name. I'll post a screenshot if needed.

markf: easiest way to contribute would be pastey a diff of the changes and i'll have a look at it. Its good to see someone using the API and if you need help with it I'm around on IRC reasonably often.

Iceroth: Yeah i've noticed this as well, no screenshot in needed. I'm going to look into other ways of laying out the window so it doesnt happen

ok, here's the diff file for download
and here's the full file with changes in.

it's got the label color changes i posted earlier too in it.

cheers,
mark

k, those changes are in.

thanks. if i dream up anymore types i'll let you know

Posted this in the Niagara thread, but apparently it's a Waterfall feature request, so:

Would it be possible to expand categories/sections when clicking (either single or double or both) on the category title? The +/- buttons are pretty tiny at my resolution and UI scale, and it's kind of a pain clicking them when I'm in a hurry to change something. :P

Small bug which is an annoyance.

This seems to happen with Dewdrop as well as Waterfall.

In a list of toggle objects which extend into a scroll frame, when a value is toggled Waterfall and Dewdrop reset the view to the top of the list. An example is the Filter lists in Antagonist which contain a large table of spells which can be toggled to be shown when detected. Download Antagonist and see for yourself, my explanation isn't that great.


Thanks

and a question from me.

how do i expand by default a tree built options window?
no matter where i put isOpen to true, my window always starts with all categories in the left pane closed.

thanks,
mark

There is a small "bug":

When a 'range' is disabled, its "set" function or handler is still called when the slider is displayed.

markf: i might have broken isOpen when i was fixing the tree to take dynamic ace options tables, i'll look into whats going on there.

I'll also look at the range thing, should be an easy fix for that

It would be really cool if someone used waterfall to make a khaos type configuration system for all ace addons. Khaos was by far the best mod in Cosmos and ace has needed this kind of configuration mod for a long time.

With waterfall I think it would be doable.

Celandro : take a look at Niagara

Quote from Nargiddley »

markf: i might have broken isOpen when i was fixing the tree to take dynamic ace options tables, i'll look into whats going on there.

hi, just wondered if you'd had any chance to look at this. it's about the only thing that i am missing from the dynamic loading. thanks.

markf: Just committed a fix for that, its untested but should do the trick. Let me know if its still broken

thanks for the update, the menu opens nicely now by default.

one small problem though, the justification / left border seems to expand as i increase the size of the window. pictures will help explain. all i do is increase the width of the window between these 2 pics:

here's the before image
here's the after image

all labels and set with a 'justifyH' = "LEFT", and this didn't happen before, only seems to be with the new version.

thanks for fixing the expanding menus.

Yeah that was intentional, controls will be centered in the middle window. I can look at an option to turn it off if you want. Or as a workaround for now adding one very wide control will push it to the left.

options to make the main window justify left/center/right would be good.
so a left justification would give the old functionality, center as it is now, and right would be an extra in case anyone wanted it.

currently, i can't hold things (without a wide item workaround) to the left border and the gap is window size dependant.

one other thing i noticed was that scroll bars appear in the left window even when i don't need them on opening the UI. they disappear as soon as i "scroll" (e.g. spin mouse wheel) even though there's only 2 or 3 items in the list and it doesn't need a scroll.