Huh, I didn't even know you could remove abilities from the pet bar. Good to know.
Anyone know how to get pet spell ranks without using the bar, then?
Well, there is a Pet/Demon tab in the spellbook for hunters/warlocks, respectively. A quick search brought me to this page: http://www.wowwiki.com/API_GetSpellName which seems to indicate that you can just pass a bookType of "pet" in, and voila - pet spellbook access! To find valid pet spell IDs (I believe they are separate from player spell IDs), you might find this handy as well: http://www.wowwiki.com/API_HasPetSpells
Please could you add support for Soulshatter (Warlock). Tooltip description: "Reduces threat by 50% for all enemies within 50 yards", it is resistable (if that is useful) and has an entry in the combat log for each mob the spell affected.
Threat-1.0 maintains individual threat lists for each target as much as possible, separated by name. (Note that it is not always possible to discern which target is which, due to limitations of the WoW interface.)
I have 2 suggestions for you, 1 should be easy to implement(if you find it usefull), the other is just some loose thoughts :)
In raids, and often in heroics with multiple targets, one set up raid symbols. Would it be possible to send this information + unit name to more accurate distinguish units?
GetRaidTargetIndex("unit") - Get the raid target index assigned to a unit.
Hardly ever changes during combat.
Might be a problem for AoE, but add the threat(average damage), to all targets with that name, ignoring the raid icon? Not exact science, but as close as one can get?
UnitIsUnit("unit", "otherUnit") - Determine if two units are the same unit.
Can't remember the name, but had an addon once, that displayed all unique mobs, targeted by the raid, and the raid members targeting them. Might be tricky tracking them when everyone is constantly changing targets, but it's not impossible? Mobs you are in combat with, but not targeted by anyone falls of the grid tho, but they might have had raid icons? ;)
1. isn't really doable because raid icon information doesn't appear in the combat log, and you don't get unit information from the combat log - only a name. This would become a problem for anything that isn't a direct damage recipient. Anything that hits multiple targets (multishot, blade flurry, cleave, sweeping strikes) or any AOE would not be trackable; likewise, DOTs would not be trackable.
2. is a similar problem. The addon you're thinking of is PerfectTargets, and while it works well, you're right, the problem is that any mob not targeted by a raid member becomes unwatchable, which leads to threat discrepancies. Additionally, since there is no unit information available in the combat log, you don't know if "Murloc suffers 50 damage from your Shadow Word: Pain" is the murloc you have targeted, the murloc your tank has targeted, or some murloc off somewhere else who is involved in the fight, but nobody has targeted. Unit IDs associated with damage events would make this problem trivial; the lack of them makes it virtually impossible.
Tracking individual mobs is a very tricky proposition, because there is no good way to know how many mobs you're in combat with, and if you're in combat with Slimy Murloc and another Slimy Murloc adds to the fight, you don't know when they added, what their global or target threat levels are, what (if any) threat wipes or dumps they've been affected by, etc etc.
Surely it's not different from how you get the ranks of a player spell? Or is the problem that you can detect spell rank at cast time for the player but not for the pet since it's only being detected via a combat log event? In which case, no idea!
Im fairly positive Alar does not reset threat. In phase 1 it doesn't reset, the threat from p1 is the deciding factor at who he goes for after rebirth, he then later goes to meteor, drops, and I believe still goes for the highest on his hate list. Which is always ramged I believe from p1 threat.
[2007/06/09 10:14:01-1864-x1]: ...hreat-1.0\Threat-1.0\NPCModules\Karazhan\Illhoof.lua:14: Babble-Boss-2.2: Translation "Kil'rek" does not exist.:
Ace2\AceLibrary\AceLibrary.lua:100: in function `error'
AceLocale-2.2-27198 (Ace2):475: in function <...nterface\AddOns\Ace2\AceLocale-2.2\AceLocale-2.2.lua:473>
AceLocale-2.2-27198 (Ace2):38: in function <...nterface\AddOns\Ace2\AceLocale-2.2\AceLocale-2.2.lua:36>
...hreat-1.0\Threat-1.0\NPCModules\Karazhan\Illhoof.lua:14: in function `v':
Threat-1.0\Threat-1.0\Threat-1.0-Cleanup.lua:20: in main chunk
in the language file of bableboss doesnt exist the 2 german translations for kil'rek and restless skeleton and i dont know how to edit files at the svn so maybe someone of you can add these...
["Kil'rek"] = "Kil'rek",
["Restless Skeleton"] = "Ruheloses Skelett",
same error with Arcane Shroud but i dont no the translation =(
[2007/06/09 11:52:32-1867-x1]: Threat-1.0\Threat-1.0\ThreatBuffsData.lua:45: Babble-Spell-2.2: Translation "Arcane Shroud" does not exist.
Threat-1.0\Threat-1.0\Threat-1.0-Cleanup.lua:38: in main chunk
With the current version (39341), it seems that Threat isn't registering aggro for the Boar Charge ability for the boar hunter's pets. The funny thing is, I could swear it was a few days ago, but while testing today it wasn't registering. I'm using Omen as the front end, and I don't know how the communication works between them and whether it could just be an Omen display error. But anyway, I figured I'd note it so it could be checked.
I'm unsure off-hand exactly how much aggro it generates (in the 3.5-4k range), but it's very significant, so it's handy to have that handled when using a pet tank. Thanks!
Great job so far! I can't wait until I can feel safe in ditching KTM and going with a lightweight Ace2 solution. :)