There seems to be times where we can't set the master target in Threat via Fubar or / commands.
Also, if you disable/enable KTM broadcast it never actually turns on. I don't know if that's the reason master target never gets set.. possibly the way it's supposed to work if it doesn't detect anyone running KTM?
there are no master targets that is a KTM only thing and that is also why omen/threat-1.0 is better cause it does not need it
Maybe another old Verion "Bug" in my Instance Group (don't know which Version they use)
Edit: Threat-1.0-r53189
[2007/10/27 14:10:54-1490-x1]: ...s\Threat-1.0\Threat-1.0\ThreatMobNameTranslation.lua:149: Conflicting translation for Nethervine Inciter in deDE: old is "Hetzer der Netherranke", new is "Ernter der Netherranke".
You're right , someone you met, runs a very old version of threat ( it even rhymes ;) )
Edited (to avoid doubleposting ;) )
I read the "supposed and unofficial "patchnotes for 2.3.0 and had an idea.
Inspect distance has been increased to 30 yards.
When you inspect another player, you can now see their talent choices as well as their equipment.
Could that solve the problem of calculating the threat of people that DONT have ktm or Threat running?
Major problem has been that talents affected threat-calculation.. Now we can see their items AND the talents.
cut'n paste from the omen threat.
there is a bug that the healing threat still continue's while having the insignifigant debuf at bloodboil (Black temple boss)
also think the knockback pushes away to much threat..
shadowpriests threat continue's to rise during phase 2...
seems no one is picking this up.. going to browse trough the code myself for a bit.. if i can find anything i'll post it here
Found something
ThreatBuffsData.lua contains
-- Uncomment this once Insignifigance is in Babble-Spell
-- See [url]http://www.wowhead.com/?spell=40618[/url]
[BS["Insignifigance"]] = function(self)
self:AddDebuffThreatMultiplier(0)
end,
so it must lie in the healing threat handling / global threat
i see this in code in parseHeal30
if not self.ExemptGains[skill] then
local handler = self.abilityThreatMods[skill]
if handler then
threat = handler(self, threat, false, info.isCrit)
end
threat = threat * ThreatLib.ThreatConstants.healing * self:threatMods()
self:_addThreat(threat)
end
The self.threadMods contains the modifier of the debuf.. which is 0.. so the result is 0..
Death Coil however is an ExemptGains.. so it does not follow this line of code..
i cant find where the exemptgains are handled.
will look into it some more tomorrow if i find the time
Quote from Antiarc »
ExemptGains are handled in the class files themselves.
What I need is verification that, indeed, skills that are not normally affected by modifiers are in fact modified in this case.
Quote from ThePopeRope »
Well i guarantee that on the boss Bloodboil (The only boss that gives that agro debuf) there is absolutely no agro gain in second fase (unless you resist the debuff.. never happened sofar)..
the thing why it was noticed at some point was because shadow priest became nr1 on agro meters.. but still the boss does not go for them..
the talent Spirit Weapons now applies on stormstrike and windfury too. [Source]
i recognised that i don't generate as much threat as omen reports so i looked up this file:
the talent Spirit Weapons now applies on stormstrike and windfury too. [Source]
i recognised that i don't generate as much threat as omen reports so i looked up this file:
No, this is not the problem. "Physical" always included SS and WF (just tested it myself to be sure). The problem is this IsTwoPointThree field in Shaman.lua:
self.schoolThreatMods["Physical"] = self.Melee
[...]
self.IsTwoPointThree = ThreatLib.WowVersion >= 2 and ThreatLib.WowMajor >= 3
[...]
local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15
The point is, that self.IsTwoPointThree is set true, AFTER the whole ThreatModifier calculations, so it's still false when the SpiritWeaponsModifier is set, which results in the old 0.15 modifier.
But as I just tested, even moving it before the call to Shaman:Melee doesn't fix it. This field seems always to be false in Shaman:Melee, even if you set it to true earlier. But well, easy fix, just delete the whole 2.3 check. Who needs it anyway?
local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15
==>
local SpiritWeaponsModifier = 0.3
I play a priest and am using Omen/Threat1.0, typically updated twice a week. The meter doesn't seem to take all of my abilities into account when reporting my threat value. I have noticed that our crowd control abilities, buffs, and the draenei racial spell Symbol of Hope won't show up in Omen.
Now, it is my understanding (well, assumptions) that:
1. Buffing does zero threat (but will put you on a mob?s threat list if you buff someone who is in combat).
2. The threat from a crowd control spell is the same amount, regardless of whether or not it is resisted (what that value is, I have no idea).
3. The threat from crowd control spells is additive (if you spam shackle on a mob 10 times, you have ten times the threat from shackling).
4. Symbol of Hope should generate 0.5 points of threat for every 1 point of mana restored to a party member (as a baseline).
5. Mind Control is high threat. Shackle Undead, Silence, and Psychic Scream are much lower threat, comparatively speaking.
6. Silent Resolve reduces threat on all the spells in the holy and discipline tabs of your spellbook (so, Symbol of Hope, Shackle Undead, etc.).
7. Shadow Affinity reduces threat on all the spells on the shadow tab of your spellbook (Mind Control, Psychic Scream, etc.).
What I don't know is how the threat from crowd control abilities is determined (by rank of spell, I assume?). I do not know if CC causes any global threat. And I do not know threat values for any of the spells.
I have been running some rudimentary tests with another priest, having one of us CC-pull a mob and seeing how much weapon damage it takes the other to gain the mob's attention. We haven't gotten very far due to our schedules, but we'll keep working on it. From what we found, our max rank of Shackle Undead seemed to cause about 120 threat.
Is the threat from buffing actually measurable? Are the threat values from CC abilities and Symbol of Hope able to be incorporated?
Antiarc, the links on the first post of this thread to Trac are coming up with errors. Guessing because they switched to Jira? Hope it's ok to report things here still. Two things.
1) There's a very minor typo in the Bloodboil.lua file, it references Void Reaver instead of Bloodboil:
ThreatLib:Debug("Not registering Eject for Void Reaver: translation does not exist for %s", GetLocale())
2) I mentioned this previously, but Reliquary of Souls in Black Temple could use a module to reset global threat after each Essence is defeated. Currently, when you finish coming down the ramp to engage Essence of Suffering, you usually drop out of combat for a few seconds which is enough to reset threat. When Essence of Suffering is defeated, you usually again drop out of combat for a second or two before the Enslaved Souls spawn. This again is usually enough to reset threat. The problem is that after Essence of Desire is defeated, you either never or extremely rarely drop out of combat and global threat is not reset. So when Essence of Anger is engaged, the threat meter is all over the place.
Engage messages:
Essence of Suffering yells: Pain and suffering are all that await you!
Essence of Desire yells: You can have anything you desire... for a price.
Essence of Anger yells: Beware. I live!
I'm trying to adapt the Zul'jin module to Souls. Zul'jin was the first encounter I could think of with multiple phases like Souls, each accompanied by a yell. I need to test it, though.
After some stupid text editor related mistakes, here is the file in UTF-8. If anyone would like to review it, that would be great. Anger engage translations are needed for all locales. The other translations are from the BigWigs module.
Talked with Funky a bit on IRC and he was saying that he never runs into the situation I described above. Although, I am forced to manually reset Omen via Shift+Click each week to clear global threat. I was wondering if anyone else is running into issues going from Desire to Anger? Is your global threat being reset?
Either way, it was fun to make the module, even if it ends up not being needed.
edit: I think I made a typo in the Souls.lua file. Going to re-attach one that should be cleaned up.
The previously untraceable conflict with the mod "Bongos Skinned Map" has been identified as a bug in AceComm-2.0 see http://www.wowace.com/forums/index.php?topic=10102.msg166162#msg166162 for more details. As of this post the bug has not been fixed yet due to only a few people having access to modify Ace2. (I /slaped ckk on irc but he didn't fix it!)
Looking at the current code in Priest.lua for Fade (which is a pain to find true in depth documentation on), and the code is written so that the more points in Shadow Affinity I have, the less effective Fade is:
Here the german translation for Zul'Jin that is missing:
["Got me some new tricks... like me brudda bear...."] = "Sagt 'Hallo' zu Bruder B?r...",
["Dere be no hidin' from da eagle!"] = "Niemand versteckt sich vor dem Adler!",
["Let me introduce you to me new bruddas: fang and claw!"] = "Lernt meine Br?der kennen: Rei?zahn und Klaue!",
["Ya don' have to look to da sky to see da dragonhawk!"] = "Was starrt Ihr in die Luft? Der Drachenfalke steht schon vor Euch!",
Looking at the current code in Priest.lua for Fade (which is a pain to find true in depth documentation on), and the code is written so that the more points in Shadow Affinity I have, the less effective Fade is:
The code is correct. Shadow Affinity reduces your threat by 8, 16 and 25%. As such, any threat reduction effects such as Fade that reduces your threat by a constant fixed value will also be decreased. The talent affects everything across the board, both threat gain and reduction. (i.e Fade becomes less effective).
If you think this is a bug on Blizzard's part, report it to the Bugs forums. Fade is a shadow spell (I think).
Now, it is my understanding (well, assumptions) that:
1. Buffing does zero threat (but will put you on a mob?s threat list if you buff someone who is in combat).
This doesn't match up with my experience, at least for self-buffs. They seems to cause *just* more than zero threat -- less than a nondamaging debuff that shows up with an icon, but more than zero.
Many times we've used a hunter pet to pull a boss, and when the boss is running towards the raid -- that is, before anybody has any threat -- we've seen a priest cast Inner Fire, or a mage cast Ice Armor, etc, and the boss will turn and go right for that person.
This might have changed in the last few months, we haven't needed to do that kind of pull in a while. Any other method of pull causes more threat than that, so we wouldn't have noticed.
-- X-Linking to post on same page -- http://www.wowace.com/forums/index.php?topic=6480.msg154811#msg154811
Post is about the 'Insignifigance' buff in the fight against Bloodboil
and vampiric embrace, death coil etc. still producing threat numbers
in omen while ingame, they are(should) not.
Last week i surpassed our tanks and bloodboil still didn't switch to me,
even after several tankswitches. To my understanding i should have
had aggro under these circumstances. (I know about the 130% threat
'cap'(wrong word, i know) but this shouldn't apply to bloodboils
knockback situations)
Sometimes the threat gets reset twice during the Leo fight in SSC
i believe this sometimes happens when he is whirl winding and then going straight into demon from he will rest when he goes demon and then a several seconds after omen will reset again and this giving inappropriate data till he goes back to elf form. has happened several times now. will look more closely when it happens
(am running the latest version of omen and threat as of this post)
After some stupid text editor related mistakes, here is the file in UTF-8. If anyone would like to review it, that would be great. Anger engage translations are needed for all locales. The other translations are from the BigWigs module.
Talked with Funky a bit on IRC and he was saying that he never runs into the situation I described above. Although, I am forced to manually reset Omen via Shift+Click each week to clear global threat. I was wondering if anyone else is running into issues going from Desire to Anger? Is your global threat being reset?
Either way, it was fun to make the module, even if it ends up not being needed.
edit: I think I made a typo in the Souls.lua file. Going to re-attach one that should be cleaned up.
Also having the problem of not resetting aggro between phases.
Took a quick peek at the Souls.lua file, there's a typo on line 37, it says Souls:RegisterTranslations when it should say Souls:RegisterTranslation :)
I don't know if that would fix it, since I haven't had the chance to try it yet, but I'm gonna do some more testing on our next BT raid on sunday. Hopefully we'll get some answers then :)
there are no master targets that is a KTM only thing and that is also why omen/threat-1.0 is better cause it does not need it
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYou can set a Master Target for the KTM broadcast though. Apparently that broke recently, which is I believe, what he was trying to say in the post.
Edit: Threat-1.0-r53189
[2007/10/27 14:10:54-1490-x1]: ...s\Threat-1.0\Threat-1.0\ThreatMobNameTranslation.lua:149: Conflicting translation for Nethervine Inciter in deDE: old is "Hetzer der Netherranke", new is "Ernter der Netherranke".
Just ignore my Post, if true.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumEdited (to avoid doubleposting ;) )
I read the "supposed and unofficial "patchnotes for 2.3.0 and had an idea.
Could that solve the problem of calculating the threat of people that DONT have ktm or Threat running?
Major problem has been that talents affected threat-calculation.. Now we can see their items AND the talents.
Any update on this topic/bug?
i recognised that i don't generate as much threat as omen reports so i looked up this file:
Threat-1.0\ClassModules\Shaman.lua
so far:
im not sure but i think it should be:
please fix this :)
No, this is not the problem. "Physical" always included SS and WF (just tested it myself to be sure). The problem is this IsTwoPointThree field in Shaman.lua:
The point is, that self.IsTwoPointThree is set true, AFTER the whole ThreatModifier calculations, so it's still false when the SpiritWeaponsModifier is set, which results in the old 0.15 modifier.
But as I just tested, even moving it before the call to Shaman:Melee doesn't fix it. This field seems always to be false in Shaman:Melee, even if you set it to true earlier. But well, easy fix, just delete the whole 2.3 check. Who needs it anyway?
When passing rank as a number to SunderArmor.
local ranknum = tonumber(rank:match("%d+"))should be removed, as GetLinearThreatGuess does type checking.Now, it is my understanding (well, assumptions) that:
1. Buffing does zero threat (but will put you on a mob?s threat list if you buff someone who is in combat).
2. The threat from a crowd control spell is the same amount, regardless of whether or not it is resisted (what that value is, I have no idea).
3. The threat from crowd control spells is additive (if you spam shackle on a mob 10 times, you have ten times the threat from shackling).
4. Symbol of Hope should generate 0.5 points of threat for every 1 point of mana restored to a party member (as a baseline).
5. Mind Control is high threat. Shackle Undead, Silence, and Psychic Scream are much lower threat, comparatively speaking.
6. Silent Resolve reduces threat on all the spells in the holy and discipline tabs of your spellbook (so, Symbol of Hope, Shackle Undead, etc.).
7. Shadow Affinity reduces threat on all the spells on the shadow tab of your spellbook (Mind Control, Psychic Scream, etc.).
What I don't know is how the threat from crowd control abilities is determined (by rank of spell, I assume?). I do not know if CC causes any global threat. And I do not know threat values for any of the spells.
I have been running some rudimentary tests with another priest, having one of us CC-pull a mob and seeing how much weapon damage it takes the other to gain the mob's attention. We haven't gotten very far due to our schedules, but we'll keep working on it. From what we found, our max rank of Shackle Undead seemed to cause about 120 threat.
Is the threat from buffing actually measurable? Are the threat values from CC abilities and Symbol of Hope able to be incorporated?
1) There's a very minor typo in the Bloodboil.lua file, it references Void Reaver instead of Bloodboil:
ThreatLib:Debug("Not registering Eject for Void Reaver: translation does not exist for %s", GetLocale())
2) I mentioned this previously, but Reliquary of Souls in Black Temple could use a module to reset global threat after each Essence is defeated. Currently, when you finish coming down the ramp to engage Essence of Suffering, you usually drop out of combat for a few seconds which is enough to reset threat. When Essence of Suffering is defeated, you usually again drop out of combat for a second or two before the Enslaved Souls spawn. This again is usually enough to reset threat. The problem is that after Essence of Desire is defeated, you either never or extremely rarely drop out of combat and global threat is not reset. So when Essence of Anger is engaged, the threat meter is all over the place.
Engage messages:
Essence of Suffering yells: Pain and suffering are all that await you!
Essence of Desire yells: You can have anything you desire... for a price.
Essence of Anger yells: Beware. I live!
I'm trying to adapt the Zul'jin module to Souls. Zul'jin was the first encounter I could think of with multiple phases like Souls, each accompanied by a yell. I need to test it, though.
Talked with Funky a bit on IRC and he was saying that he never runs into the situation I described above. Although, I am forced to manually reset Omen via Shift+Click each week to clear global threat. I was wondering if anyone else is running into issues going from Desire to Anger? Is your global threat being reset?
Either way, it was fun to make the module, even if it ends up not being needed.
edit: I think I made a typo in the Souls.lua file. Going to re-attach one that should be cleaned up.
local shadowAffinityRanks = {0.92, 0.84, 0.75} ... self.fadedAmount = max(0, threatAmounts["fade"][ranknum] * self.shadowAffinityMod) * self:threatMods()This doesn't seem right to me.
Could someone add this to the library please?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe code is correct. Shadow Affinity reduces your threat by 8, 16 and 25%. As such, any threat reduction effects such as Fade that reduces your threat by a constant fixed value will also be decreased. The talent affects everything across the board, both threat gain and reduction. (i.e Fade becomes less effective).
If you think this is a bug on Blizzard's part, report it to the Bugs forums. Fade is a shadow spell (I think).
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThis doesn't match up with my experience, at least for self-buffs. They seems to cause *just* more than zero threat -- less than a nondamaging debuff that shows up with an icon, but more than zero.
Many times we've used a hunter pet to pull a boss, and when the boss is running towards the raid -- that is, before anybody has any threat -- we've seen a priest cast Inner Fire, or a mage cast Ice Armor, etc, and the boss will turn and go right for that person.
This might have changed in the last few months, we haven't needed to do that kind of pull in a while. Any other method of pull causes more threat than that, so we wouldn't have noticed.
http://www.wowace.com/forums/index.php?topic=6480.msg154811#msg154811
Post is about the 'Insignifigance' buff in the fight against Bloodboil
and vampiric embrace, death coil etc. still producing threat numbers
in omen while ingame, they are(should) not.
Last week i surpassed our tanks and bloodboil still didn't switch to me,
even after several tankswitches. To my understanding i should have
had aggro under these circumstances. (I know about the 130% threat
'cap'(wrong word, i know) but this shouldn't apply to bloodboils
knockback situations)
Any input on this one?
i believe this sometimes happens when he is whirl winding and then going straight into demon from he will rest when he goes demon and then a several seconds after omen will reset again and this giving inappropriate data till he goes back to elf form. has happened several times now. will look more closely when it happens
(am running the latest version of omen and threat as of this post)
Also having the problem of not resetting aggro between phases.
Took a quick peek at the Souls.lua file, there's a typo on line 37, it says Souls:RegisterTranslations when it should say Souls:RegisterTranslation :)
I don't know if that would fix it, since I haven't had the chance to try it yet, but I'm gonna do some more testing on our next BT raid on sunday. Hopefully we'll get some answers then :)
typo is fixed