if info.isCrit then
if self.meleeCritReduction > 0 and element == "Physical" then
threat = threat - self.meleeCritReduction
elseif self.spellCritReduction > 0 and element ~= "Physical" then
threat = threat - self.spellCritReduction
end
end
The variable threat is later on modified with all your threat-mods.
Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.
Any idea how I might get this thing working with Threat-1.0?
if trinket1ID == 30621 or trinket2ID == 30621 then
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
But the thing is that it just doesn't work.
It doesnt work, because the function to detect it doesnt work:
if trinket1ID == 30621 or trinket2ID == 30621 then
DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
It never gets to my added Print statement, but if I change it to:
if trinket1ID == "30621" or trinket2ID == "30621" then
DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
It works, so thats the problem, the item id is a string, not a number.
Thanks a lot it works now. And this trinket btw... oh their god! Went from mere 10% threat reduction up to 26% threat reduction! I know I have to sacrifice a lot when I'm not using a dps-trinket in the other slot, but in aggro capped fights there's no way any dps trinket can give me up to 16% more dps!
...sorry went a bit off-topic there, but thanks again.
I found some strange thing.
The warlock in my raid enslaved a Homonculus earlier in the raid. And a few fights later it still shows up in Omen even tho it has been dead for a long while.
Your Elementals are not your pet's.. thus not calculated; not a bug or glitch - working as intended -- have a day.
Technically they are not my pets but the pets of my totem, true.
But i do not see why this is a reason not to calculate their threat level. A party member is no pet, and is calculated. I do not bother if my Elemental is a pet's pet or a pet.
As a matter of fact, i have an interest in knowing, if i produce more aggro, then my totem or not.
The Totem data is shown in combat log, so it should be possible to calculate it.
Quote from OrionShock »
as for the aggro on the Draenei priest regen, do the testing post the results.
@ Dev & note to self: consider putting a toturial about how to do testing into wikil.
With this kind of remark, NO.
-- have a day
Just changed my mind, do a simple search over all your programm files for "Symbol of Hope" and you will see that Threat lib doesn't even know that spell. Therefore there is no chance, it can consider it.
Noticed these numbers on the Romulo & Julianne Fight. The tank is at -1451 tps, and actually hit -4k tps which is what prompted me to take the screenshot. Is this just an anomaly after a large threat generating move? Also, I believe that he maintained aggro at this point in time. Seems pretty strange, but maybe I'm missing something.
Your Elementals are not your pet's.. thus not calculated; not a bug or glitch - working as intended -- have a day.
Technically they are not my pets but the pets of my totem, true.
But i do not see why this is a reason not to calculate their threat level. A party member is no pet, and is calculated. I do not bother if my Elemental is a pet's pet or a pet.
As a matter of fact, i have an interest in knowing, if i produce more aggro, then my totem or not.
The Totem data is shown in combat log, so it should be possible to calculate it.
[/quote]
um... YOUR pet generates an Event that is perticular to you, your party members generate events that are named differently thus you can tell where it's comming from. so pets and partymembers named the same can diffentiated. Your Totem's pet's are all Named the same, and is Very Much so hard to tell the difference between different elemetals if they are poped at the same time.
-also try not to be an ass and learn how to read fourms, my comment about the wiki was directed at myself and the author of the addon.
Quote from Glith »
No feedback on my two bug above?
Generic Display bugs man.. it prolly chached the names and didn't refresh them propperly, try a UI reload if it really bothers you :D
Generic Display bugs man.. it prolly chached the names and didn't refresh them propperly, try a UI reload if it really bothers you :D
Not a "generic Display bugs".. The threatbar was moving even if it is still in the screenshot*doh*. It was clearly stuck in the threatlist somewhere.
And the negative numbers arent a display bug either.
Please dont give so "quick" answers just to answer something. I seriously want to help solving the bugs.
Generic Display bugs man.. it prolly chached the names and didn't refresh them propperly, try a UI reload if it really bothers you :D
Not a "generic Display bugs".. The threatbar was moving even if it is still in the screenshot*doh*. It was clearly stuck in the threatlist somewhere.
And the negative numbers arent a display bug either.
Please dont give so "quick" answers just to answer something. I seriously want to help solving the bugs.
lol, hasn't the negitive tps beein in this thread for like 3 pages now? and been stated again and again? ...
I ran WAU to update some addons, but when Threat bugged out, I tried to install an older build of it, but I just keep getting this error instead:
\AddOns\Threat-1.0\Threat-1.0\ThreatLogger.lua:3: Cannot find a library instance of AceAddons-2.0.
Edit: ran WAU again to see if the latest release would do anything, still getting the same error. Is there anything I can do? I don't really have a clue as to how addons work...
I just logged into my hunter for the first time in a few weeks and went out to Stranglethorn Vale to kill some stuff, when I noticed that Omen/Threat wasn't taking into account the extra AP/threat from my boar's Charge. Omen was showing myself at 180% threat but the pet still had aggro. The pet's threat values were a lot lower than I was used to. This was working a few weeks ago.
Edit: It seems to be working for some mobs, and not for others. It was working fine on a Stranglethorn Tigress, but failing for a "Venture Co. Miner". Is it possible that the combat log line for Growl is not being parsed correctly due to the presence of a '.' in the name?
Hunter spell Feign Death has 2 second delay to actually clear threat but
ThreatLib doesn't handle with delay.
Here is patch for handle Feign Death 2sec delay(also attached)
BTW, I'm not sure about exact delay.
Could be less then 2 sec. 1sec maybe?
Yet another "stuck"-bug.
I was doing some Alterac valley and one from the same server was in there which also used Omen.
He is still in my Omen and has been there for over 15 minutes now.
Hmm.. Is there some possibity to use Jira/Bugzilla or something for all the bugs in here. I notice that many ppl found some bugs and posts them here but there is rarely some feedback on them. And also many posts are duplicates.
At Leotheras we have a warlock tank the demon phase. He opens up with a timed curse of doom. For the first moments he's not showing up on the threat meter. He catches up with most of us, but some people still appear ahead of him. He maintains aggro, so it hasn't been much of an issue in our raids. However, it seems to me that curse of doom's threat might not be counted for. That's the only thing I can figure.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
No, this is not necessary:
The variable threat is later on modified with all your threat-mods.
Thanks a lot it works now. And this trinket btw... oh their god! Went from mere 10% threat reduction up to 26% threat reduction! I know I have to sacrifice a lot when I'm not using a dps-trinket in the other slot, but in aggro capped fights there's no way any dps trinket can give me up to 16% more dps!
...sorry went a bit off-topic there, but thanks again.
The warlock in my raid enslaved a Homonculus earlier in the raid. And a few fights later it still shows up in Omen even tho it has been dead for a long while.
Please note that everyone is using Omen, noone is using KTM.
Technically they are not my pets but the pets of my totem, true.
But i do not see why this is a reason not to calculate their threat level. A party member is no pet, and is calculated. I do not bother if my Elemental is a pet's pet or a pet.
As a matter of fact, i have an interest in knowing, if i produce more aggro, then my totem or not.
The Totem data is shown in combat log, so it should be possible to calculate it.
With this kind of remark, NO.
-- have a day
Just changed my mind, do a simple search over all your programm files for "Symbol of Hope" and you will see that Threat lib doesn't even know that spell. Therefore there is no chance, it can consider it.
um... YOUR pet generates an Event that is perticular to you, your party members generate events that are named differently thus you can tell where it's comming from. so pets and partymembers named the same can diffentiated. Your Totem's pet's are all Named the same, and is Very Much so hard to tell the difference between different elemetals if they are poped at the same time.
-also try not to be an ass and learn how to read fourms, my comment about the wiki was directed at myself and the author of the addon.
Generic Display bugs man.. it prolly chached the names and didn't refresh them propperly, try a UI reload if it really bothers you :D
self.ElementalPrecision = 1
in function ClassInit
as it ist called from ThreatClassModuleCore 223-225
self:ScanTalents()
self:ClassInit()
the wonderful threat reduction scaned in ScanTalents get overwritten by ClassInit
---
this should solve the miss calculated threat problem.
Not a "generic Display bugs".. The threatbar was moving even if it is still in the screenshot*doh*. It was clearly stuck in the threatlist somewhere.
And the negative numbers arent a display bug either.
Please dont give so "quick" answers just to answer something. I seriously want to help solving the bugs.
lol, hasn't the negitive tps beein in this thread for like 3 pages now? and been stated again and again? ...
**Tho Shall Not Flame those less inclined
(2 extra commas in the zhCN localisaton)
(end statement is missing on the zhCN localisation)
\AddOns\Threat-1.0\Threat-1.0\ThreatLogger.lua:3: Cannot find a library instance of AceAddons-2.0.
Edit: ran WAU again to see if the latest release would do anything, still getting the same error. Is there anything I can do? I don't really have a clue as to how addons work...
athou has fixed it in 47879 - just re-update and all will be well.
Edit: It seems to be working for some mobs, and not for others. It was working fine on a Stranglethorn Tigress, but failing for a "Venture Co. Miner". Is it possible that the combat log line for Growl is not being parsed correctly due to the presence of a '.' in the name?
ThreatLib doesn't handle with delay.
Here is patch for handle Feign Death 2sec delay(also attached)
BTW, I'm not sure about exact delay.
Could be less then 2 sec. 1sec maybe?
Index: Hunter.lua
===================================================================
--- Hunter.lua (revision 47935)
+++ Hunter.lua (working copy)
@@ -32,10 +32,11 @@
self.CastHandlers[BS["Distracting Shot"]] = self.DistractingShot
self.CastHandlers[BS["Disengage"]] = self.Disengage
- self.CastHandlers[BS["Feign Death"]] = self.FeignDeath
+-- self.CastHandlers[BS["Feign Death"]] = self.FeignDeath
-- ClassBuffs
self.ClassBuffs[BS["Misdirection"]] = self.MisdirectionBuff
+ self.ClassBuffs[BS["Feign Death"]] = self.FeignDeathBuff
-- Needed for FD. Ugly as hell, but it works.
@@ -84,6 +85,16 @@
end
end
+function Hunter:FeignDeathBuff(action, rank, apps)
+ ThreatLib:Debug("FeignDeathBuff: %s, %s, %s", action, rank, apps)
+ if action == "gain" then
+ FeignDeathPrimed = true
+ self:ScheduleEvent("ThreadLib-Hunter-FeignDeath", self.FeignDeath, 2, self)
+ elseif action == "lose" then
+ ThreatLib:Debug("User Canceling FD!")
+ FeignDeathPrimed = false
+ end
+end
function Hunter:MisdirectionBuff(action, rank, apps)
-- Previous implementation was a bit too clever :P
if action == "lose" then
I was doing some Alterac valley and one from the same server was in there which also used Omen.
He is still in my Omen and has been there for over 15 minutes now.
See attached screenshot.
Antiarc, Do you have any suggestion?