I don't know if this has been up yet, but the shaman talent Elemental Precision, which reduces your threat by 10% doesn't seem to be counted in Threat-1.0. I see that it has been scripted into /ClassModules/Shaman.lua, but my threat is still exactly the same as my damage and I'm pulling aggro at 144% ranged.
I changed one 1.0 into 0.9 in the Shaman module and I seem to be doing 0.9 x damage threat and properly pulling aggro at 130% ranged. I doubt my fix was very clean (I know next to nothing about lua) and I'm not going to paste it so I can avoid getting flamed for raping your script :P
I was just wondering that were you aware of the issue.
I thought "Threat-1.0"-lib as standalone is enough to show up on other people's KTM/Omen?
Damn it, now I'm confused again.... :-P
Threat-1.0 automatically broadcasts to other Threat users but not to KTM. You must either use one of the front-end mods to activate that or use the script command which iirc was posted in the FuBar_ThreatFu thread.
I don't know if this has been up yet, but the shaman talent Elemental Precision, which reduces your threat by 10% doesn't seem to be counted in Threat-1.0. I see that it has been scripted into /ClassModules/Shaman.lua, but my threat is still exactly the same as my damage and I'm pulling aggro at 144% ranged.
I changed one 1.0 into 0.9 in the Shaman module and I seem to be doing 0.9 x damage threat and properly pulling aggro at 130% ranged. I doubt my fix was very clean (I know next to nothing about lua) and I'm not going to paste it so I can avoid getting flamed for raping your script :P
I was just wondering that were you aware of the issue.
I poked around a bit in that file and I think I found a fix.
In Shaman.lua, simply go to line 31, and delete this:
self.ElementalPrecision = 1
I changed that and went onto the PTR to test (since I hate respeccing on live when I don't have to :|) and it appeared to work perfectly. Shot a lightning bolt at a mob with 0 points, 1 point, 2 points, and 3 points in it, and it was reporting the correct amount of threat each time I added a new point into it.
I thought "Threat-1.0"-lib as standalone is enough to show up on other people's KTM/Omen?
Damn it, now I'm confused again.... :-P
Threat-1.0 automatically broadcasts to other Threat users but not to KTM. You must either use one of the front-end mods to activate that or use the script command which iirc was posted in the FuBar_ThreatFu thread.
I thought that Orion told me something else here, but okay... seems I just misunderstood his statement.
I was in a group with me (70 Paladin w/ Righteous Fury talent and the buff on) and a 70 Rogue w/ Blessing of Salvation. I ended up mostly healing myself due to the elite hitting hard, so not alot of melee damage output. However looking at the Threat reported via Omen (and hence provided by Threat-1.0) I had a large threat lead on the rogue, however the rogue still took aggro from me when they were not feinting, I checked when the rogue got aggro and I still showed a large lead. Is it possible that Righteous Fury does not apply to healing spells or do you have some other idea why this might have happened.
So, I don't want to sound pushy or anything, but is there anything specific I need to do to get the elemental precision fix in the main zip file? :P
I've been manually removing that line since my post and haven't noticed any side effects/errors during raids aside from getting an accurate threat display :)
So, I don't want to sound pushy or anything, but is there anything specific I need to do to get the elemental precision fix in the main zip file? :P
I've been manually removing that line since my post and haven't noticed any side effects/errors during raids aside from getting an accurate threat display :)
I would guess find Antiarc on IRC if you want it sooner.. or wait for him to read this thread. I would commit it myself, but I really hate updating other author's projects.
Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.
Any idea how I might get this thing working with Threat-1.0?
Threat Library is currently ignoring some threat source.
- Draenei Priest mana Regen ability. Generates a lot of threat but doesn't show up.
- Shaman pets don't show up, as any other totem with own aggro list, i don't really care for my magma totem, but my earth elemental totem, would be really useful it would show up.
- Shaman heal spells seem to be calculated too low. A 5000 heal from Healing Wave shows up only for 200 aggro, but this should be much higher.
[2007/08/22 20:08:51-44-x2]: ...s\Threat-1.0\Threat-1.0\ThreatMobNameTranslation.lua:149: Conflicting translation for Ashtongue Feral Spirit in esES: old is "Furia de tormenta", new is "Esp?ritu feral Lengua de ceniza". Please report to Antiarc.:
---
Threat Library is currently ignoring some threat source.
- Draenei Priest mana Regen ability. Generates a lot of threat but doesn't show up.
- Shaman pets don't show up, as any other totem with own aggro list, i don't really care for my magma totem, but my earth elemental totem, would be really useful it would show up.
- Shaman heal spells seem to be calculated too low. A 5000 heal from Healing Wave shows up only for 200 aggro, but this should be much higher.
Your Elementals are not your pet's.. thus not calculated; not a bug or glitch - working as intended -- have a day.
as for the aggro on the Draenei priest regen, do the testing post the results.
@ Dev & note to self: consider putting a toturial about how to do testing into wikil.
Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.
Any idea how I might get this thing working with Threat-1.0?
if trinket1ID == 30621 or trinket2ID == 30621 then
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
But the thing is that it just doesn't work.
It doesnt work, because the function to detect it doesnt work:
if trinket1ID == 30621 or trinket2ID == 30621 then
DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
It never gets to my added Print statement, but if I change it to:
if trinket1ID == "30621" or trinket2ID == "30621" then
DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
It works, so thats the problem, the item id is a string, not a number.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Damn it, now I'm confused again.... :-P
I changed one 1.0 into 0.9 in the Shaman module and I seem to be doing 0.9 x damage threat and properly pulling aggro at 130% ranged. I doubt my fix was very clean (I know next to nothing about lua) and I'm not going to paste it so I can avoid getting flamed for raping your script :P
I was just wondering that were you aware of the issue.
Threat-1.0 automatically broadcasts to other Threat users but not to KTM. You must either use one of the front-end mods to activate that or use the script command which iirc was posted in the FuBar_ThreatFu thread.
I poked around a bit in that file and I think I found a fix.
In Shaman.lua, simply go to line 31, and delete this:
I changed that and went onto the PTR to test (since I hate respeccing on live when I don't have to :|) and it appeared to work perfectly. Shot a lightning bolt at a mob with 0 points, 1 point, 2 points, and 3 points in it, and it was reporting the correct amount of threat each time I added a new point into it.
Do I get a gold star? :)
I thought that Orion told me something else here, but okay... seems I just misunderstood his statement.
I guess this has to be run on every login to enable broadcasting, right?
ya that script will have to be run on every login.
@ Antiarc -- wtb slash command in threat-lib to enable the bcast to KTM
I've been manually removing that line since my post and haven't noticed any side effects/errors during raids aside from getting an accurate threat display :)
I would guess find Antiarc on IRC if you want it sooner.. or wait for him to read this thread. I would commit it myself, but I really hate updating other author's projects.
Okay, (re)installed "ThreatFu". ;-)
Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.
Any idea how I might get this thing working with Threat-1.0?
edit: here's the mechanic for the spell crit reduction: http://www.wowhead.com/?spell=38328
and here's the melee one: http://www.wowhead.com/?spell=38329
edit II: After looking up the libraries again I noticed this thing in the ThreatClassModuleCore.lua:
-- Prism of Inner Calm, see http://www.wowhead.com/?item=30621
self.meleeCritReduction = 0
self.spellCritReduction = 0
if trinket1ID == 30621 or trinket2ID == 30621 then
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
But the thing is that it just doesn't work.
You have to substract 30%,
self.meleeCritReduction = 105
self.spellCritReduction = 700
should be right.
- Draenei Priest mana Regen ability. Generates a lot of threat but doesn't show up.
- Shaman pets don't show up, as any other totem with own aggro list, i don't really care for my magma totem, but my earth elemental totem, would be really useful it would show up.
- Shaman heal spells seem to be calculated too low. A 5000 heal from Healing Wave shows up only for 200 aggro, but this should be much higher.
Your Elementals are not your pet's.. thus not calculated; not a bug or glitch - working as intended -- have a day.
as for the aggro on the Draenei priest regen, do the testing post the results.
@ Dev & note to self: consider putting a toturial about how to do testing into wikil.
It doesnt work, because the function to detect it doesnt work:
It never gets to my added Print statement, but if I change it to:
It works, so thats the problem, the item id is a string, not a number.