Authors CurseForge

Quote from yssaril

first its a personal choice cause i never liked the split stack frame :) also i will need most of the code for the auto buy feature

True, but it makes your addon rather unattractive to someone who already has more widely useful stack-split enhancement and/or automatic restocking addons installed, which is a shame since ImprovedMerchant hardly works at all and a replacement would be nice.

Quote from LaoTseu

Look at the first screenshot you posted in the thread. The price for items is 68K honor points but the frame shows how much gold you have, not honor points. The normal frame does the same thing. It always show the gold you have even when the items that are sold require another type of currency.

hmm interesting idea

alright got some more coding done tonight and have a couple changes i think you guys will like



the quantity frame and the buy button are gone but instead the minNumItems number which is actually a editbox gets focused when you leftclick the icon so you can type in any number up to 999 and buy that quantity by hitting enter.

everything else should work just like the normal icon in the merchant frame(i even put the splitstack frame back in if you like it) and if you really want to pickup an item instead of straight buying it simply drag it off the icon :)

also the price of the item adjusts if you change the quantity in the editbox to reflect the total purchase price

i haven't yet decided what to do about the itemLevel but it will change to something else

Quote from yssaril

the quantity frame and the buy button are gone but instead the minNumItems number which is actually a editbox gets focused when you leftclick the icon so you can type in any number up to 999 and buy that quantity by hitting enter.

does that mean you have to click and then hit enter just to buy 1?

Quote from lilsparky

does that mean you have to click and then hit enter just to buy 1?

all left click does on the regular merchant frame is pickup the item (not buy it) thisi changed to activate the editbox. if you still want to pickup an item then simply clickdrag it from the icon

simply rightclicking will still simply buy one item (or however many items one buy will get you)

have attached the current state of the addon if you want to try it

all left click does on the regular merchant frame is pickup the item

duh, of course.

added some most of the filter code



the filters are generated from
isUsable from the GetMerchantItemInfo function
and
itemType, itemSubType, and itemEquipLoc from the GetItemInfo function

it is split into 3 filters since there is some overlap between the following 3 groups [isUsable] [itemType, itemSubType] and [itemEquipLoc]

the menu is generated using the UIDropDownMenu API (Xinhuan guide is great)

one problem with the blizzard menu is that it doesn't refresh unless you toggle it so when you click a level 2 filter then the lvl 1 filter should also be checked but doesnt since it needs a refresh. toggling will fix the problem.
you can also simply click a lvl1 filter and it will act as if you had selected all lvl2 filters under the lvl1 filter though it will not check these even on refresh (intended)

i am thinking of adding a Is Not Yet Known filter which would get rid of any recipes/pets/mounts that you have already learned this would require tooltip scanning though unless i overlooked an api call somewhere

current code is attached if you wanna try it and/or review my code and tell me what i'm doing wrong

oops was trying to prevent that error from occuring but "fixed" it with the function that will cause the error in the first place /cry

should be fixed in the attached version

also improved the filter logic code a bit (should be faster)

added in a Not Yet Known Filter so you can filter out items that you already know (dalaran cooking award recipes come to mind)

Yeah. I wish I had that.

Wife and I were using the same account doing cooking dailies (alternating).. she called me @ werk and said "Honey! Guess what, I just did a daily, and bought you a fish feast recipe!".

<Silence>

"Have you tried to learn it?" I answerd.. "Nope, doing that now... Wait. it won't let me learn it"....

"Already known".

Not sure why you are allowed to buy soulbound recipes that you already know. I know it was stupid on our part, and entirely our fault of miscommunication.. but still.

do you guys think i should color code already known items or is the not yet known filter enough? the filter just goes through each items tooltip and searches for the Already Known string (should be localized since it uses the Global string variable) and then hides the items where it finds the string

Quote from yssaril

do you guys think i should color code already known items or is the not yet known filter enough? the filter just goes through each items tooltip and searches for the Already Known string (should be localized since it uses the Global string variable) and then hides the items where it finds the string

Well, i think red is good enough. But an option to hide additionally would be nice.. (or perhaps hide the ones that do not use money currency, or if the item is soulbinding on purchase?)

I.e. I would choose hide known, but my wife wouldn't... there are some recipes that are typically good to put on the AH. She knowingly buys recipes that she knows, to put them on the AH.

Also, is this addon anywhere for download in it's entirety (without having to patch)? (i.e. the svn, or googlecode, or xxxx)

not yet wanted to get something more substantial together before uploading :) but i will add it as a Wowace project when i think its ready for widespread use

Quote from yssaril

do you guys think i should color code already known items or is the not yet known filter enough? the filter just goes through each items tooltip and searches for the Already Known string (should be localized since it uses the Global string variable) and then hides the items where it finds the string

for recipes, you should indicate the level required somewhere. if it's already known, you could replace this with some kind of indicator.

for bonus points, it'd be cool to somehow work in the skill level colors. perhaps simply color the recipe based on its color (red for unknown, orange, yellow, green, gray). the skill levels for trade skills can be found in periodic table. there's also a recipe to trade item database in lib pt that could be refactored on the fly to be a recipe item id to spell id (to get the skill levels).

Some other addons - I'm thinking of RecipeBook, in particular - already do coloring of recipes in the merchant frames and on the AH. This does more than just known recipies. It will also factor in alts and use different coloring for those known by alts, or learnable by alts, etc. As such, assuming another addon like this could still function properly in conjunction with your addon, it probably wouldn't hurt to ensure the "known" coloring is an optional setting in your addon so people can still make use of outside coloring done by other addons, if desired.

That being said, I haven't tried your addon out yet, but have just downloaded it to try it out. ;)

I have a few points :)

1. Allow font size changes (Right now it's so small I can barely read it.)
2. Perhaps opt for coloring known recipes and unusable things but include a * before and after the name. This would allow people who are visually impaired to benefit from this addon as well.
3. I love the speed with which it does its job, please don't change that :P

Other then that, I encourage people to try this addon, it is very nice.