Finals are over so I've got more time to be working on this. Here's what I'm working with so far:
Each rule has a name and icon. These rule icons are the smaller icons near the top and they work like you'd expect tabs to. The tabls can be undocked into their own windows (as you can see with the Consumables and Reagents groups I have on the left).
Tooltips work similar to the way OneBag handles tooltips, so I shouldn't be breaking anything that adds to item tooltips (hopefully).
Things I still need to do before I'll post this:
* Virtual Stacks (at least for the empty slots and for the ammo/Shard slots at the top)
* Add a few buttons to the undocked windows
- Undocked windows are anchored (an parented) to the main window by default. I'd like to add a way to unparent so you can keep an undocked window open all the time, and also add a way to quickly redock the window.
* Add money display to the main frame. (Probably bottom right corner)
* Handle Item cooldowns
* Rarity borders like in OneBag / MyBags
* Allow customization of the rules and sorting exceptions. (I need to learn AceGUI enough to make a nice interface for this)
Haha, yes... I will be wanting some people to test this out once I get it running. I'm probably going to have a beta when I get all the layout type stuff I want going. I'm a lot less worried about the sorting rules for now. Those can be hacked if necessary in the lua, so it's somewhat of my last priority to make them easy to change in game.
You know, whith the latest version of AdvancedBagsPlus (it has a LOT of improvements, both in appearance, functionality and performance) I thught I'd never switch away from it.
one request is to have the dropdown for the player so that you can see the items on your alts (using KC_Items cache).. maybe a checkbox for bank info too (show them in the same window, but highlighted gray)
I've been tracking down bugs with my Inventory scanner all day that kinda makes me want to release a beta tonight now that I think I've got all the kinks worked out and it seems to stay in sync with my inventory. It's still very beta: nothing (at all) is being saved to Saved Variables so no configuration of anything. Tabs can be undocked by shift+clicking their icon and docked by clicking it again. All the subwindows are always parented to the main frame so when you close it you close them all. All undocked windows open in the same place and overlap until you move them. I haven't tested Ammo slots much, and i haven't tested Soul Shards at all (I don't have a warlock :-[).
<EDIT> I changed the frameStrata on my cooldown frames so that they are on top of the ItemButtons. Still sort of a problem because it seems that frames can fit between the cooldown frame and the item button itself.
Here's a link to beta release 1. Test server only (I'm using the 9th return value of GetItemInfo to get icons, never GetContainerItemInfo, it might do something on Live, but I haven't tried it). http://people.ucsc.edu/~tgerdes/InvSort.zip
<EDIT> Oh yeah, I limited the ItemButtons to 100. Probably not a big problem because it should be re-using any item buttons that aren't visible if it runs out. But if you undock every window and you have more than 100 items, some might not show up. More can be added really easily in the XML
This is ... quite possibly ... the most amazing bag system I've ever seen. My hat's off to you, Ramble, it really is. I've always wanted an auto-organized bag. I've always wanted immediate access to all my foodstuffs (bye bye, AutoBar!) and man, am I impressed. You've outdone yourself this time. I always knew you were a good coder but damn, man.
Of course, this might just be my good mood after having had a wisdom tooth's pain come to an end but after the uglyness and bloat of Advanced Bags, after the uglyness and bloat of every other system out there, seeing something as sleek and beautiful as this continues to prove one thing. We have the best coders here and our guys? They do amazing shit.
There's only one, humble request I have. Add a hover-timer, the way I use tabs in Firefox is that if I hover over a button for X amount of time, it switches. You can use Timex for this. Basically use OnEnter and OnLeave. Then start the timer and if the mouse leaves the button before the timer is up, remove the timer. That's the only request I have.
Anyway, this is what I'll be using, now and til the end of time. And folks know that if it gets this glowing of a commendation from me, it has to be Just That Good. :p
---Edit---
One more suggestion (and anyone can do this) ...
MoneyFrameNuker seems to only add its stuff to InvSort after a reloadui, this is a shame because I really hate the default Blizzard coins frame, for someone with whack sight like mine, it messes with me. However, I found an easy solution. Add:
What I noticed was that when I sold something, the item would stay there but greyed out. What I've done is hook the containerframe button-click function. That way, whenever something is sold or the last of an item stack is used, the button clears instead of hanging around and being grey.
This is most noticable at a vendor.
Due to my own personal tastes. I've also setup InvSort to auto-open and auto-close at the vendor, bank and when the mail-frame is open.
These are just a few minor tweaks until 1.9 goes live. I've also got MoneyFrameNuker in there as an OptionalDep.
---Edit---
I have come across a rather serious problem but this might be because I'm playing on Live, not Test.
I've been playing around with it on my test characters until now, that's been fantastic. I just tried my main and 80 per cent of his herbs show up as Trade items, instead of Reagents.
It does have a few issues but I've cleaned those up, these are probably fixed on Test. Anyway ...
Oh Rowne, I love you so much. You see something broken and you just go in and fix it :-D.
What I noticed was that when I sold something, the item would stay there but greyed out. What I've done is hook the containerframe button-click function. That way, whenever something is sold or the last of an item stack is used, the button clears instead of hanging around and being grey.
I didn't see your fix for this anywhere, but I made a change that should fix this.
Due to my own personal tastes. I've also setup InvSort to auto-open and auto-close at the vendor, bank and when the mail-frame is open.
These are just a few minor tweaks until 1.9 goes live. I've also got MoneyFrameNuker in there as an OptionalDep.
I'll leave these tweaks in until I get around to saving those sort things as options. Most people want that behaviour anyways.
I've been playing around with it on my test characters until now, that's been fantastic. I just tried my main and 80 per cent of his herbs show up as Trade items, instead of Reagents.
This is mostly because my categories for sorting probably arent the greatest. The sorting rules are in InvSortDefaults.lua. I've added the itemID, Type, and SubType to all item tool tips so you can see why things are being put into specific groups. (I don't think I used anything other than type or subtype for my rules really).
Quote from "Rowne" »
There's only one, humble request I have. Add a hover-timer, the way I use tabs in Firefox is that if I hover over a button for X amount of time, it switches. You can use Timex for this. Basically use OnEnter and OnLeave. Then start the timer and if the mouse leaves the button before the timer is up, remove the timer. That's the only request I have.
Haha, maybe I should have someone write a TabMixPlus plugin for this....
Quote from "FryGuy" »
i have to wait for 1.9 then i guess Sad
Looks awesome.. i can't wait.
So far it seems to work pretty much on the live server. I've run into a few other glitches Rowne didn't notice:
BAG_UPDATE_COOLDOWN wasn't registered, so when cooldowns started they didn't show, but if you switched to a tab that had a cooldown running already it'd be there. Also, I'm not sure if there's still strata issues with the CooldownFrame, sometimes it seems to want to load behind the item button. kinda frustrating.
I left a hack I was experimenting with dropping items in that was causing you to move when you clicked the tab buttons if you had click to move turned on.
... That's all I can remember.
Oh yes, on Live theres an issue with undocking windows. I'm aware theres some funky behaviour with the tab icon when it get reparented but I haven't got around to fixing that yet.
<Edit> Stealth hack, I think I fixed the icons when undocking windows for Live. Really strange; All I had to do was reset the scale to .5, and tell it to Show even though it was already shown before reparenting (I think maybe the new parent wasn't shown so it changed it).
I know this is still early in development but just as an FYI this has already replaced any othe bag mod I'm using. Not that there arn't things I'm looking forward to being added.
Things I'd like to see added.
1. ability to scale the item icons. Not the entire thing, IE leave text alone etc just change the bag item icon size.
2. ability to drag an item from one catagory to another. IE to move unkown itmes into one on the know catagories I could just drag and drop it on the catagory tab.
3. refreshes seem slow. IE I'll pick up a few of the same type of item but the count in my bag doesn't update. I need to move something around in the tab to get a refresh.
4. An autostack button. Perhaps a small button near the count of availible slots that when clicked will auto stack items that are split to conserve space. I don't like the idea of a constant auto stacking going on but a manual one would be great.
5. extend this to display the bank bags including when away from the bank.
I agree with Thirsterhall on those features but would like a option to only have the category buttons visible, both vertical and horisontal.
There is a addon called trinketmenu wich is lovely, altho not aced yet heh...
Maybe you want to take a look on how it handles scaling and docking of the frames as i find it brilliant and maybe not for this mod, but then again maybe there is some use of it to you. :)
If some of these things would be possible i would never again use another bagmod :) as with the sorting so long it?s been a joy nontheless...
ohh i better stop rambling hehe
Ps. can?t wait until i?m able to drop the rest of my non aced addons, Great work all of you and thx for the wonderful community... :) (couldnn?t resist)
Each rule has a name and icon. These rule icons are the smaller icons near the top and they work like you'd expect tabs to. The tabls can be undocked into their own windows (as you can see with the Consumables and Reagents groups I have on the left).
Tooltips work similar to the way OneBag handles tooltips, so I shouldn't be breaking anything that adds to item tooltips (hopefully).
Things I still need to do before I'll post this:
* Virtual Stacks (at least for the empty slots and for the ammo/Shard slots at the top)
* Add a few buttons to the undocked windows
- Undocked windows are anchored (an parented) to the main window by default. I'd like to add a way to unparent so you can keep an undocked window open all the time, and also add a way to quickly redock the window.
* Add money display to the main frame. (Probably bottom right corner)
* Handle Item cooldowns
* Rarity borders like in OneBag / MyBags
* Allow customization of the rules and sorting exceptions. (I need to learn AceGUI enough to make a nice interface for this)
If you want to i will beta this addon for you back and forth trough hell and yes even khaos to make sure its all working fine and dandy.
But I think I just fell in love with this :D
I too must try this.
<EDIT> I changed the frameStrata on my cooldown frames so that they are on top of the ItemButtons. Still sort of a problem because it seems that frames can fit between the cooldown frame and the item button itself.
Here's a link to beta release 1. Test server only (I'm using the 9th return value of GetItemInfo to get icons, never GetContainerItemInfo, it might do something on Live, but I haven't tried it).
http://people.ucsc.edu/~tgerdes/InvSort.zip
<EDIT> Oh yeah, I limited the ItemButtons to 100. Probably not a big problem because it should be re-using any item buttons that aren't visible if it runs out. But if you undock every window and you have more than 100 items, some might not show up. More can be added really easily in the XML
Of course, this might just be my good mood after having had a wisdom tooth's pain come to an end but after the uglyness and bloat of Advanced Bags, after the uglyness and bloat of every other system out there, seeing something as sleek and beautiful as this continues to prove one thing. We have the best coders here and our guys? They do amazing shit.
There's only one, humble request I have. Add a hover-timer, the way I use tabs in Firefox is that if I hover over a button for X amount of time, it switches. You can use Timex for this. Basically use OnEnter and OnLeave. Then start the timer and if the mouse leaves the button before the timer is up, remove the timer. That's the only request I have.
Anyway, this is what I'll be using, now and til the end of time. And folks know that if it gets this glowing of a commendation from me, it has to be Just That Good. :p
---Edit---
One more suggestion (and anyone can do this) ...
MoneyFrameNuker seems to only add its stuff to InvSort after a reloadui, this is a shame because I really hate the default Blizzard coins frame, for someone with whack sight like mine, it messes with me. However, I found an easy solution. Add:
## OptionalDeps: MoneyFrameNuker
To the toc file, that fixes all.
Looks awesome.. i can't wait.
It does have a few issues but I've cleaned those up, these are probably fixed on Test. Anyway ...
http://mastaile.mine.nu/InvSort.zip
What I noticed was that when I sold something, the item would stay there but greyed out. What I've done is hook the containerframe button-click function. That way, whenever something is sold or the last of an item stack is used, the button clears instead of hanging around and being grey.
This is most noticable at a vendor.
Due to my own personal tastes. I've also setup InvSort to auto-open and auto-close at the vendor, bank and when the mail-frame is open.
These are just a few minor tweaks until 1.9 goes live. I've also got MoneyFrameNuker in there as an OptionalDep.
---Edit---
I have come across a rather serious problem but this might be because I'm playing on Live, not Test.
I've been playing around with it on my test characters until now, that's been fantastic. I just tried my main and 80 per cent of his herbs show up as Trade items, instead of Reagents.
Oh Rowne, I love you so much. You see something broken and you just go in and fix it :-D.
I didn't see your fix for this anywhere, but I made a change that should fix this.
I'll leave these tweaks in until I get around to saving those sort things as options. Most people want that behaviour anyways.
This is mostly because my categories for sorting probably arent the greatest. The sorting rules are in InvSortDefaults.lua. I've added the itemID, Type, and SubType to all item tool tips so you can see why things are being put into specific groups. (I don't think I used anything other than type or subtype for my rules really).
Haha, maybe I should have someone write a TabMixPlus plugin for this....
So far it seems to work pretty much on the live server. I've run into a few other glitches Rowne didn't notice:
BAG_UPDATE_COOLDOWN wasn't registered, so when cooldowns started they didn't show, but if you switched to a tab that had a cooldown running already it'd be there. Also, I'm not sure if there's still strata issues with the CooldownFrame, sometimes it seems to want to load behind the item button. kinda frustrating.
I left a hack I was experimenting with dropping items in that was causing you to move when you clicked the tab buttons if you had click to move turned on.
... That's all I can remember.
Anyways, I'll throw a new beta up at http://people.ucsc.edu/~tgerdes/InvSortb2.zip
Oh yes, on Live theres an issue with undocking windows. I'm aware theres some funky behaviour with the tab icon when it get reparented but I haven't got around to fixing that yet.
<Edit> Stealth hack, I think I fixed the icons when undocking windows for Live. Really strange; All I had to do was reset the scale to .5, and tell it to Show even though it was already shown before reparenting (I think maybe the new parent wasn't shown so it changed it).
1. how do you undock the catagories. I guess I'm too dumb to figure it out.
2. how do you see unknown items? IE items that don't fit into a catagory.
Shift click the tab icon. Click the icon in the new frame to re dock it.
::Cough:: whoops. I'll add this soonish.
As for the unknown how about a '?' icon/catagory that only shows up when you have unknown items.
Yup that's exactly what i was planning ^_^ http://people.ucsc.edu/~tgerdes/InvSortb3.zip
Only change is added the Unknown tab; should only be there if you have unknown items (I didn't test that much actually).
I know this is still early in development but just as an FYI this has already replaced any othe bag mod I'm using. Not that there arn't things I'm looking forward to being added.
Things I'd like to see added.
1. ability to scale the item icons. Not the entire thing, IE leave text alone etc just change the bag item icon size.
2. ability to drag an item from one catagory to another. IE to move unkown itmes into one on the know catagories I could just drag and drop it on the catagory tab.
3. refreshes seem slow. IE I'll pick up a few of the same type of item but the count in my bag doesn't update. I need to move something around in the tab to get a refresh.
4. An autostack button. Perhaps a small button near the count of availible slots that when clicked will auto stack items that are split to conserve space. I don't like the idea of a constant auto stacking going on but a manual one would be great.
5. extend this to display the bank bags including when away from the bank.
AceInvSortFrames.lua:231: attempt to compare nil with string
---
AceInventory.lua:88: Invalid inventory slot in GetInventoryItemLink
I agree with Thirsterhall on those features but would like a option to only have the category buttons visible, both vertical and horisontal.
There is a addon called trinketmenu wich is lovely, altho not aced yet heh...
Maybe you want to take a look on how it handles scaling and docking of the frames as i find it brilliant and maybe not for this mod, but then again maybe there is some use of it to you. :)
If some of these things would be possible i would never again use another bagmod :) as with the sorting so long it?s been a joy nontheless...
ohh i better stop rambling hehe
Ps. can?t wait until i?m able to drop the rest of my non aced addons, Great work all of you and thx for the wonderful community... :) (couldnn?t resist)
Want a sneak preview? Pull out your old chemistry periodic table, stare at some WoW ItemID's and think really hard *grin*