once you run it, that's the end. It ports the old Cart2 database over to HandyNotes. Your Old Cart2 addon / the stub i gave you and the old Cart2 database are no longer needed, least that's how it should be...
The biggest problem with these "fake" notes is that there is no way to remove them in-game. In addition to the lack of a tooltip and errors being thrown, the right-click menu does not work on them either.
try this one.. I added where the title and the description is the same when imported.
this might make undesirable effects, but it should fix some of the issues.
Also no problems with importing over and over again, as it should replace the previous note.
(the crowd cheers) The fake notes can now be deleted from the world map so the errors with them never happen again.
One issue, though. When importing (or reimporting; I've done both...heh) the Cart2 notes with the updated import.lua, its different than it used to be. As in all your imported notes have duplicate lines in them. It duplicates the note Title the Description/Notes area.
For example, for a note that reads "Timmy starts here!", that line is duplicated in both areas. Meaning that every imported note on the map looks like Jacob Two-Two wrote them. This happens whether reimporting or starting with a 100% fresh HandyNotes SV (deleted before importing).
correct. I duplicated them, mostly because i think that handy notes dosn't like a empty "notes" field.
you can try to change line 65
[php]
local newCordData = {
title = noteData.title,
icon = iconMap[noteData.icon] or math.random(1,7),
desc = noteData.title, -- <<Line 65
}[/php]
to just desc = " "
Cartographer only has a "title" field, where as handy notes has both title and desc.
*** Also for not for others; the zip includes the cart notes from one of the other posters here, so please make sure you replace it with your data. Otherwise you'll have a whole bunch of German notes all over the map.
you can try to change line 65
...to just desc = " "
Works well, tyvm. The imported notes are a bit "beefier" than you might expect, with the empty line taking up note tooltip space (mmmm....beeefffff). But its better than duplicate lines.
Well if you know how your notes are arranged, like there is a distinct marker in the notes that indicates a new line you can break apart the title and move the actual note into the description.
like if you used stars (*) to indicate a new line, you can do something like:
~line 62
[php]
local title, desc = noteData.title:match("^(%s)*(.+)$")
local newCordData = {
title = title or noteData.title,
icon = iconMap[noteData.icon] or math.random(1,7),
desc = desc or "",
}
[/php]
Thanks again :). Three things there. First, I discovered what the problem was causing notes to have an "empty space" below the title (where the blank description is). Instead of
desc = desc or "",
I used
desc = desc or " ",
leaving a space between the quotation marks. A space creates an empty line on the imported notes below the title. Removing the space gives the imported notes no empty line (tested).
Second thing, your code above bugs out here :(. Insert what you have above starting at line 62 (ending on line 67) in import.lua and the following error is consistently thrown up when doing a /cart2handynotes with a blank HandyNotes SV & the prior used Cart notes:
["message"] = "Cart2HandyNotes\\import.lua:62: attempt to index field 'title' (a nil value)\nCart2HandyNotes\\import.lua:91: in function `value'\nInterface\\FrameXML\\ChatFrame.lua:4070: in function `ChatEdit_ParseText':\nInterface\\FrameXML\\ChatFrame.lua:3660: in function `ChatEdit_SendText':\nInterface\\FrameXML\\ChatFrame.lua:3698: in function `ChatEdit_OnEnterPressed':\n<string>:\"*:OnEnterPressed\":1: in function <[string \"*:OnEnterPressed\"]:1>\n\nLocals:|r\nmsg = \"\"\n\n ---",
["type"] = "error",
["session"] = 387,
["counter"] = 1,
}, -- [52]
A few notes are actually imported, but it stops mid-way through and the bug is thrown up.
Finally, something fairly significant noticed using the prior working import.lua (something I should have noticed long ago). With my old Cartographer.lua notes, several of them have an ["info"] = field. In this field can be additional note info and its not imported by the mod. The only thing imported is the ["title"] = field.
For example, you could have a title of "Donna" and the info field has "Gives good quest, hubba hubba". About 25% or so of the old notes I created/received from others contain additional ["info"] = data.
Would it be possible to make it so that it could import the Cart ["info"] = data and put that in the HandyNotes ["desc"] = area, while retaining the existing, working ["title"] = data?
[PHP] local title, desc = (noteData.title or ""):match("^(%s)*(.+)$")
local newCordData = {
title = title or noteData.title,
icon = iconMap[noteData.icon] or math.random(1,7),
desc = noteData.info or desc or " ",
} [/PHP]
line 62-67
I didn't know about the info field. I thought that cart only had the title and no other associated text.
With this latest change, Cart2HandyNotes has reached (drum roll)...perfection! :)
In [info]= lines are properly imported and placed under the [title]= in notes created with that extra data, with no extra spaces showing up (taking the space out of line 66: or "",).
I came back to look at this thread after some time and saw the improvements you made. Thank you very much for your work!
I tried to follow the code changes on the last page of this thread and probably did something wrong while editing. Especially I got confused about the "or" in this code snippets. Does the "or" belong to the code or do we have to decide, which part to choose?
But I want to have my own set of perfectly imported cartograher notes on my map, you know, all that strange german stuff! :-)
I would also like to direct others to this thread who wouldn't be able to edit lua code.
So Zidomo, please post the import tool version that received your last drum rolls. The final version that got everything right for you.
I'm going to go on a wild limb and say that 90% of the notes in Azeroth and Kalimdor are going to be obsolete once Cataclysm hits. Depending on how Astrolabe is updated for Cataclysm and whether it takes into account terrain phasing...
Let's just say its currently unknown whether a new version of the addon for Cataclysm will be compatible.
So Zidomo, please post the import tool version that received your last drum rolls. The final version that got everything right for you.
Sorry man, stopped following this thread some time ago...heh.
Below is the final version of import.lua I used (dated 7-24-2010), included in the Cart2HandyNotesperfecto.zip file attached to this post. Hopefully can still load Cartographer temporarily in WoW 4.0 to allow the note import.
Full credit again to OrionShock for making this increasingly esoteric niche need possible.
I'm going to go on a wild limb and say that 90% of the notes in Azeroth and Kalimdor are going to be obsolete once Cataclysm hits. Depending on how Astrolabe is updated for Cataclysm and whether it takes into account terrain phasing...
Let's just say its currently unknown whether a new version of the addon for Cataclysm will be compatible.
Could kagaro's new LibMapData-1.0 eventually be an adequate replacement for Astrolabe (if that's not updated), after HandyNote modifications to accomodate?
I'm just getting an empty page "http://forums.wowace.com/attachment.php?attachmentid=3762&d=1264842053" no matter whether I left-click the link or right-click it. Firefox last version, Noscript but Javascript enabled, popup blocker off. I even tried IE ... nothing.
What am I doing wrong?
I'm afraid the converter will stop working in 30 min because we will get 3.3.5 tonight ...
Edit: the patch seems to be no problem. I'm still not able to download Cart2HandyNotes-2.zip though.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumonce you run it, that's the end. It ports the old Cart2 database over to HandyNotes. Your Old Cart2 addon / the stub i gave you and the old Cart2 database are no longer needed, least that's how it should be...
If you've already ran it then your safe for 3.3.5
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumtry this one.. I added where the title and the description is the same when imported.
this might make undesirable effects, but it should fix some of the issues.
Also no problems with importing over and over again, as it should replace the previous note.
One issue, though. When importing (or reimporting; I've done both...heh) the Cart2 notes with the updated import.lua, its different than it used to be. As in all your imported notes have duplicate lines in them. It duplicates the note Title the Description/Notes area.
For example, for a note that reads "Timmy starts here!", that line is duplicated in both areas. Meaning that every imported note on the map looks like Jacob Two-Two wrote them. This happens whether reimporting or starting with a 100% fresh HandyNotes SV (deleted before importing).
Nice work on the fake note resolution, though.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumyou can try to change line 65
[php]
local newCordData = {
title = noteData.title,
icon = iconMap[noteData.icon] or math.random(1,7),
desc = noteData.title, -- <<Line 65
}[/php]
to just desc = " "
Cartographer only has a "title" field, where as handy notes has both title and desc.
*** Also for not for others; the zip includes the cart notes from one of the other posters here, so please make sure you replace it with your data. Otherwise you'll have a whole bunch of German notes all over the map.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThere has to be a description in the sense that it has to be an empty string, and not a nil value.
Works well, tyvm. The imported notes are a bit "beefier" than you might expect, with the empty line taking up note tooltip space (mmmm....beeefffff). But its better than duplicate lines.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumlike if you used stars (*) to indicate a new line, you can do something like:
~line 62
[php]
local title, desc = noteData.title:match("^(%s)*(.+)$")
local newCordData = {
title = title or noteData.title,
icon = iconMap[noteData.icon] or math.random(1,7),
desc = desc or "",
}
[/php]
that way you have a real title and description.
Second thing, your code above bugs out here :(. Insert what you have above starting at line 62 (ending on line 67) in import.lua and the following error is consistently thrown up when doing a /cart2handynotes with a blank HandyNotes SV & the prior used Cart notes:
["message"] = "Cart2HandyNotes\\import.lua:62: attempt to index field 'title' (a nil value)\nCart2HandyNotes\\import.lua:91: in function `value'\nInterface\\FrameXML\\ChatFrame.lua:4070: in function `ChatEdit_ParseText':\nInterface\\FrameXML\\ChatFrame.lua:3660: in function `ChatEdit_SendText':\nInterface\\FrameXML\\ChatFrame.lua:3698: in function `ChatEdit_OnEnterPressed':\n<string>:\"*:OnEnterPressed\":1: in function <[string \"*:OnEnterPressed\"]:1>\n\nLocals:|r\nmsg = \"\"\n\n ---", ["type"] = "error", ["session"] = 387, ["counter"] = 1, }, -- [52]A few notes are actually imported, but it stops mid-way through and the bug is thrown up.Finally, something fairly significant noticed using the prior working import.lua (something I should have noticed long ago). With my old Cartographer.lua notes, several of them have an ["info"] = field. In this field can be additional note info and its not imported by the mod. The only thing imported is the ["title"] = field.
For example, you could have a title of "Donna" and the info field has "Gives good quest, hubba hubba". About 25% or so of the old notes I created/received from others contain additional ["info"] = data.
Would it be possible to make it so that it could import the Cart ["info"] = data and put that in the HandyNotes ["desc"] = area, while retaining the existing, working ["title"] = data?
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumlocal newCordData = {
title = title or noteData.title,
icon = iconMap[noteData.icon] or math.random(1,7),
desc = noteData.info or desc or " ",
} [/PHP]
line 62-67
I didn't know about the info field. I thought that cart only had the title and no other associated text.
In [info]= lines are properly imported and placed under the [title]= in notes created with that extra data, with no extra spaces showing up (taking the space out of line 66: or "",).
I tried to follow the code changes on the last page of this thread and probably did something wrong while editing. Especially I got confused about the "or" in this code snippets. Does the "or" belong to the code or do we have to decide, which part to choose?
But I want to have my own set of perfectly imported cartograher notes on my map, you know, all that strange german stuff! :-)
I would also like to direct others to this thread who wouldn't be able to edit lua code.
So Zidomo, please post the import tool version that received your last drum rolls. The final version that got everything right for you.
-
View User Profile
-
View Posts
-
Send Message
AdminThis means "Set the title variable to the current contents of the title variable or, if it's empty, to the contents of noteData.title".
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumLet's just say its currently unknown whether a new version of the addon for Cataclysm will be compatible.
Sorry man, stopped following this thread some time ago...heh.
Below is the final version of import.lua I used (dated 7-24-2010), included in the Cart2HandyNotesperfecto.zip file attached to this post. Hopefully can still load Cartographer temporarily in WoW 4.0 to allow the note import.
Full credit again to OrionShock for making this increasingly esoteric niche need possible.
Could kagaro's new LibMapData-1.0 eventually be an adequate replacement for Astrolabe (if that's not updated), after HandyNote modifications to accomodate?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumPlus to upgrade data properly, you would need the size of the zones before patch and the size after and maintain a translation table.