Authors CurseForge

Yep, it has got to the point where I can't find the bugs now. Am I missing anything; is there highly inefficient code; suggestions, comments, or concerns?

What errors are you getting, if any? I purposely left out the support for AddonLoader, if anyone noticed. Is this thing a botched Gnomish experiment?

Willing to translate into other languages? Great! You can do so through the localization page.

All of the above, and putting it through its paces, please. Unlike the original, SmartRes2 will work with ANY class, not just ressers. However, only ressers will be able to bind keys to cast spells. On a related note, does SR2 actually disable itself during combat?

Please give me feedback, and if any code is really borked, a little help would be appreciated. Thank you, and enjoy!

Remember, this is an Alpha build.

http://www.wowace.com/addons/smartres2/

I have been happily squashing bugs "Oh, I'm sorry. Was that your auntie?" but now I've got one that baffles me. BugSack says

1x SmartRes2-Alpha 0.20\SmartRes2.lua:5: Usage: EmbedLibrary(addon, libname, silent, offset): 'libname' - Cannot find a library instance of "LibBars-1.0".
AceAddon-3.0-5 (Ace3):209: in function `EmbedLibrary'
AceAddon-3.0-5 (Ace3):191: in function `EmbedLibraries'
AceAddon-3.0-5 (Ace3):158: in function `NewAddon'
SmartRes2-Alpha 0.20\SmartRes2.lua:5: in main chunk

Locals:
self = <table> {
 DisableAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:566:
 EnableAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:532:
 EmbedLibrary = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:206:
 InitializeAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:509:
 IterateAddonStatus = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:607:
 EmbedLibraries = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:188:
 initializequeue = <table> {}
 statuses = <table> {}
 GetAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:173:
 NewAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:126:
 IterateModulesOfAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:612:
 IterateEmbedsOnAddon = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:611:
 embeds = <table> {}
 IterateAddons = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:597:
 frame = AceAddon30Frame {}
 addons = <table> {}
 enablequeue = <table> {}
}
addon = <table> {
 UnregisterChatCommand = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:111:
 SetDefaultModuleLibraries = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:381:
 UnregisterAllEvents = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:202:
 SendMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:87:
 Enable = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:313:
 NewModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:255:
 Print = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:54:
 EnableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:346:
 modules = <table> {}
 GetModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:230:
 IterateEmbeds = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:456:
 IsModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:482:
 UnregisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181:
 defaultModuleLibraries = <table> {}
 RegisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118:
 SetDefaultModuleState = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:401:
 SetEnabledState = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:438:
 RegisterEvent = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118:
 enabledState = true
 GetArgs = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:144:
 Printf = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:69:
 UnregisterAllMessages = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:202:
 SetDefaultModulePrototype = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:423:
 RegisterChatCommand = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:85:
 defaultModuleState = true
 IterateModules = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:451:
 name = "SmartRes2"
 Disable = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:328:
 IsEnabled = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:465:
 GetName = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:298:
 UnregisterEvent = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181:
 DisableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:364:
}
libname = "LibBars-1.0"
silent = false
offset = 4
lib = nil
error = <function> defined =[C]:-1
t
  ---

Yet LibBars-1.0 is in my Libs folder, the top of my code reads

local SmartRes2 = LibStub("AceAddon-3.0"):NewAddon("SmartRes2", "AceConsole-3.0", "AceEvent-3.0", "LibBars-1.0")
local Bars = LibStub("LibBars-1.0")

My .toc reads

## OptionalDeps: Ace3, LibResComm-1.0, LibSharedMedia-3.0, LibBars-1.0, LibAboutPanel, AceGUI-3.0-SharedMediaWidgets

Libs\LibStub\LibStub.lua
Libs\CallbackHandler-1.0\CallbackHandler.xml

Libs\AceAddon-3.0\AceAddon-3.0.xml
Libs\AceGUI-3.0\AceGUI-3.0.xml
Libs\AceConfig-3.0\AceConfig-3.0.xml
Libs\AceConsole-3.0\AceConsole-3.0.xml
Libs\AceDB-3.0\AceDB-3.0.xml
Libs\AceEvent-3.0\AceEvent-3.0.xml
Libs\AceGUI-3.0-SharedMediaWidgets\widget.xml

Libs\LibBars-1.0\lib.xml
Libs\LibSharedMedia-3.0\lib.xml
Libs\LibResComm-1.0\lib.xml
Libs\LibAboutPanel\lib.xml

Libs\LibDataBroker-1.1\LibDataBroker-1.1.lua

And my .pkgmeta says

externals:
 Libs/LibStub:
  url: svn://svn.wowace.com/wow/libstub/mainline/trunk
  tag: latest
 Libs/CallbackHandler-1.0:
  url: svn://svn.wowace.com/wow/callbackhandler/mainline/trunk/CallbackHandler-1.0
  tag: latest
 Libs/AceLocale-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceLocale-3.0
  tag: latest
 Libs/AceConfig-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceConfig-3.0
  tag: latest
 Libs/AceEvent-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceEvent-3.0
  tag: latest
 Libs/AceConsole-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceConsole-3.0
  tag: latest
 Libs/AceDB-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceDB-3.0
  tag: latest
 Libs/AceGUI-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceGUI-3.0
  tag: latest
 Libs/AceGUI-3.0-SharedMediaWidgets:
  url: svn://svn.wowace.com/wow/ace-gui-3-0-shared-media-widgets/mainline/trunk/AceGUI-3.0-SharedMediaWidgets
  tag: latest
 Libs/AceAddon-3.0:
  url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceAddon-3.0
  tag: latest
 Libs/LibSharedMedia-3.0:
  url: svn://svn.wowace.com/wow/libsharedmedia-3-0/mainline/trunk
  tag: latest
 Libs/LibBars-1.0:
  url: svn://svn.wowace.com/wow/libbars-1-0/mainline/trunk/LibBars-1.0
  tag: latest
 Libs/LibResComm-1.0:
  url: svn://svn.wowace.com/wow/librescomm-1-0/mainline/trunk
  tag: latest
  Libs/LibAboutPanel:
    url: git://git.curseforge.net/wow/libaboutpanel/mainline.git
    tag: latest
    
tools-used:
  - libdatabroker-1-1

So I don't know why LibBars-1.0 isn't being loaded by the addon. If I install LibBars-1.0 as its own addon, it seems to work, and moves onto my next error, around line 499 or so.

Sorry about your head, Torhal. I'll get you some painkillers, stat.

That would be awesome, Farook. Just a warning, while the enUS should be about done, it may change now and then between the current Experimental Alpha and Curse-ready Beta.

It should be fairly intact now, but warning you, just in case.

Something I need to know about translating those random messages? Can't they be translated directly?

Yikes, yeah, typos! I'll fix those right now.

Weird, I know it isn't doing anything, which is weirder. It used to run the test bars no problem, but r30+ isn't. I'm looking into this. However, r32 works fine for me with the UIP, keybindings. I haven't tried the chat channels as I've been out of game time for a couple of days. I was about to up r33 sometime later, which does have a lot of asserting for libs. It also is much cleaner and easier to read.

I'm working on r62 right now, and have squashed some bugs, but I still see some tickets for things still needing to be addressed.

For those who are tying to auto/manual target with the Show Battle Res turned on: there are NO such keybindings, nor will there ever be. During combat, Druids should pick their target with Rebirth, not have a target assigned. By default, Priests, Paladins, Druids/Shamans, other Mana users, then non-Mana users are ressed in that order.

That means, if a keybind were set to auto cast Rebirth, you are more likely to res a Shadow Priest (DPS) than to res the Main Tank who just died. Therefore, all the bars do for Rebirth is show the Druid and their target, and you must cast Rebirth the old fashioned way.

I always use the lastest SVN plus any changes/fixes as my test bed. Perhaps I should try the normal file. However, the Interface Panel has worked for me for some time, as has the slash commands. I will look into the non-SVN version and get back to you.

My guild tested r74 during the weekly raid on Wednesday, and most of SR2 worked fine. There are still some things to fix, and while I know what they are, I'm a little stuck on why they are broken, so I can fix them.

• The random res messages to chat are displaying the table number instead of the related text
• Collision chat messages to ressers don't display anything
• When using the auto res key, it picks the same target again again unless they accept the res, then it moves on
• Turning the res bars off might force a /rl to take effect rather than just doing it on the fly

The problem is that Buggrabber isn't throwing any errors, and I can't spot the incorrect logic in my code.

As for the hang up on res targets, I have a workaround, but I'm not sure how to implement it. I have a table, waitingForAccept{} that I need for other reasons, and it could come in handy to solve this issue. I figure I need to use it in the compareUnit() function, but for reason I'm suffering a mental roadblock. http://paste.wowace.com/1640/

If anyone wants to poke a stick at the chat message problems, please download the whole addon, as it is much easier that way. Sorry about that. :(

I haven't coded support for changing fonts, but eventually that will go in. Changing Textures is working for everybody I ask. Centering the text, eh? Now, why didn't I think of that??

Textures should be an AceGUI-3.0-SharedMedia widget, and the pulldown is in the Res Bars tab. Read the addon description for links to get more textures.

I am going to post a minor update with r75, which *should* fix the major problem of the auto res feature picking the same target until they accept the res. I'm not getting any errors, but can't really test it myself during the week. Please give feedback here or, if necessary, as a ticket.