Yep, it has got to the point where I can't find the bugs now. Am I missing anything; is there highly inefficient code; suggestions, comments, or concerns?
What errors are you getting, if any? I purposely left out the support for AddonLoader, if anyone noticed. Is this thing a botched Gnomish experiment?
Willing to translate into other languages? Great! You can do so through the localization page.
All of the above, and putting it through its paces, please. Unlike the original, SmartRes2 will work with ANY class, not just ressers. However, only ressers will be able to bind keys to cast spells. On a related note, does SR2 actually disable itself during combat?
Please give me feedback, and if any code is really borked, a little help would be appreciated. Thank you, and enjoy!
So I don't know why LibBars-1.0 isn't being loaded by the addon. If I install LibBars-1.0 as its own addon, it seems to work, and moves onto my next error, around line 499 or so.
That would be awesome, Farook. Just a warning, while the enUS should be about done, it may change now and then between the current Experimental Alpha and Curse-ready Beta.
It should be fairly intact now, but warning you, just in case.
I'm quiet sure they can be translated directly. Just have to make sure that I place the '%s'-tags correctly in the german phrase then.
Quick question regarding this:
I see plenty of random messages having only '%' instead of '%s' in it, and they/those are also not marked green. Is this intended, or did you screw them up a bit? For example:
Weird, I know it isn't doing anything, which is weirder. It used to run the test bars no problem, but r30+ isn't. I'm looking into this. However, r32 works fine for me with the UIP, keybindings. I haven't tried the chat channels as I've been out of game time for a couple of days. I was about to up r33 sometime later, which does have a lot of asserting for libs. It also is much cleaner and easier to read.
Though it is loaded, the addon does not show up in the interface panel, nor in the keybind-settings, nor does the chat command bring up anything.
Having the same problem(s) again with r59 and r60.
The revision(s) before made the addon at least showing up (still bugging me a bit, eg. the anchor reappeared all the time though it should be hidden). I also tried to start from s (deleting the Saved Variables files), but that didn't help either.
I'm working on r62 right now, and have squashed some bugs, but I still see some tickets for things still needing to be addressed.
For those who are tying to auto/manual target with the Show Battle Res turned on: there are NO such keybindings, nor will there ever be. During combat, Druids should pick their target with Rebirth, not have a target assigned. By default, Priests, Paladins, Druids/Shamans, other Mana users, then non-Mana users are ressed in that order.
That means, if a keybind were set to auto cast Rebirth, you are more likely to res a Shadow Priest (DPS) than to res the Main Tank who just died. Therefore, all the bars do for Rebirth is show the Druid and their target, and you must cast Rebirth the old fashioned way.
I always use the lastest SVN plus any changes/fixes as my test bed. Perhaps I should try the normal file. However, the Interface Panel has worked for me for some time, as has the slash commands. I will look into the non-SVN version and get back to you.
My guild tested r74 during the weekly raid on Wednesday, and most of SR2 worked fine. There are still some things to fix, and while I know what they are, I'm a little stuck on why they are broken, so I can fix them.
The random res messages to chat are displaying the table number instead of the related text
Collision chat messages to ressers don't display anything
When using the auto res key, it picks the same target again again unless they accept the res, then it moves on
Turning the res bars off might force a /rl to take effect rather than just doing it on the fly
The problem is that Buggrabber isn't throwing any errors, and I can't spot the incorrect logic in my code.
As for the hang up on res targets, I have a workaround, but I'm not sure how to implement it. I have a table, waitingForAccept{} that I need for other reasons, and it could come in handy to solve this issue. I figure I need to use it in the compareUnit() function, but for reason I'm suffering a mental roadblock. http://paste.wowace.com/1640/
If anyone wants to poke a stick at the chat message problems, please download the whole addon, as it is much easier that way. Sorry about that. :(
I haven't coded support for changing fonts, but eventually that will go in. Changing Textures is working for everybody I ask. Centering the text, eh? Now, why didn't I think of that??
Textures should be an AceGUI-3.0-SharedMedia widget, and the pulldown is in the Res Bars tab. Read the addon description for links to get more textures.
I am going to post a minor update with r75, which *should* fix the major problem of the auto res feature picking the same target until they accept the res. I'm not getting any errors, but can't really test it myself during the week. Please give feedback here or, if necessary, as a ticket.
What errors are you getting, if any? I purposely left out the support for AddonLoader, if anyone noticed. Is this thing a botched Gnomish experiment?
Willing to translate into other languages? Great! You can do so through the localization page.
All of the above, and putting it through its paces, please. Unlike the original, SmartRes2 will work with ANY class, not just ressers. However, only ressers will be able to bind keys to cast spells. On a related note, does SR2 actually disable itself during combat?
Please give me feedback, and if any code is really borked, a little help would be appreciated. Thank you, and enjoy!
Remember, this is an Alpha build.
http://www.wowace.com/addons/smartres2/
Yet LibBars-1.0 is in my Libs folder, the top of my code reads
My .toc reads
And my .pkgmeta says
So I don't know why LibBars-1.0 isn't being loaded by the addon. If I install LibBars-1.0 as its own addon, it seems to work, and moves onto my next error, around line 499 or so.
The fact that you're trying to embed LibBars-1.0 into your Ace3 AddOn hurts my head. The second line is the only place you need to declare that lib.
I'll start to work on deDE as soon as I have some time left.
It should be fairly intact now, but warning you, just in case.
I'm done by now, apart from those random ressurection messages that you've put in. Not quiet sure what to do with them...
Quick question regarding this:
I see plenty of random messages having only '%' instead of '%s' in it, and they/those are also not marked green. Is this intended, or did you screw them up a bit? For example:
Though it is loaded, the addon does not show up in the interface panel, nor in the keybind-settings, nor does the chat command bring up anything.
Am I the only one having troubles with this revision?
Having the same problem(s) again with r59 and r60.
The revision(s) before made the addon at least showing up (still bugging me a bit, eg. the anchor reappeared all the time though it should be hidden). I also tried to start from s (deleting the Saved Variables files), but that didn't help either.
For those who are tying to auto/manual target with the Show Battle Res turned on: there are NO such keybindings, nor will there ever be. During combat, Druids should pick their target with Rebirth, not have a target assigned. By default, Priests, Paladins, Druids/Shamans, other Mana users, then non-Mana users are ressed in that order.
That means, if a keybind were set to auto cast Rebirth, you are more likely to res a Shadow Priest (DPS) than to res the Main Tank who just died. Therefore, all the bars do for Rebirth is show the Druid and their target, and you must cast Rebirth the old fashioned way.
I always use the lastest SVN plus any changes/fixes as my test bed. Perhaps I should try the normal file. However, the Interface Panel has worked for me for some time, as has the slash commands. I will look into the non-SVN version and get back to you.
As for the hang up on res targets, I have a workaround, but I'm not sure how to implement it. I have a table, waitingForAccept{} that I need for other reasons, and it could come in handy to solve this issue. I figure I need to use it in the compareUnit() function, but for reason I'm suffering a mental roadblock. http://paste.wowace.com/1640/
If anyone wants to poke a stick at the chat message problems, please download the whole addon, as it is much easier that way. Sorry about that. :(
And centering the text on the bars would be great too.
Textures should be an AceGUI-3.0-SharedMedia widget, and the pulldown is in the Res Bars tab. Read the addon description for links to get more textures.
I am going to post a minor update with r75, which *should* fix the major problem of the auto res feature picking the same target until they accept the res. I'm not getting any errors, but can't really test it myself during the week. Please give feedback here or, if necessary, as a ticket.
Hopefully! :)
I'm sure I just oversaw it. I'll have another look.
I don't know. Looking forward to see it in SR2. ;)