Authors CurseForge

Hello.

I'm trying to make chat addon and have some troubles hooking AddMessage. I think problem is in .xml, but cant find it self. Please help.

xxx.xml

<Ui xmlns="http://www.blizzard.com/wow/ui/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/
..\FrameXML\UI.xsd">
	<Script file="XXX.lua"/>
	<Frame name="XXXOptionsFrame" hidden="true">
		<Layers>
			<Layer level="ARTWORK">
				<FontString inherits="GameFontNormalLarge" text="XXX">
				</FontString>
			</Layer>
		</Layers>
		<Scripts>
			<OnLoad>
				XXX_Options_OnLoad(self);
			</OnLoad>
		</Scripts>
	</Frame>
</Ui>

xxx.lua

local XXX_Old_ChatFrame_OnEvent;

function XXX_Options_OnLoad(self)
	self.name = "XXX";
	InterfaceOptions_AddCategory(self);

	SLASH_XXX1 = "/XXX"
	SlashCmdList["XXX"] = function()
		InterfaceOptionsFrame_OpenToCategory("XXX");
	end

	if (XXX_Old_ChatFrame_OnEvent == nil) then
		XXX_Old_ChatFrame_OnEvent = ChatFrame_OnEvent;
		ChatFrame_OnEvent = XXX_ChatFrame_OnEvent;
	end
end

function XXX_AddMessage(text, r, g, b, id, addToStart)
	this:XXX_Old_AddMessage(text, r, g, b, id, addToStart);
end

function XXX_ChatFrame_OnEvent(self, event, ...)
	XXX_Old_ChatFrame_OnEvent(self, event, ...)
	if (this.XXX_Old_AddMessage == nil) then
		this.XXX_Old_AddMessage = this.AddMessage;
		this.AddMessage = XXX_AddMessage;
	end
end

ok, what happens is when

this.XXX_Old_AddMessage = this.AddMessage;
this.AddMessage = XXX_AddMessage;

executed my chat silences.

pls point me to some direction. other addons done exact same thing and it works...
i've tryed hook ChatFrame_MessageEventHandler, but it not filter everything in chat window.

Just tryed with "this." and "self." in XXX_ChatFrame_OnEvent() func, it doesnt change anything.

The only thing is affecting something if i call it that way:

function XXX_AddMessage(text, r, g, b, id, addToStart)
	this.XXX_Old_AddMessage(text, r, g, b, id, addToStart);
end

it let pass all /say text, guid chat and combatlog, but all other messages isn't shown.

missing channels General/Local Defence, also isnt working
/script DEFAULT_CHAT_FRAME:AddMessage("123")
/print "123"

code in initial post is ok, other addons use code like this, with "func x(self, ...)" and hook to "this." and it working.

From my pov it look like my .lua script isnt assigned to frame correctly. what did i miss?

XXX_AddMessage(text, r, g, b, id, addToStart)

should be
XXX_AddMessage(self, text, r, g, b, id, addToStart)

as with <frame>:AddMessage()

<frame> is automatically passed as the first argument.

A call v:name(args) is syntactic sugar for v.name(v,args), except that v is evaluated only once.

http://www.lua.org/manual/5.1/manual.html#2.5.8

Quote from Slakah

XXX_AddMessage(text, r, g, b, id, addToStart)
should be
XXX_AddMessage(self, text, r, g, b, id, addToStart)
as with <frame>:AddMessage()

no
http://www.wowwiki.com/API_ScrollingMessageFrame_AddMessage

anyway tryed AddMessage(self, ...) - isn't working.

several other addons use exact the same code as in initial post and it works. i'm unsure about .xml stuff.

several other addons use exact the same code as in initial post and it works. i'm unsure about .xml stuff.

Clearly they aren't as yours isn't working :P, are you sure everything is loading, stick print functions everywhere and try and work out whats going on.

i've tryed hook ChatFrame_MessageEventHandler, but it not filter everything in chat window.

If you just want to filter messages then you could use AddMessageEventFilter

and if that doesn't work then heres the code I use to hook the chatframe,

local origadds = {
	[ChatFrame1] = ChatFrame1.AddMessage,
	--[ChatFrame2] = ChatFrame2.AddMessage,
	[ChatFrame3] = ChatFrame3.AddMessage,
	[ChatFrame4] = ChatFrame4.AddMessage,
	[ChatFrame5] = ChatFrame5.AddMessage,
	[ChatFrame6] = ChatFrame6.AddMessage
}

local function NewAddMessage(f, msg, r, g, b, ...)
	--Do stuff here
	return origadds[f](f, msg, r, g, b, ...)
end

ChatFrame1.AddMessage = NewAddMessage
--ChatFrame2.AddMessage = NewAddMessage
ChatFrame3.AddMessage = NewAddMessage
ChatFrame4.AddMessage = NewAddMessage
ChatFrame5.AddMessage = NewAddMessage
ChatFrame6.AddMessage = NewAddMessage

and finally

no
http://www.wowwiki.com/API_Scrolling...ame_AddMessage

yes,
tbl.blah() is not the same as tbl:blah()

but tbl.blah(tbl) has the same functionality as tbl:blah()

tyvm

function XXX_AddMessage([COLOR="Red"]this,[/COLOR] text, r, g, b, id, addToStart)
	this:XXX_Old_AddMessage(text, r, g, b, id, addToStart);
end