Craftygnome does not reply to people when they ask for certain enchants. !enchant bracer healing doesn't work for example, but !enchant 35 agi does. Can this be sorted?
CraftyGnome is a lot simpler than the other crafting whisper addons out there. It works like this:
1. Scan your trade and craft skills when you open them
2. Saves the crafting link (you know those yellow links) of all your craftables
3. When someone whispers you, it iterates all the craft links and puts all the text in those tooltips into a string
4. Then it sees if what they whispered you can be found in any of those strings
5. Returns any results that match
The internal CraftyGnome string for this would be
"enchant 2h weapon - major agility5 sec casttools: runed adamantite rodreagents: large prismatic shard (8), greater planar essence (6), arcane dust (20)permanently enchant a two handed melee weapon to add 35 agility.requires a level 35 or higher item."
So if anyone whispers you "35 agi", it matches because the text there has "35 agility" in it.
But no crafting tooltips include the text "bracer healing".
Ah ok, i noticed Craftygnome was alot more accurate than Craftlist2 when searching for 35 agi (Craftlist2 gave lots of results that gave no sence, like 15 agi on gloves). But i would like CG to behave more like this way too, since most of my guildies are using ''!enchant bracer healing'' instead of ''!enchant bracer superior healing'' since they don't know the full name of the enchant.
Skylinee, Craftlist2 gives results like "15 AGI to gloves" for a "35 agi" query because these enchants have the word "agi" in them, and the word "35" in them. Where is the 35? Well there right in teh tooltip, it says you can only cast it on a level 35 or better item!
CraftList2 arguably is more accurate since it searches the keywords one by one "35" and "agi", rather than a combined string "35 agi".
CraftList2 arguably is more accurate since it searches the keywords one by one "35" and "agi", rather than a combined string "35 agi".
Indeed it is, I'm not sure yet what I want to do specifically for CraftyGnome.
The next thing I want to do is make the !-commands separate for each skill, so that !gem only returns gem results, !cook, !enchant, etc. Pretty sure that would help tremendously on the search results.
CraftyGnome now does an AND search on the query tokens.
So if you whisper "!enchant bracer healing", CraftyGnome will search for any enchanting tooltips that have both the words "bracer" AND "healing" in it, and only returns those results.
I've also added a !next command that can be used to query for the next 5 results in a result set if too many results were found.
In addition, CraftyGnome now sorts all results by level (item level for all except Enchanting, where the required skill level is used), with the highest level results returned first.
The next thing I want to do is make the !-commands separate for each skill, so that !gem only returns gem results, !cook, !enchant, etc. Pretty sure that would help tremendously on the search results.
Would it make sense to make the !craft and !cg keywords search through all the professions (and maybe point out that they should use !lw/!alc/!bs/!whatever instead), 'cos at the moment people who are used to CraftList2 just use !craft and get spammed huge help-messages from people who are now using CraftyGnome :)
Would it make sense to make the !craft and !cg keywords search through all the professions (and maybe point out that they should use !lw/!alc/!bs/!whatever instead), 'cos at the moment people who are used to CraftList2 just use !craft and get spammed huge help-messages from people who are now using CraftyGnome :)
It does this already. People are not "spammed huge help-messages".
If someone whispers you "!craft", they get the following text back:
cg: Accepted commands are !cmd, !foo, !bar, !help, !craft, !cg.
And only commands that make sense for you are listed, so it's not spam at all.
Sorry I didn't mean to sound negative, I might've worded my post a bit badly. :o
My point was that typing "!craft Spellstrike Hood" i.e. in guild-chat will, rather than getting whispers with the pattern, generate that help-message (which can become quite long if the person has lots of alts, my own whisper is three lines long on my chat window configuration)
"!tailor Spellstrike Hood" works, but people used to CraftList will most likely try !craft first :)
Well, first I just wanted to say thanks for the mod :) It works much better than CraftingList2 which I used for the entirety of a day before I had to scrap it because it was causing so many problems. I've used an enchanter-only one on my mage for awhile, and was trying to find something similar for my Alchemist when I noticed you had written one and I decided to give it a try.
I'm going to have to look into why it isn't replying to guild chat though, since it appears thats working for everyone else. I have errors turned off, so maybe I was getting one and didn't see it.
And, for something possibly outside of the scope of this AddOn, I'd love to see some sort of "sync" behavior that would allow a mod like this to "remember" someone else's responses (perhaps guild members and Friends). Every once in awhile with a different mod (enchanting specific) I'd notice I'd get requests for enchants I didn't have, but knew people who DID have it. It would be cool if I could add those in some way: request: !enchant Boar Speed
reply: I have not learned [Enchant Boots - Boar's Speed], please message Soandso, or Thisotherguy for this enchant.
I must admit it isn't entirely selfless though. I do everything I can to keep people asking me for the enchants first, and if I can point them to people who can do it, even if I can't do their combine/enchant, the important thing is they asked me first.
I've added the ability to set notes on recipes, and also the ability to ignore recipes. Both options are accessed by double-clicking the recipe in the tradeskill/craft window. Also, BoP items will always be ignored from now on (you can't toggle this).
When someone queries you, any results will be formatted like this:
"cg> [Recipe link]: Note."
So if you're a tailor and someone whispers you "!tailor cloak of eternity", and you've set the note on that recipe to "5g + mats", this is what you'll send back:
"cg> [Tailoring: Cloak of Eternity]: 5g + mats."
Ignored items will always be omitted from search results.
And, for something possibly outside of the scope of this AddOn, I'd love to see some sort of "sync" behavior that would allow a mod like this to "remember" someone else's responses (perhaps guild members and Friends). Every once in awhile with a different mod (enchanting specific) I'd notice I'd get requests for enchants I didn't have, but knew people who DID have it.
not sure Rabbit would put this in, but as a slight idea there is GuildCraft, it's a bit heaver but does "synch" between players the craftables of just about anyone with the addon..
Would it be possible to support: !enchant <itemlink> so it can return a list of enchants that will apply to that item? Another posibility is !gem <itemlink> and display gems taht would fit in the item although that one could be a bit spammy what with the various combo color gems and some items having all 3 color sockets.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium1. Scan your trade and craft skills when you open them
2. Saves the crafting link (you know those yellow links) of all your craftables
3. When someone whispers you, it iterates all the craft links and puts all the text in those tooltips into a string
4. Then it sees if what they whispered you can be found in any of those strings
5. Returns any results that match
Lets say this is the crafting tooltip for Major Agility:
http://www.wowhead.com/?spell=27977
The internal CraftyGnome string for this would be
"enchant 2h weapon - major agility5 sec casttools: runed adamantite rodreagents: large prismatic shard (8), greater planar essence (6), arcane dust (20)permanently enchant a two handed melee weapon to add 35 agility.requires a level 35 or higher item."
So if anyone whispers you "35 agi", it matches because the text there has "35 agility" in it.
But no crafting tooltips include the text "bracer healing".
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumCraftList2 arguably is more accurate since it searches the keywords one by one "35" and "agi", rather than a combined string "35 agi".
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIndeed it is, I'm not sure yet what I want to do specifically for CraftyGnome.
The next thing I want to do is make the !-commands separate for each skill, so that !gem only returns gem results, !cook, !enchant, etc. Pretty sure that would help tremendously on the search results.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumSo if you whisper "!enchant bracer healing", CraftyGnome will search for any enchanting tooltips that have both the words "bracer" AND "healing" in it, and only returns those results.
I've also added a !next command that can be used to query for the next 5 results in a result set if too many results were found.
In addition, CraftyGnome now sorts all results by level (item level for all except Enchanting, where the required skill level is used), with the highest level results returned first.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumOh, and I implemented this as well.
Thank you
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt does this already. People are not "spammed huge help-messages".
If someone whispers you "!craft", they get the following text back:
And only commands that make sense for you are listed, so it's not spam at all.
My point was that typing "!craft Spellstrike Hood" i.e. in guild-chat will, rather than getting whispers with the pattern, generate that help-message (which can become quite long if the person has lots of alts, my own whisper is three lines long on my chat window configuration)
"!tailor Spellstrike Hood" works, but people used to CraftList will most likely try !craft first :)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYeah, maybe I should make it per-character instead of per-server+faction.
Indeed, and when they see !craft doesn't work, they'll read the message and know what to do.
I'm going to have to look into why it isn't replying to guild chat though, since it appears thats working for everyone else. I have errors turned off, so maybe I was getting one and didn't see it.
And, for something possibly outside of the scope of this AddOn, I'd love to see some sort of "sync" behavior that would allow a mod like this to "remember" someone else's responses (perhaps guild members and Friends). Every once in awhile with a different mod (enchanting specific) I'd notice I'd get requests for enchants I didn't have, but knew people who DID have it. It would be cool if I could add those in some way:
request: !enchant Boar Speed
reply: I have not learned [Enchant Boots - Boar's Speed], please message Soandso, or Thisotherguy for this enchant.
I must admit it isn't entirely selfless though. I do everything I can to keep people asking me for the enchants first, and if I can point them to people who can do it, even if I can't do their combine/enchant, the important thing is they asked me first.
Convert the incoming whisper to lower case before parsing the command. I get lots of "!CG" "!Enchant <whatever>" etc. whispers...
After the error pops up, I can no longer see outgoing messages I am sending.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumWhen someone queries you, any results will be formatted like this:
"cg> [Recipe link]: Note."
So if you're a tailor and someone whispers you "!tailor cloak of eternity", and you've set the note on that recipe to "5g + mats", this is what you'll send back:
"cg> [Tailoring: Cloak of Eternity]: 5g + mats."
Ignored items will always be omitted from search results.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumnot sure Rabbit would put this in, but as a slight idea there is GuildCraft, it's a bit heaver but does "synch" between players the craftables of just about anyone with the addon..
-
View User Profile
-
View Posts
-
Send Message
Curse Premium