The problem right now seems to be, that the new combat log doesnt seem to report some cases of cc break.
Normal swing damage is not shown when breaking the CC, while spells are shown (as an example)
I'm trying to get the Addon working again, but could take som time
maybe I'm wrong, but some functionality could stop working.
self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED","CombatLogEvent")
function youraddon:CombatLogEvent(_,timestamp, eventtype, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, spellId, spellName, spellSchool, extraSpellId, extraSpellName, extraSpellSchool)
if eventtype == "SPELL_AURA_DISPELLED" then
if CCId[extraSpellId] then
-- Found CC breaking
self:Print(srcName.." broke "..extraSpellName.." on "..dstName.." using "..spellName)
end
end
end
If you want to support short time CC like root, you just have to add the SpellId to the CC table.
EDIT: Added print to clarify the use of the arguments.
Date: 2008-03-31 23:46:45
ID: 52
Error occured in: Global
Count: 1
Message: ..\AddOns\CCBreaker\CCBreaker.lua line 281:
attempt to index field 'display' (a nil value)
Debug:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:369:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:345
Plus the standard list of addons. Could someone explain what's going on? It seems from your talking that CCBreaker is working, so I must be doing something wrong.
Committed a fixed version. Hope that's OK with Pheredhel. This should now work as before, "show on" and "show from" are reenabled though the committed previous version was broken regardless.
Committed a fixed version. Hope that's OK with Pheredhel. This should now work as before, "show on" and "show from" are reenabled though the committed previous version was broken regardless.
The event you want is this:
SPELL_AURA_DISPELLED
it's arguments are these:
timestamp, eventtype, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags,spellId, spellName, spellSchool, extraSpellId, extraSpellName, extraSpellSchool
where the first spell-block is the spell that broke the CC, and the second block is the CC that got broken. src is caster, dst is CC'd target.
To identify CC dispells from other effects Recount uses the following spell ID table:
This plus this makes the whole code you need:
If you want to support short time CC like root, you just have to add the SpellId to the CC table.
EDIT: Added print to clarify the use of the arguments.
Date: 2008-03-31 23:46:45
ID: 52
Error occured in: Global
Count: 1
Message: ..\AddOns\CCBreaker\CCBreaker.lua line 281:
attempt to index field 'display' (a nil value)
Debug:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:369:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:345
Plus the standard list of addons. Could someone explain what's going on? It seems from your talking that CCBreaker is working, so I must be doing something wrong.
Ooh, thank you :)
for the Current version I don't even mind if it's dirty hacks.
As soon as my time allows, I want to do a complete rewrite anyway.
So Thanks for the fix
best regards
Pheredhel
Worked great!!! No wipes :)