Okay, so I noticed that Cartographer_Fishing freaks out about not being able to tell where to record a node if minimap rotation is enabled because it finds out which way you're facing by checking the rotation angle of the player arrow model on the minimap (which always points up if minimap rotation is enabled).
However, I was thinking that in the case that rotation is enabled it should be possible to get the rotation of the MiniMapCompassRing model instead in order to accomplish the same thing while minimap rotation is enabled.
Nope, I checked the code last night (I run the latest version of the Cartographer package available via WAU). It is only able to figure out which way you're facing via looking at the arrow model (although the code that finds the model is uncommented and obscure, so I was discouraged from trying to figure out how to implement it myself). It throws a warning to the chat frame every time I cast my fishing line when minimap rotation is enabled, saying that the note has been placed at my feet because it can't determine which way I'm facing.
If there's a fix then it must not have made it into the trunk or something.
I guess I don't understand what's going on, but it looks like getArrowModel() is returning a model, from which line 424 then extracts a facing (angle?). However, in the case of a rotating minimap, line 412 is returning a facing instead of a model. What does it mean when line 424 then tries to get a facing of a facing?
Also, it seems like the angle check ought to be removed on line 425 since a more robust solution is being put in place.
edit: I guess what I'm saying is that it seems to me that line 412 should be removed and line 423-428 should be changed to:
local facing = nil
if(GetCVar("rotateMinimap") == "1") then
facing = -(MiniMapCompassRing:GetFacing()) -- technically it may be better to subtract the value from 2*pi or 360 or whatever the maximum value is, but it shouldn't hurt anything
local arrowModel = getArrowModel(Minimap:GetChildren())
facing = arrowModel and arrowModel:GetFacing()
if not facing then -- note that comment and angle checks have been removed because they are no longer appropriate
ChatFrame1:AddMessage("Cartographer_Fishing: Warning: Can't figure out which way you are facing. Placing note right under your feet.")
Anyways, thanks for following up on this and ignore me if I'm just being ignorant. Also, I'm in code peer review move this afternoon :P