Yeah, it's a glitch. I don't know why, but the database of instances in the Dungeon Finder sometimes uses different names when compared to the instance zones (used for the lockouts). Even when this isn't the case, sometimes certain instances just don't get paired up with their Dungeon Finder information.
Note that there isn't really a great way for me to tell which expansion introduces which instance. I could define a whole database for it, but since there isn't really such thing as a universal Dungeon ID, I'd have to localise it which is where it gets crazy. So for the time being, you may need to manually correct a few.
I'm trying to iron this out.
Yeah, but it's weird. I actually put some debugging code in there and I swear there's a match, but the two strfind's you do didn't get a match. It's really odd (maybe it was a case problem, I will have to look again), I will look a bit further.
I found the problem. In GetLFDID you call strfind twice in order to do a match for the name (and I was doing a direct compare and getting a match). The problem is that strfind does regular expression matching, and any name that has a regular expression operator will possibly trigger a non-match. I fixed it by adding in the optional fourth parameter which specify's PLAIN matching versus regular expressions. Now Azjol-Nerub shows up properly. It looks like this.
if (strfind(details, name, 1, true) or strfind(name, details, 1, true))
and (vars.db.Instances[name].Raid == (details == 2)) then
Had a weird thing happen yesterday, got Azjol-Nerub as my daily random heroic, but when I was looking at it under SavedInstances it showed up under the Classic category versus under Wrath of the Lich King (not sure if it didn't match or what, but it even shows an Expansion of 0 in my SavedVariables file).
From what I saw as well, you should be able to get the right dungeonID by calling GetRandomDungeonBestChoice() which should return the highest one the current character is capable of. But of course than you'll start storing this information for every character, so maybe limit it to 80's.
I plan on linking the last random daily dungeon that was completed (separately for both difficulty levels) to each character, via the lockout ID. That way when the lockout expires, I'll know to reset the status of each character. Might be slightly computationally wasteful for each additional random daily, but it should mean I can track the reset time using Blizzard's data and not have to hardcode anything myself.
Can everyone confirm that the minimap button is working in beta4? Anyone currently having issues with it? Please let me know as soon as possible. I've started tinkering with the daily tracker code now, and when it's done I'll be very tempted to make a full release.
Only thing about that is the Random Daily resets at 3am Server Time and the Heroics reset at 8am Server Time (at least on my PST server), so their not tied together (one resets with the dailies, the other with the heroics). If that's what you mean.
No idea about the minimap button, I use a LDB display.
It's a good idea. I personally do random dungeons before specific ones, so the addon already serves this purpose for me. However, I've been looking into your request and there are a few things I might be able to use to recognise this. I've been digging through Blizzard's new code, which is why work on Savedinstances has been quite slow lately.
I need to test it out a bit, bit I think I can reliably wait for the new LFG_COMPLETION_REWARD event (triggers when you see that new achievement-like reward panel pop up) and just check to see if you currently have the Luck of the Draw aura. I can double-check that you are doing the highest difficulty you can (normal or heroic).
It's a good idea. Any suggestions on how you'd like to have this status displayed? How about a new row displayed with your dungeons titled "Random Dungeon" with a Normal/Heroic indicator for each of your characters?
@zvifflemeyer and co:
Can anyone please confirm that I wasn't able to fix the minimap button issues in beta4? Zaphon's suggestion and this bug report are the only things holding back a stable release at this point.
Yeah, I was actually looking at basically querying the LFD tool just like they do to see whether to display the better rewards or not (it's around line 783 of LFDFrame.lua) which I believe let's you know whether or not they have done the random (based on the dungeonID which is queried earlier). *shrugs*, these are all undocumented API's, so guessing. BTW don't you get the luck of the draw aura on every random?
But yes I would like just an extra row that shows if you have done it on which characters. :-)
...Switch the LFD tool back to random in the drop down and see if it says Frost or Triumph as the reward..? :P
I have 8 80's, that requires me to login to each and everyone of them and see. That's kind of the whole purpose of this mod, and what I use it for already is to keep track of who I've done what on. Seems like the perfect thing to add as well, I even found the API's to check it, just my attempts at hacking it in didn't go so well.
Any chance of adding a way to keep track of whether or not you have done the random heroic dungeon each day? I use this mod to keep track of my 8 80's and what instances/raids I have done, but the biggest thing I am missing now is a way to keep track of which ones I have done the random daily heroic (for my 2 frost emblems) on. This would be handy, as right now when I login each day I queue up for specific instances first, and than after that I go to the randoms, but I sometimes forget to do the random, and hence why if I had a way to see it, it would be awesome. :-)