Well, it's been a long time since you guys had an update. I've actually stopped playing WoW some time ago. While I thoroughly enjoyed the game, and I miss the folks I used to group with, I am also enjoying real-life and at this stage I am fairly confident that I won't be back for Cataclysm.
What this means is that SavedInstances is looking for a new owner. The code is a little ugly, and there's definitely tonnes of room for optimization (particularly with my unnecessary use of temporary tables). There might be a few WoW4-compliance issues when that hits your Patch Downloaders too.
I know that starting a project from scratch is much easier than maintaining an old one, but if you are still playing WoW, really like this addon, and don't want it to become "abandoned", then please let me know. :) It's been a pleasure.
Running into a new problem with GetQuestResetTime(). It reports the remaining time relative to the server time. This is a problem for Oceanic players, and probably for others. Need some time to figure out how to get the difference between local and server time.
The actual daily random expiry would look something like:
expiry = time() + GetQuestResetTime() + (server - local)
Thanks heaps, Zaphon. I've fixed it in my internal branch, and I'll push out a new beta soon. The annoying thing is that in other places where I've used strfind(), I've gone and thrown in the extra parameter already. Seems I just forgot here. :P
I discovered that the LFG_COMPLETION_REWARD event only happens for random dungeons, so that test is now much simpler. I had incorrectly assumed that Luck of the Draw had to be present, but that's only true if you have random members, not necessarily in a random dungeon.
I'm also very glad I hadn't coded in anything regarding the number of dungeon rewards, since Blizzard's new little "incentive" for Oculus might have been confusing.
Yeah, it's a glitch. I don't know why, but the database of instances in the Dungeon Finder sometimes uses different names when compared to the instance zones (used for the lockouts). Even when this isn't the case, sometimes certain instances just don't get paired up with their Dungeon Finder information.
Note that there isn't really a great way for me to tell which expansion introduces which instance. I could define a whole database for it, but since there isn't really such thing as a universal Dungeon ID, I'd have to localise it which is where it gets crazy. So for the time being, you may need to manually correct a few.
I was using those calls you mentioned (OrionShock) for a while, and then it hit me: why not just save the quest time remaining after the first random daily completion? I've stopped checking altogether to see if it's actually been done according to Blizzard. :) I literally wait for the LFG_COMPLETION_REWARD event, and check to see if we have the Luck of the Draw buff, that's all. I'm testing it now.
I'm currently gonna test the contents of the Dungeon Finder window, since the text changes once you've done a daily random. This should mean I have a future-proof way of detecting the daily since I don't need to hard code in specific rewards or numbers of rewards.
That GetQuestResetTime() is genius though. Trying to work it in now.
I plan on linking the last random daily dungeon that was completed (separately for both difficulty levels) to each character, via the lockout ID. That way when the lockout expires, I'll know to reset the status of each character. Might be slightly computationally wasteful for each additional random daily, but it should mean I can track the reset time using Blizzard's data and not have to hardcode anything myself.
Can everyone confirm that the minimap button is working in beta4? Anyone currently having issues with it? Please let me know as soon as possible. I've started tinkering with the daily tracker code now, and when it's done I'll be very tempted to make a full release.
It's a good idea. I personally do random dungeons before specific ones, so the addon already serves this purpose for me. However, I've been looking into your request and there are a few things I might be able to use to recognise this. I've been digging through Blizzard's new code, which is why work on Savedinstances has been quite slow lately.
I need to test it out a bit, bit I think I can reliably wait for the new LFG_COMPLETION_REWARD event (triggers when you see that new achievement-like reward panel pop up) and just check to see if you currently have the Luck of the Draw aura. I can double-check that you are doing the highest difficulty you can (normal or heroic).
It's a good idea. Any suggestions on how you'd like to have this status displayed? How about a new row displayed with your dungeons titled "Random Dungeon" with a Normal/Heroic indicator for each of your characters?
@zvifflemeyer and co:
Can anyone please confirm that I wasn't able to fix the minimap button issues in beta4? Zaphon's suggestion and this bug report are the only things holding back a stable release at this point.
just updated it and my minimap button has disappeared. how do i get it back?
Please check these in this order:
1. Have you installed SavedInstances v3-beta4
2. Is SavedInstances enabled in the Addons section of the login screen?
3. Can you find SavedInstances' settings in the Addons section of the Interface options (in-game)?
4. Does deleting the SavedInstances.lua file from your WTF/.../SavedVariables folders help?
5. Does completely deleting SavedInstances and installing it fresh help?
6. Does enabling/installing only SavedInstances and nothing else help?
I have double-checked that SavedInstances' minimap icon is appearing (and can be shown/hidden) properly when it is the only addon enabled and when the SavedVariables file has been removed. It's working perfectly with my other addons too. This is with v3-beta4, beta3 did have a bug.
I have never tested my addon in disembedded (libraries separately installed) setups so I can't be sure that isn't a problem. However, that sort of configuration is an advanced Curse Client and World of Warcraft setup, so I assume that those users possess a certain technical finesse.
I use BugSack and BugGrabber, so I can train myself to ignore those silly bugs while I'm developing new interface controls. Probably a bad thing. Of course, I then go and make a release and wonder why I'm still getting errors. :)
Aside from that, any comments on how it's working so far?
Boss detection is much trickier than I first thought which is why it's taking so long. I think I might leave it out for now.
Okay, I finally got a chance to sit down and look at SavedInstances today.
- Categories section is gone, sorting options are found in the General section
- category sorting options seem to work perfectly
- Dungeon Finder information is used where possible to automatically fill in instance information (specifically expansion pack)
- I'll need more time to improve the matching between the Dungeon Finder DB and the internal instance names
- Instance Order section is gone, sorting options are found in the General section
Things to look at before next stable release:
- I'd like a few days of having a beta release available for public testing
- finish overhauling Instance ordering
- look at customising Instance text coloring
- look at showing instances that party/raid members are unable to do
- tidy up and automate Encounter tracking
- tidy up Lockout links (when clicking on a particular lockout indicator)
Okay, just thought I'd drop a status report. I'm working on overhauling a few parts of SavedInstances.
Things in the addon currently:
- categories can be manually reordered
- instances can be manually reordered
- instances can be manually categorised
- completed encounters can be manually recorded
Things I'm working on:
- instances will be 100% automatically categorised, no more manual control
- completed encounters are 100% automatically categories, no more manual control
- instances are automatically sorted by either level or name, descending or ascending, no more manual control
- categories are automatically sorted, no more manual control (raids first, dungeons first, or by expansion)
The new Dungeon Finder and Raid Finder tools have opened some API doors for me and I'm currently figuring out how best to exploit them. I won't be releasing a 3.3 TOC for a week or so, but as far as I can tell SavedInstances is working fine already anyhow.
So basically, I'm still alive, SavedInstances is fine, and I'm working on making it a super streamlined and easy to use addon moving forward. Stay tuned. :)
I was thinking about it today and I remembered seeing a LibBossID library (or something similarly named) floating past the WowAce home page recently. The problem is there are several encounters where the boss doesn't actually die (like The Keepers). And there are other weird encounters where the bosses can die in variable orders (Assembly of Iron), but that wouldn't be too difficult to manage.
If only there was a LibBossEncounter or something, that would instantly identify the encounter that was started, and determine a successful outcome. It would be terrific if it also tracked the encounter hierarchy, such as being able to group Thorim, Freya, Hodir and Mimiron as "The Keepers" and not expect General Vezax until The Keepers was checked off.
I dunno. It's just getting yuckier and yuckier. /sigh
Note also that it's possible to kill certain bosses without getting saved in 3.3, via the LFG random-dungeon system. Yet another whacky case for SavedInstances to figure out.
Okay, well, my first session of coding for quite a while. I'm really happy with what I've done to SavedInstances. v2.5-beta should be syndicating as I type this. If all goes well it should be a full release in a few days of testing.
My major concern with the setup interface was the "world of dropdowns" that I inflicted upon the user. All unnecessary dropdowns have been removed in favour of lists that are much friendly.
There is a new feature in this release: encounters! You can define encounters for each instance in the Instance tab. Then, you can tick them off in the Lockouts tab as you go along. Make sure you enable "Show encounters" in the general tab if you want to see this in the tooltip. I know this isn't automatic yet, but I think it will still be useful. Making it work without user intervention is a really really big task. If anyone has any suggestions, I'd love to hear them.
So go go, download and test. And praise or complain. :)
There are already tickets up for most of what you've suggested. I've been thinking about how to do synchronisation for a while now. I dislike the idea of relying on a heavy translation library for something as simple as instance names, but it does seem like a necessary evil.
I've been thinking about ways to support instance farming groups, and the low-hanging fruit seems to be simply storing the name/realm of group members whenever we are saved.
It's a whole big can of worms and I do plan on opening it eventually.
Regarding the categories and re-ordering, they were items that I wanted in there personally, but there are provisions in place for those who aren't interested. The only piece of information I can't easily figure out about any particular instance is which expansion it belongs to (it defaults to "Classic"). Instances are otherwise automatically categorised into dungeons (5-man) and raids (everything else). You don't have to spend any time classifying them yourself, and you can hide the category names if you don't like seeing "Classic" in the tooltip.
Thanks heaps for the comments. I plan to continue improving this for the foreseeable future.