Back again to the (2^31-1 %) bug. I sometimes had "(-- %)" displayed on some actions, it was always when something happened after somebody was already dead, for expample when somebody was at 500/8000 HP, got 2k damage and was healed after that. I guess that could be a problem with the combat log latency, but nothing which needs to be fixed, it still shows everything interesting.
I was just in Zul'Aman and one tank had many disconnects, so we died many times.
When we finished, 3 group members had all their death reports filled with "(2^31-1 %), while the other 7 members had normal reports.
I noticed that I wasn't able to select the names from the 3 "bad" members from the dropdown menu in the Acheron GUI (yes, all 10 where still in group). The other 7 members showed up and one entry called "unknown", which showed nothing when I selected it.
I was however able to right-click on a unit frame and see the death reports all group members this way.
I don't know what made the 3 "bad" member entries special, they all were in the group all the time. Even the death reports for our tank who had the disconnects were fine.
All people who want to see aura gains/fades (including stacks) can edit Acheron with the small patches I posted here, until it's officially implemented in Acheron.
It will also display an aura break/refresh, but since it only was a quick hack, I didn't filter them out. I didn't change the code much, so it should work fine for everybody. It has been working fine for me in the last two weeks in MH/BT raids.
Shinja, when you saw this, did you also see the funky health % numbers like what Menju posted in his screenshot earlier in this thread?
Oh, and what version are you using?
I also had the funny health % today, using latest r80961. When moving my mouse over the entries, it would show people with "0/0 (2^-31%)" health. So the wrong entry seems to be the result of a division by zero (0 div 0). I only had this kind of entries on raid members who where very far away from me (possibly > 40m, Archimonde battle). The raid mebers near me had their normal health displayed. It might be a problem with the range of the combat log.
I did some small code hacks to show what idea I was thinking of.
(all edits done in "Acheron.lua")
if eventType == "UNIT_DIED" then
-- elseif eventType == "SPELL_AURA_APPLIED" or
-- eventType == "SPELL_AURA_REMOVED" or
-- eventType == "SPELL_AURA_APPLIED_DOSE" or
-- eventType == "SPELL_AURA_REMOVED_DOSE"
-- self:HandleBuffEvent(event, timeStamp, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
self:HandleHealthEvent(event, timeStamp, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
elseif suffix == "MISSED" or special == "MISSED" then
missType = select(4, ...)
elseif suffix == "AURA" then
local buffCount = select(5, ...) or 1
amount = 0
source = select(4, ...)
if buffCount ~= 1 then spell = spell.."("..buffCount..")" end
if special == "APPLIED" then
action = " >>> "
elseif special == "REMOVED" then
action = " <<< "
elseif suffix == "DAMAGE" then
I know it's a bit dirty since it doesn't fit in the design of the event system, but it does its job.
I didn't want to turn Acheron into some kind of healer assist addon, I just took the silence as an example when knowing about a buff/debuff is helpful to understand someone's death, even when it didn't heal/damage anybody. It might be a nice feature to let the user choose to log all buffs/debuffs or just the important ones (from debuffs.lua).
It's just confusing that when somebody resists a debuff it will show up in the death log, but not when he gets the debuff.
How would Acheron be able to discern that the reason the tank died is that the main tank healers were silenced, for example. It would have to somehow understand who the main tank healers were (track some sort of total healing?) and then track a silence debuff on someone else in the context of that player's death.
I didn't think of such a complex solution. When some boss uses silence, the whole raid will get silenced. So the main tank would also have the "silence" debuff, even if it has no effect on him.
I just thought of a simple way to log any buff/debuff gain and fade. No complex calculation would be needed, just a simple entry in the death log with time and (de-)buff name.
One feature which I really would like to see in Acheron is having applied und removed auras to show up in the death log.
I'm don't want to know that somebody died because he took too much damage or got no healing. I want to know why.
Was there a silence effect? Was shield wall running? Was the paladin to far away so the tank lost the fire resistance aura? Did the mob resist the hunter's feign dead or didn't he even use it? Did the player use blood fury?
All these questions are not answered by the death log, I only see DoTs or HoTs when they actually do damage or healing, nothing more.
The interesting part is that the death log shows when sobody resist a debuff, but not when he gets it.