I'm in the process of adding a new system that has two priorities per mob - tank and cc priority. This isn't required for using the addon but can be nice in some circumstances. With this comes a new marking logic that is currenty working but flawed (especially it will completely mess up marks mid combat). Once I'vr stabilized that a bit I'll look at releasing some data at least.
Thank you, Thank you, Thank you!!!
I would call the tank priority "kill priority", but that shouldn't matter for the usage.
MagicComm is a separate addon. It should be added automatically by WAU as a dependency. It's not bundled because it's an addon, not a library.
It is not added automatically by JWowUpdater and, if it is required, it's want it to be downloaded together with MM (other addons that are a collection of addons like Bongos, Auctioneer etc put all the addons in one zip file). If MC is not optional I think you need to tie them closer together.
I have been running without MM for a few days because it was missing a dependency. I went and downloaded magiccomm and it works again. Is MComm a required dependecy, and if so, why doesn't it come bundled? I'm updating with JWU and have it set to split out libraries.
I'm mainly using MM for 5-mans so that may influence my thoughts on it. I ran Hero Ramps last night and made sure I had everything setup. I still ended up with a lot of manual marking and realized there is one more variable needed that should be set manually per run:
Minimum # tank targets
We had plenty of two pulls where one got marked sheep and the other trap... hmm... weren't we supposed to kill one of them? In the absence of a "swipe, then mark" system you could still achieve the correct result if you mark the "tank minimum" first, before you start assigning CCs. Of course that may still require some swapping and, ultimately, a "swipe then mark" system would be best.
Speaking of "swipe then mark"... can we get some target frames created similar to Proximo by MM? I'm not sure if 2.4 will allow targetting through such frames, but it would still be useful. See the PerfectTargets thread in Addon Ideas for some thoughts on this.
Thanks for the last update. A global CC priority list and then just a list of useful CCs is excellent!! I like the "sweep then mark" approach you're considering for 2.4.
One other thing that you could consider... have manual markings imply CC ability. Today I ran Hero Mech with two hunters and MM is configured for square then circle for traps. If I sweep first and then manually change marks to square and circle, MM could infer that those mobs are a) to be cc'd and b) can be cc'd using traps. None of this would matter once you're set up, but for 5-mans in particular it is nice to help build the database right the first time you run through.
The other thing I'd like to be able to do is to go through the database outside of WOW and update it after a run (I can't play at all times due to wife agro :-). It would be great if you could post a key to the saved variables file (margicmarker.lua) for those of us that would like to edit it.
Do you really need "category"? If CC options are set to "none" that implies tanking. Couldn't you just go down to a kill priority, a cc priority and a list of available CCs?
Ya, I thought of this, however, when we have pulls with 8 mobs, sheeps end up being X and Skull. If I mirrored the sheep icons to be skull, X, square, moon, triangle, diamond, circle, star.. when I get to the pack of 6, my sheeps will be skull and X instead of square and moon.
Also, I'd want the assassin moved not only to the 4th tank spot, but rather to the 2nd spot.
It does seem like it would make sense to rethink the structure of how MM works a bit. I think most of us have two priority lists for any given pull, a Kill Priority, and a CC Priority. Like Odlaw points out, these are not necessarily the same. Lets assume we have 5 mobs (A-E). Our preferences are:
Kill Order: A E C B D
CC Order: E D C (B and A cannot be CC'd)
If we have 3 CC we'll kill A B followed by the CCs (C D E if they're all "the same type of CC").
If we have 2 CC we'll kill A C B followed by D E.
1 CC: A C B D E
Now, there are two more priorities that I think most agree with but that are not dependent on the actual mobs (there are some exceptions, but that is always the case). These are priorities for CC type for Application and Breaking. I.e. if we have multiple forms of CCs we can use, which do we use first and, given that we have used a few different types of CCs, in which order to the will them. The second one may not really be that important and is also, for the most part, and inverse of the first one (the reason sheep and banish are high priority types of CCs is that they can be kept up). Lets assume that we have a rogue, a mage and a hunter and that we have set the follow priority for CC: Sheep > Sap > Trap. Also assume that our C-E mobs can all be CC'd by any of these three. We'll now get:
Tank A & B, Sheep E, Sap D and trap C.
What we need for this system to work is to assign two priorities to the targets: Kill Priority and CC Priority. I'm not sure we need to assign a CC type priority the way it is right now. Rather we need to note WHICH TYPES of CC we can use on the target. Also we need a global CC Priority list (that tells us which CC to apply first). I think such a setup would be easier to administer and use as well as be more flexible.
For each mob:
Kill Priority: 1-5 with 1 being the highest priority
CC Priority: 0-5 with 0 being "never cc" and 1 being the highest priority.
Useable CC: check list of useable CC.
CC Priority Order
CC Icon Priority (like now)
Tanking Icons (like now)
Finally, the current default is to set all mobs to tank, priority 3. That is not the standard assumption of most groups. Rather, the assumption is that you'll CC everything you can and tank the rest. Thus assign everything kill order priority 3 and cc priority 3 and assign CC targets based on what's in the group. If you can use the mobinfo to determine CC Immunities (for sheep, banish, sleep etc), so much the better... otherwise this has to be entered by hand.
I think the above application would make MM even better (and it is also pretty sweet).
One thing that would be nice when you run through an instance the first time would be a key bind for "is CC". Right now everthing gets assigned to medium importance tank, but it would be nice to quickly be able reassign something to cc for later refinement.
Looks great so far. How about adding a key to erase marks off mobs though? Like alt-mousover to mark and ctrl-mouseover to erase? I had modded ezicons to use a mod database for myself but yours is looking far nicer. But I do miss that feature:)
I've only used MM for one heroic SL and I didn't do any setup... just moused over in order of importance. It did seem to me that there might be a great way of marking that may or may not be supported. Does MM "remark" as I mouse over? Lets just say I have a two pull with tank and off-tank and I mouse over them in the wrong order (start with the off-tank target). I assume MM will mark the first one with Skull. Now, when I mouse over the second target (that should have the skull since it is higher priority), will MM switch the old one to X (or whatever the second tank target is)? It would be great if it did that, either automatically, or if you could just have one key to "reassign all marked targets" at the end of marking the pull.