I don't understand why this woul dbe of that big complexity. Most checks must already be in the code as they are used by the data filtering (like in groupo, raid, instance, raid instance, battlefield,...).
It's not the complexity of the underlying code that's the problem, it's the complexity of the options that would need to accompany them. Doubling the number of options to support automatic showing and hiding of specific views in specific windows under specific circumstances would just not be worthwhile for the vast majority of users, which is why I suggested it was a good candidate for a third-party plugin. Writing it as a plugin also means that anyone can write it -- you're not left relying on a single person (the current maintainer of Recount) to do it. Even you could write it yourself!
Is it possible (or could zthis be made possible) to have th erecound window/graph appear in specific events, for example I would like the recount bar window to show when in an instance, and the graph just after a boss fight. Of course other events may be usefull like "when in a group",...
Sounds like a good candidate for a third-party plugin, but probably too much complexity to add the existing options in the core addon.
You can try "instance_chat" instead of "instance" since that's the actual name of the channel (why Blizzard put the _CHAT prefix on there, who knows, probably gave the task to the new guy after taking him out for drinks to celebrate his hiring) but it may give you an error about that not being an allowed value.
Sorry, I wasn't habitually checking this thread. What Farmbuyer said is correct. Any time anything about the group makeup changes, a popup appears. (Or rather, appeared, as I'm not currently playing the game at all, and my addon-testing trial account doesn't have access to scenarios to see if anything has changed since my original post.)
However, the main annoyance that led me to report the issue was that at the end of a scenario, when I'd be trying to review my Recount data for the run, I'd get a bunch of "new group, want to reset?" popups. After reading Farmbuyer's post, I think it may have been 2 popups for each other player as they left -- one as they ported out of the scenario, and another as they actually left the group -- plus several more popups for no apparent reason, before anyone left, possibly as some event fired to indicate that the scenario was completed.
I'll edit this post later to attach my saved variables file.
"Script ran too long" errors happen when your computer is too slow to keep up with the work an addon is asking it to do. In some cases, there may be optimizations that could be made in the addon to reduce the amount of CPU time it consumes, but not always.
Your specific error comes from LibGraph-2.0, a library which is pretty old and not actively maintained, so it's unlikely anyone is going to rewrite it for any possible optimizations. You can either ignore the errors if you're not too frequent, or just avoid keeping real-time graph windows open while you're in combat.
Well, arbitrary means "based on individual discretion or judgment; not based on any objective distinction, perhaps even made at random" and individual (in context) means "single", so an arbitrary individual unit would be a single unit (such as "player") chosen by your personal preference.
Recount isn't designed to track, say, damage for all group members, healing only for priests, buffs only for Joebob, and dispels only by the player. It only has one set of filters, and tracks all data based on that set of filters. Adding a separate set of filters for every type of data collection would introduce a huge amount of complexity, and is not what Recount was designed for.
You can already track buffs and debuffs on your own character with Recount -- either enable that type of data collection for all of the units you have included in your filter settings, or disable all units except "player" in the filter settings and don't collect any type of data for anyone other than yourself.
If you want to apply a custom filter set to some type of data, you need a plugin.
Elsia, is there anything you can do about the super-annoying reset prompts in scenarios? I have both "Delete on New Group" and "Delete on New Raid" enabled, with confirmations for both. Every time I join a scenario, I get several back-to-back prompts to reset the data. During the scenario, I get prompts apparently at random, anywhere from 10 seconds to 5 minutes apart. At the end of the scenario I get several more back-to-back prompts, and then another prompt each time someone leaves the scenario before me. Ideally it should only prompt me once, when I enter the scenario.
Well, I'm not using the addon named SharedMedia, so it's possible, though the addon that registers most of my custom media should load before Recount since its name starts with "P".
Anyway, registering for the callback from LibSharedMedia seems to solve the issue, or at least the texture list hasn't been stuck showing only the default 5 textures any time I've opened it since adding that line.
I've noticed that the statusbar selection list frequently fails to update. It seems to get stuck using the list of statusbar textures that were available when Recount loaded, and the only way to force it to update to show all of the available textures is to manually call the list's scroll function:
Since the initial list isn't long enough to produce scrolling, the scrollbar is disabled and the mousewheel seems to be ignored, so there's no way to "really" call the function. I've added an OnShow hook for the config window in my private "fix stuff" addon that calls the scroll function whenever the window gets shown, but it would probably be best just to figure out why Recount isn't updating the list automatically, and fix it. :)
I'd prefer #1, as I don't really care to ever see anything other than 542, 4.8k, 52k, etc. as the difference between, say, 52123 DPS and 52132 DPS is not worth the screen space it takes to show it. Those who want to see the full number are free to turn off number shortening and see it.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
It's not the complexity of the underlying code that's the problem, it's the complexity of the options that would need to accompany them. Doubling the number of options to support automatic showing and hiding of specific views in specific windows under specific circumstances would just not be worthwhile for the vast majority of users, which is why I suggested it was a good candidate for a third-party plugin. Writing it as a plugin also means that anyone can write it -- you're not left relying on a single person (the current maintainer of Recount) to do it. Even you could write it yourself!
Sounds like a good candidate for a third-party plugin, but probably too much complexity to add the existing options in the core addon.
You can also just call the function directly:
Broker_Recount has existed for years.
However, the main annoyance that led me to report the issue was that at the end of a scenario, when I'd be trying to review my Recount data for the run, I'd get a bunch of "new group, want to reset?" popups. After reading Farmbuyer's post, I think it may have been 2 popups for each other player as they left -- one as they ported out of the scenario, and another as they actually left the group -- plus several more popups for no apparent reason, before anyone left, possibly as some event fired to indicate that the scenario was completed.
I'll edit this post later to attach my saved variables file.
Your specific error comes from LibGraph-2.0, a library which is pretty old and not actively maintained, so it's unlikely anyone is going to rewrite it for any possible optimizations. You can either ignore the errors if you're not too frequent, or just avoid keeping real-time graph windows open while you're in combat.
Recount isn't designed to track, say, damage for all group members, healing only for priests, buffs only for Joebob, and dispels only by the player. It only has one set of filters, and tracks all data based on that set of filters. Adding a separate set of filters for every type of data collection would introduce a huge amount of complexity, and is not what Recount was designed for.
You can already track buffs and debuffs on your own character with Recount -- either enable that type of data collection for all of the units you have included in your filter settings, or disable all units except "player" in the filter settings and don't collect any type of data for anyone other than yourself.
If you want to apply a custom filter set to some type of data, you need a plugin.
Well, I'm not using the addon named SharedMedia, so it's possible, though the addon that registers most of my custom media should load before Recount since its name starts with "P".
Anyway, registering for the callback from LibSharedMedia seems to solve the issue, or at least the texture list hasn't been stuck showing only the default 5 textures any time I've opened it since adding that line.
Recount_Config_StatusBar_Scrollbar:GetScript("OnVerticalScroll")(Recount_Config_StatusBar_Scrollbar, 0)Since the initial list isn't long enough to produce scrolling, the scrollbar is disabled and the mousewheel seems to be ignored, so there's no way to "really" call the function. I've added an OnShow hook for the config window in my private "fix stuff" addon that calls the scroll function whenever the window gets shown, but it would probably be best just to figure out why Recount isn't updating the list automatically, and fix it. :)