= true, -- Valithria Dreamwalker
 = true, -- Valithria Dreamwalker (Phased)
are the boss, so that isnt missing.
Elsia, do we need to add the adds in there or will be we able to solve it otherwise? Maybe just an outdated libbossid in her?
The boss is listed in my libbossid it's just not separating the tries into sections probably because you never actually damage the boss since it's friendly.
There is nothing in the code that prevents recording of friendly fire with the exception of self-kills. Can you send me the relevant combat log lines?
It's not the actual recording of friendly fire it's missing, it's death's caused by them. On the Blood Queen encounter it's possible to be killed by others friendly fire, but when you look at the deathlog it's not visible, you just see the person go from a high amount of HP to dead with no reason logged.
Agree with this, though I picked last night because we didn't wipe and there's no trash in ToC (the Ulduar part for the weekly raid quest involved vehicle trash and I'm not 100% sure Recount works well with that or even sees the data anyway).
Regarding what's suggested above, that's kinda why I brought up the DeathTrack plugin. Should it have its own SV? Also, since I was never clear on it, doesn't Recount track some sort of death info without the plugin anyway? I'm not even sure of the differences.
Recount does track deaths and also allows you to see the last 10-15 seconds or so of what happened to a person before they died without any plugins.
Would it perhaps help to split Recounts saved variables into multiple files? Such as having deaths recorded into a separate file? If it's only the save of the file causing the issue, or is it definitely the amount of addon memory being used by Recount?
I've personally only ever had the error when I increased the number of past fights past the default.
Has anyone ever encountered a problem where Recount will show people with the wrong class colour? It seems to happen more often if I alt tab a lot, but it's not 100% reproducible, some times I'll have almost the entire raid showing up with the druid or hunter class colour.
Were any other combat log related mods working? SCT/MSBT for example? I've noticed last patch and also this patch that the combat log randomly stops working, when this happens Recount won't log any data.
What exactly are the symptoms with vehicles? They don't show at all? They only show if unmerged? They don't show randomly?
Code is there to handle vehicles (implicitly through pet detection), so I wonder why it may not be working as intended.
Single person vehicles seem to be fine such as when you use the mounts in the new 5 man dungeon. Multi person mounts such as on Flame Leviathan a lot of the time doesn't record all the vehicles. Though I'm not even sure if the different parts of the vehicles, e.g the siege engine and the turret position on the siege engine are even able to be linked as coming from the same vehicle.
How about making Recount handle bosses that involve siege vehicles better? It still can't track Flame Leviathan properly, we have people missing who are driving vehicles every week, it seems if the passenger doesn't do damage it doesn't always give them a damage done bar.