Authors CurseForge

Quote from moreofthesamez

I have never had logout problems with Wow and have played since vanilla but since 5.4 it was taking up to 40-50 seconds to exit WoW and after disabling all addons and loading one at a time it turned out to be Recount. Any ideas why that would happen?

Try clearing your saved fights before exiting.

There is a limit to the size tables can grow before you get an error.
Don't quote me on the exact figure as I don't remember where we were discussing this (been a while) but I think it was around the 100mb mark.

It's possible Recount has code to clear out stored fights when the saved variables size gets overlarge.

Since it always pays to be cautious than to try get as close to the limit and have an error / lose all settings that might be around the 50mb mark.

There might also be a limit on the fight segments stored in options.
Did you check if there is such a setting, or even if you have it only keep boss segments or all fights?

For the game to write to disk the saved variables of any addon you need to logout or type /reloadui as a chat command to reload your user interface.

Then you can copy your saved variables out for backup and / or restore later.
To restore you would indeed need to be fully exited from the game or at least at the login prompt (not the character selection screen).

Just a heads up that the recent 5.1.0c tag didn't package.

Quote from Elsia

Interesting. I'd love to read the actual work. Not so much for deletion but in order to make the config window more robust for in-combat use.

Remembered; the reference was in this ticket comment to AceTimer-3.0 (before the conversion to use the animation system)

Just want to chip in that about the limit to execution time (on PC, it might be different for Mac) has been found to be ~200ms in combat, 150ms being considered 'safe' (at this moment, Blizz might change it).

This is not my work, just remember reading about the testing on some ticket comments (exact ticket escapes me atm, but the numbers stuck in my head)

It's just an aside, not exactly pertinent to the last couple posts although I think I remember that rowaasr13 suggested optimizations mainly had to do with CLEU handling and had been shown to be inconsequential through actual profiling the last time around.

I have to say that was a rather long time to be lurking to get a final stab in :P

Quote from kojen

I tried to find (but was unsuccessful) a post regarding posting meters in the new instance channel in instances. I'm sure someone must have said something by now... but I suppose, just in case.

Alot of people (myself included) are considering the specific breakage a blessing in disguise.

There's afaik no reason (other than being obnoxious) for spamming meters in LF? runs.
It is not the environment to train people or to tell them they're bad or to show off how good you think you are.
No - on - cares.

So while the "fix" is trivial I'd vote for making it a feature and leave reporting only for environments where the above have some meaning.
(ie an organized team where combat analysis can provide feedback useful to the team)

Recount is hitting the script run time error when trying to clear data in combat too
(for example if you accept an invite to group while in combat and the relevant option to prompt on group is set)

1x Recount\Recount-r1221.lua:908: script ran too long
Recount\Recount-r1221.lua:908: in function "ResetData"
Recount-r1221\GUI_Reset.lua:73: in function <Recount\GUI_Reset.lua:73>

Workaround would be to defer till combat exit I guess.

As I meddled with this recently I'll say that both IsInInstance() and GetInstanceInfo return nil as the instanceType for scenarios while the first return is true for IsInInstance()

There's an additional function IsInScenarioGroup() for checking when you get 1,nil from IsInInstance()
As well there's C_Scenario.IsInScenario()

Quote from Galvin

Wasn't showing dps when in a scenario. They're new just opened up yesterday for theramore. Recount was blank not showing anything, not sure if I missed something.

Without having looked at the code yet, what comes to mind is the options for the filters that control data collection/showing.

If LFG_SUBTYPEID_* is used somewhere for those probably LFG_SUBTYPEID_SCENARIO is not taken into account yet.

Getting a hard crash ERROR #132 Exception (FLT_INVALID_OPERATION) on MoP Beta (r1201) when I try to 'show graph' from a combatant bar.

The crash dump reports

Current Addon: Recount
Current Addon function: Recount_GraphWindow_LineGraph:CreateGridlines

That's for build 15913 of the wow client.

This is related to the r1200 file for MoP beta.

PARTY_MEMBERS_CHANGED and RAID_ROSTER_UPDATE are gone.
Replaced by GROUP_ROSTER_UPDATE.

GetNumRaidMembers() and GetNumPartyMembers() are gone as well.
If used with > 0 as a raid or party check this is done with IsInRaid() and IsInGroup() in MoP (2nd one is not exclusive, can return true while in raid as well)

Mostly found these in the \deletion.lua code.

Is this a problem with Curse Client maybe?
I manually installed the latest alpha and get no errors on beta, tried both on my transferred toons and a new monk, it works error-free.

Quote from Elsia

I'm not sure I understand this correctly, but it should already use the boss name for segmentation. It may not pick the ideal boss-level entity, but it certainly should pick a present and relevant one (relevant in the sense that it indeed is a boss-level mob in the encounter).

He probably meant Spine not Madness.
There's not fight segmentation for Spine in Recount afaik.

Quote from Elsia

@Dridzt: Tricky one. I think I spend some time a while back trying to track this down. It seems to me to be some sort of pathological case of he scrolling code. Recount uses blizzard's template for this. I cannot identify that Recount makes any mistake, so I'm tempted to say that it's actually a weirdness of the template itself. It only occurs for very specific window sizes, and resizing the window variably is a pragmatic, though not pretty fix for the issue. If I have disposable time I may try to track this down some more, but it's a tough one to nail down.

No worries, it's cosmetic only. :)
Fyi, I was never able to get the proper color by resizing the window up or down or scrolling,
it just rotated between 'wrongcolor1', 'wrongcolor2', 'grey'.