I changed Violation to use unit GUIDs internally now, so the pet issues should be solved. I didn't get a chance to test it in a raid, group or with an *actual* pet yet. But theoretically it should work I think :P
Lots of users have asked for something simple like changing the color and opacity of the background color for instance.
Yeah, lots of people have asked for it, and yet we're not going to add options for it.
Quote from Helfgrim »
I have quoted those I found on page 42. Yet no answer at all for something so simple. Instead the developer sits in his ivory tower staring at his navel. Developing is about communication as much as it is about anything else. If you can't communicate, then go do something different. This is a user forum, not a developer forum. So if you can't stand the heat, get out of the kitchen.
Developing isn't about communication at all, I've no idea what dark place you pulled that phrase from. We develop Violation for ourselves, the fact that you get to use it is a priviledge, not a right.
wowace.com is a developer forum, so if you can't stand the heat, get out of the kitchen.
<BankZ> I tried to regiester with wowace to make a post for a violation request
<BankZ> but I couldnt get it to send me a email to verify my address
<BankZ> so, can I just give you my request :)
<BankZ> I would love it if it would filter out non-combat data
<BankZ> it would also be nice if it auto disabled if not in a group
<BankZ> but thats less important
<BankZ> outa combat healing data is kinda worthless
<BankZ> so I would love to filter it out like SWS
Well in fact, I planned to use CombatEvents for combat start/end autoreset, using the Group events. Cause when you are a hunter, Feign Death will take you out of combat and resets Violation :/ (I didn't include this change in the diff file.)
You're thinking about Violation as a group representation, while in fact the whole communication and presentation is tailored so that your data can be different from the rest of the group without impacting the accuracy of the global dataset.
There's no need for the combat start/end to be using any kind of group-in-combat check, and a hunter FD'ing is even simpler now than it ever was before with UnitIsFeignDeath(unitId) -- see how we use it in BigWigs to check if you've wiped or not in an encounter.
The patch seems good, except the introduction of CombatEvents-1.0.
The idea about it is good, since it would make the PerSecond modules more accurate with respects to parsing data for non-Violation users, but the problem with "per second" numbers is that their accuracy is all based on the users perception of how they should be calculated.
Damage per second can include
1. The damage done from combat start to combat end / number of seconds combat lasted.
2. The damage done from first damage done to last damage done / number of seconds damage was done.
And I'm sure there are other ways to calculate it that are "more correct" to some users.
Previously, we did it simple, and went with the second one, which requires no extra libraries.
Who are we to decide which one is more correct?
As long as going with #2 keeps the number of libraries down, that's the one I'll go with.
So please cut out the CombatEvents-1.0 inclusion for now, and commit.