I fixed the Riposte-trigger (finally) in 81000 by removing the IsSpellUsable-check from the Spell-ready-condition
if some other trigger breaks, just add an additional "Spell Usable"-condition and notify me please.
Quote from greylock »
Appears that actually no buff fades were displayed at all anymore, sorry.
Downgraded to 80495 and it works again :).
as of the latest revision mend pet has suddenly become a normal heal again (ie it shows up under all 4 heal over time filters (incoming pet, outgoing pet, incoming heal over time, and outgoing heal over time). Would greatly appreciate it being set back to only show up on the pet filters.
should be fixed in 80282
Quote from Saroz »
[2008/08/11 22:28:13-190-x1]: Parrot-r79622\Data\CombatEvents.lua:73: LibRockLocale-1.0("Parrot_CombatEvents_Data"): Translation "nil" does not exist.
Parrot-r79622\Code\CombatEvents.lua:1260: in function <Interface\AddOns\Parrot\Code\CombatEvents.lua:1255>
<in C code>: in function `gsub'
Parrot-r79622\Code\CombatEvents.lua:1619: in function <Interface\AddOns\Parrot\Code\CombatEvents.lua:1587>
Parrot-r79622\Code\CombatEvents.lua:1722: in function <Interface\AddOns\Parrot\Code\CombatEvents.lua:1719>
<in C code>: ?
LibRockTimer-1.0-1118 (FuBar):297: in function <...Ons\FuBar\libs\LibRockTimer-1.0\LibRockTimer-1.0.lua:227>
Happens on sunwell protector trash, cause their damage type is Shadow+Nature or something - shouldnt die cause it finds a damage type it can't handle...
fixed (a bit dirty. showing no damagetype for that now)
fixed the block, parry, dodge, and crit-triggers
added a small fix (but with great impact) for all combat-event-triggers.
It should resolve a lot of issues with triggers, and fixes combatevents not showing if a trigger with the same combatevent is there.
Quote from jmrwhoisspy »
EDITEDIT: Earth shock is triggering an interrupt sometimes. Not sure why it doesn't' on all spell interrupts. Will test it further.
It always shows for my schamy.
edit: anyways, I commited a possible fix for those, and maybe other combatevents
I looked at the "Reactive Skills" event, which it seems to be, but the tag tooltip doesn't seem to line up. The [name] tag is catching my name, not the enemy or the ability name.
fixed in r79048
Quote from jmrwhoisspy »
Did the way that reactive abilities are handled by the combat log change somewhere along the line? I'm unclear why they should be different then any other sort of damage, *unless* parrot, recount, etc, can keep track of who's damage aura did what. Example: If in a group, the druid puts thorns on everyone, the druid is credited with the damage done by those thorns.
It does not keep track of that.
I seperated the events, because reactive skills can become spammy (e.g. on prot-pally I suppose).
But the Curseforge version doesn't contain any bugfix/feature that isn't in the WowAce.com version, or?
the curseforge-versions will just be stable snapshots of the wowace-version. The most recent will always be wowace's one, but I won't break the one on curseforge (since curseforge allows seperation between release and beta).
(I really look forward to the new wowace)
Quote from Yesaria »
I have a little problem but my Killing Blows don't work any more...
fixed, the Extra attacks were affected by the same typo (are fixed too).
and... why the sudden breakage?
I rewrote the whole combatlog-handling to make it easier to introduce new features. The old one was just copied from recount and wasn't quite flexible.